1315586 - DecodedStream::NotifyOutput() should compare |a->mTime| to GetPosition() instead of |aTime|

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/f5c9e9a249637c9abd88754c8963ecb3838475cb/dom/media/mediasink/DecodedStream.cpp#720

We should consider |mStartTime| when comparing audio timestamps.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1315586 - DecodedStream::NotifyOutput() should compare |a->mTime| to GetPosition() instead of |aTime|.

Review commit: https://reviewboard.mozilla.org/r/90948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90948/

Comment 2

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8808028 [details]
Bug 1315586 - DecodedStream::NotifyOutput() should compare |a->mTime| to GetPosition() instead of |aTime|.

https://reviewboard.mozilla.org/r/90948/#review90736

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09c6816c1341
DecodedStream::NotifyOutput() should compare |a->mTime| to GetPosition() instead of |aTime|. r=pehrsons

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/09c6816c1341