1306458 - Figure out how to make gOpenPopupSpamCount work with multiple content processes

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

And in particular, with window.open() calls that involve opening the window in a new process.

Which process's open popup spam count should the window count against?  Or both?  Or should this count be maintained in the chrome process in general?

Note that the count needs to be decremented when the popup window is closed, which is what makes for part of the fun.

Comment 1

[(no longer active)]

It seems like this needs to be stored in the parent...

Comment 2

[Johnny Stenback (:jst)]

Yeah, this should live in the parent, and IMO it is not critical for this counter to be precise, i.e. if there's a chance for a race between processes or what not, that's ok for this one.

Comment 3

[Gabor Krizsanits (INACTIVE)]

(In reply to Boris Zbarsky [:bz] (still a bit busy) from comment #0)
> And in particular, with window.open() calls that involve opening the window
> in a new process.
> 
> Which process's open popup spam count should the window count against?  Or
> both?  Or should this count be maintained in the chrome process in general?
> 
> Note that the count needs to be decremented when the popup window is closed,
> which is what makes for part of the fun.

I'm a bit confused about what is the scenario we're worrying about here, window.open
should always open the new window in same process to avoid using a CPOW for the opener,
no?

Comment 4

[Boris Zbarsky [:bzbarsky]]

> window.open should always open the new window in same process to avoid using a CPOW for the opener

Not when "noopener" is used.  Right now we'd still do that same-process, but we want to move away from that.

Also, I recall mystor working on some stuff for opening stuff in a new process for webasm/games (again, without an opener link).  Not sure whether that's still planning to use window.open.

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Nope, the large allocation work isn't using window.open anymore. :)

Comment 6

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 8

[Jens Stutte [:jstutte]]

There has been some changes in bug 1588720, is this still a thing?

Comment 9

[Edgar Chen [:edgar]]

(In reply to Jens Stutte [:jstutte] from comment #8)

There has been some changes in bug 1588720, is this still a thing?

I think we can close this one given that now popup spam count works with multiple content processes and gOpenPopupSpamCount has been removed.