1306459 - Update new debugger frontend (9/29/2016)

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P1)

Description

[James Long (:jlongster)]

New commits: https://github.com/devtools-html/debugger.html/compare/7c393c99dd82e9b181dab64ff474ee6ca9dc1c3f...master

It looks like a lot, but there are a lot of merge commits in there. There is a new SplitBox implementation, codemirror documents (tabs keep their scroll position and other info), and other minor tweaks.

Sourcemaps and our custom code search implementation is still turned off. We will turn them on soon.

Comment 1

[James Long (:jlongster)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f36e5279454

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/cdbfde37e795
Update new debugger frontend bundle r=me

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cdbfde37e795

Comment 4

[Alison Shiue]

Talos has detected a Firefox performance regression from push cdbfde37e79590e4c188ba854ab0b1612402e338. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  5%  damp summary linux64 pgo e10s     225.99 -> 237.91
  5%  damp summary linux64 pgo          256.11 -> 268.04
  5%  damp summary osx-10-10 opt        311.23 -> 325.32
  4%  damp summary windows7-32 pgo      244.85 -> 255.8
  2%  damp summary linux64 opt e10s     280.21 -> 285.88

James, since the damp changed in bug 1302862, could you please help us to judge if these regressions are expected, thank you.

Comment 5

[Alison Shiue]

Here is the perfherder alert: https://treeherder.mozilla.org/perf.html#/alerts?id=3501

Comment 6

[James Long (:jlongster)]

Alison, I'm pretty sure that the expected damp regression from bug 1302862 didn't actually happen until this bug because this bug actually updated the API to return a promise for the panel to block on. Before this bug it wasn't affected because it didn't get a promise to block on. So I think it can be ignored.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for the insight :jlongster :)