1306778 - Remove DOM/tv and related code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Michelangelo De Simone [Offline] [:mds]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea72f0a950c4

Comment 2

[Michelangelo De Simone [Offline] [:mds]]

Attachment: Bug 1306778 - Remove DOM/tv and related code.

Review commit: https://reviewboard.mozilla.org/r/84666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/84666/

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 8799521 [details]
Bug 1306778 - Remove DOM/tv and related code.

https://reviewboard.mozilla.org/r/84666/#review83290

Comment 4

[Carsten Book [:Tomcat]]

Michelangelo, in the try run is a android bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=28909127&repo=try - is this related to this code changes ?

Comment 5

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8799521 [details]
Bug 1306778 - Remove DOM/tv and related code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/84666/diff/1-2/

Comment 6

[Michelangelo De Simone [Offline] [:mds]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0144eafdc159

Comment 7

[Michelangelo De Simone [Offline] [:mds]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab224bd08d7d

Comment 8

[Michelangelo De Simone [Offline] [:mds]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=451454ea234a

Comment 9

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8799521 [details]
Bug 1306778 - Remove DOM/tv and related code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/84666/diff/2-3/

Comment 10

[Michelangelo De Simone [Offline] [:mds]]

(In reply to Carsten Book [:Tomcat] from comment #4)

> Michelangelo, in the try run is a android bustage like
> https://treeherder.mozilla.org/logviewer.html#?job_id=28909127&repo=try - is
> this related to this code changes ?

Yes, my fault. Apologies. It should be ok now; running a new try job to be sure.

Comment 11

[Michelangelo De Simone [Offline] [:mds]]

On IRC :bholley has suggested that the bustage on Android (see: https://mzl.la/2etdlRa) may be due to bug 946906.
An identical bustage is also affecting bug 1309719.

It seems due to some XRay/Expando header (js/xpconnect/wrappers/XrayWrapper.h ???) not being included correctly and/or at the right time.

:bohlley has also added: "the problem is presumably that http://searchfox.org/mozilla-central/source/dom/bindings/Codegen.py#13647 and http://searchfox.org/mozilla-central/source/dom/bindings/Codegen.py#40 are not always generated under the same conditions"

Probably :bz has some insight on this.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Is that try push on top of the fix for bug 1309239 or not?  Without that fix, you can end up with bustage as unified boundaries shift, for sure.

Comment 13

[Michelangelo De Simone [Offline] [:mds]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ed0967556ee

Comment 14

[Michelangelo De Simone [Offline] [:mds]]

Comment on attachment 8799521 [details]
Bug 1306778 - Remove DOM/tv and related code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/84666/diff/3-4/

Comment 15

[Michelangelo De Simone [Offline] [:mds]]

(In reply to Boris Zbarsky [:bz] (still a bit busy) from comment #12)

> Is that try push on top of the fix for bug 1309239 or not?  Without that
> fix, you can end up with bustage as unified boundaries shift, for sure.

Looks good now, thanks!

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a71215ad8ab8
Remove DOM/tv and related code. r=jst

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a71215ad8ab8

Comment 18

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/8166f30a47b0f4cf32f63ad7d875d638ae2305cc
Update package-manifest after file removal in bug 1306778 and bug 1261019. rs=bustage-fix

Comment 19

[Chris Mills [:cmills]]

Adding ddn, just to check the docs for this.

Comment 20

[Chris Mills [:cmills]]

We never documented any of this stuff either.

I've added a note to the Fx52 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/52#Changes_and_removals_3

Let me know if you think anything else needs fixing. Thanks!