1309354 - Firefox adds http:// and / when browser.urlbar.trimURLs = false and keyword.enabled=false

Status: NEW

(Firefox :: Address Bar, defect, P3)

Description

[avada]

Hi!

This is yet another variant of the urlbar adding this. In this case the searchstring in the urlbar is get this appended when you cycle through everything by pressing up/down arrows, then getting back to the location bar.
As such it's most noticeable, when you don't have any results and have one-off searches disabled.
Also it's necessary for autofill to be not active. (To be disabled, or have nothing to fill)

Comment 1

[Marco Bonardo [:mak]]

could you please better specify steps to reproduce as a list of steps to follow?

Comment 2

[avada]

I think I told everything. Anyways, here's a second attempt.
1. Set browser.urlbar.trimURLs = false and browser.urlbar.oneOffSearches = false
2. Add alphanumeric nonsense without spaces to the urlbar, which don't have any results
3. Press the down arrow
4. Note that the text now has the stuff appended.

Technically it happens when you have one off searches on, but it's less annoying, because you get the searchterm back when you press down again. and you have to go through all the stuff on the one off searches' bar. 

Curiously, you don't get the search term back if press upwards. Which I guess is a bug within this bug.

(Hmmm... Just noticed that keyword searches don't work at all to me. Clicking, or pressing enter on them has the same result as if I pressed enter in the urlbar.)

Comment 3

[Drew Willcoxon :adw]

I can't reproduce this on the latest Nightly.  Maybe one of the bugs Marco's been working on recently fixed this, or I don't understand what the bug is.  Doing the STR in comment 2 doesn't append anything.  There's nothing appended to the text shown in the text box, there's nothing appended when I press Return to do a search.  When I copy-paste, http:// and / are added.  Is that the bug?

Comment 4

[avada]

(In reply to Drew Willcoxon :adw from comment #3)
> I can't reproduce this on the latest Nightly.  Maybe one of the bugs Marco's
> been working on recently fixed this, or I don't understand what the bug is. 
> Doing the STR in comment 2 doesn't append anything.  There's nothing
> appended to the text shown in the text box, there's nothing appended when I
It still happens on latest nightly.

> press Return to do a search.  When I copy-paste, http:// and / are added. 
> Is that the bug?

That's bug 1254415.

Comment 5

[avada]

(In reply to Drew Willcoxon :adw from comment #3)
> I can't reproduce this on the latest Nightly. 

I just tried it with a new profile. It looks like you also need have keyword.enabled=false too. 

Also - I just figured this out - setting keyword.enabled=false totally breaks the one-off searches feature.

Comment 6

[Drew Willcoxon :adw]

All right, I can reproduce with keyword.enabled=false.  Thanks.

Comment 7

[avada]

Also this came with the new urlbar, it's not reproducible with the old one which didn't have the "visit:" item.

Comment 8

[quasicomputational]

I think this has been fixed with 83 - at least, I've stopped noticing it happen and I can't seem to make it happen with the new search suggestion code.

Comment 9

[Drew Willcoxon :adw]

I can still reproduce it on the latest Nightly. As avada says in comment 2, it's easier to see if you remove all the one-off searches. There's no browser.urlbar.oneOffSearches pref anymore, but you can uncheck all the engines in about:preferences. I think what happens is, once you press the down arrow key, the visit result gets selected, and it's impossible to unselect it.