1310217 - teach the Balrog Agent how to look for and enact changes to Releases, Permissions, and Required Signoffs

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P1)

Comment 1

[[e-mail] (:bhearsum)]

Varun is planning to look at this.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/eda43c6605f71ef5f23d9bca5c670f3f2d44f8c8
bug 1310217: Make Agent Aware of Release and Permissions Scheduled Changes (#214). r=bhearsum

Comment 3

[[e-mail] (:bhearsum)]

I discovered a bug this morning - if there are multiple pending scheduled changes for one endpoint, only the first one will be enacted. I think this is because "endpoint" gets re-used for each iteration of the inner loop of run_agent, and we end up making requests like:
balrogadmin_1  | [pid: 13|app: 0|req: 7/7] 172.17.0.6 () {42 vars in 733 bytes} [Tue Jan 31 18:22:42 2017] POST /api/scheduled_changes//scheduled_changes/permissions/5/enact/7/enact => generated 233 bytes in 8 msecs (HTTP/1.1 404) 4 headers in 128 bytes (1 switches on core 0)


Can you fix that, Varun?

Comment 4

[[e-mail] (:bhearsum)]

The first part of this is in production - we still need to support Required Signoffs, which is blocked on having API methods for that.

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum (:bhearsum) from comment #3)
> I discovered a bug this morning - if there are multiple pending scheduled
> changes for one endpoint, only the first one will be enacted. I think this
> is because "endpoint" gets re-used for each iteration of the inner loop of
> run_agent, and we end up making requests like:
> balrogadmin_1  | [pid: 13|app: 0|req: 7/7] 172.17.0.6 () {42 vars in 733
> bytes} [Tue Jan 31 18:22:42 2017] POST
> /api/scheduled_changes//scheduled_changes/permissions/5/enact/7/enact =>
> generated 233 bytes in 8 msecs (HTTP/1.1 404) 4 headers in 128 bytes (1
> switches on core 0)
> 
> 
> Can you fix that, Varun?

This was fixed awhile ago.

Comment 6

[[e-mail] (:bhearsum)]

Varun, will you be able to look at the Required Signoffs part of this soon? https://github.com/mozilla/balrog/pull/218 should have the necessary information, and I expect it to merge to master next week.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/ebbaffe5d47bf7a52735898cf460da751119a842
Bug 1310217 - teach the Balrog Agent how to look for and enact Required Signoffs (#261). r=bhearsum

Comment 8

[[e-mail] (:bhearsum)]

Thanks for this Varun!