1310188 - enable scheduled changes for Releases and Permissions

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[[e-mail] (:bhearsum)]

Multiple Signoff is going to be implemented through the recently developed Scheduled Changes system. We will require Signoff for Releases and Permissions, so we must enable Scheduled Changes for them. It doesn't make sense for either to have Telemetry-based conditions, so we must disable that for them.

Comment 1

[[e-mail] (:bhearsum)]

This bug should include the necessary database and web API work.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: use custom column types for JSON columns

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/22f6cace1d626b5b48afe83a63901baf5cfc4e13
bug 1310188: Use custom column types for JSON columns (#184). r=nthomas,jlorenzo

Comment 4

[[e-mail] (:bhearsum)]

Attachment: enabled scheduled changes for Releases and Permissions

With Johan gone for so long, I'll stick with just you for this one, if that's OK. More details in PR, as usual.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8820384 [details] [review]
enabled scheduled changes for Releases and Permissions

See PR for comments.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 8820384 [details] [review]
enabled scheduled changes for Releases and Permissions

Nick, I'm reflagging for a final sanity check because of the amount of change made to the Forms after your feedback, and the bug uncovered in Releases.delete, per https://github.com/mozilla/balrog/pull/196#issuecomment-270225339.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/c6b8b919362ace0d819018cd602bafb5d9bfbdd5
bug 1310188: Enable Scheduled Changes for Releases and Permissions (#196). r=nthomas

Comment 8

[[e-mail] (:bhearsum)]

In production!