1310210 - create Required Signoffs tables

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P1)

Description

[[e-mail] (:bhearsum)]

Required Roles will be two data tables that store the type and number of Signoffs required for different types of changes. We will need two tables:
1) product_channel_required_signoffs, which will track Required Signoffs for different product+channel combinations. It will need a primary key of product, channel, and role as well as a signoffs_required column which will track the number of signoffs needed from the given role for the given product_channel
2) permissions_required_signoffs, which will track Required Signoffs needed for changes to Permissions. It will need a primary key of product and role as well as a signoffs_required column.

Both tables will require Signoff when certain changes are made to them. That is to say, if changes to Firefox release channel Rules requires 2 relman Signoffs, changing the number of Required Signoffs for Firefox release channel rules will require 2 relman Signoff. This means that Scheduled Changes must be enabled for both of these tables.

Comment 1

[[e-mail] (:bhearsum)]

When new Required Signoffs are added, we must ensure the signoffs_required does not exceed the number of users who hold the given Role. Eg: if we required 10 Signoffs from the “releng” Role, but only 5 Users held that Role, making that change (or even removing that Signoff requirement) would be impossible.

Comment 2

[[e-mail] (:bhearsum)]

I'll be looking at this in the near future.

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum (:bhearsum) from comment #1)
> When new Required Signoffs are added, we must ensure the signoffs_required
> does not exceed the number of users who hold the given Role. Eg: if we
> required 10 Signoffs from the “releng” Role, but only 5 Users held that
> Role, making that change (or even removing that Signoff requirement) would
> be impossible.

Similarly, we should probably look at Required Signoffs when removing a Role from a User to make sure we don't get into situation where we can't Signoff.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: implement required signoffs tables + checks

Details in PR.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/8990958d7ca1c035f4b07f2a3089565584fed830
bug 1310210: Implement Required Signoffs tables (#208). r=nthomas,jlorenzo

Comment 9

[[e-mail] (:bhearsum)]

This is in production now.