1310564 - RDM device editing dialog does not scroll with the viewport

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P3)

Description

[Sebastian Zartner [:sebo]]

Attachment: Screenshot showing the bug

When a device with larger dimensions than the browser viewport is selected, the overlay only covers the viewport.
Instead, it should be fixed positioned, so it scrolls together with the viewport and the devices dialog stays centered.

Note that this requires special handling when the devices dialog doesn't fit into the viewport, e.g. displaying scrollbars for it.

Sebastian

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Thanks for filing!  Yes, this is another variation of problems with the overlay.  I don't think it should block enabling, but let's track this along with the other overlay issues.

Comment 2

[Martin Balfanz [:mbalfanz]]

With the recent redesign, this problem does no longer exist. Feel free to reopen the bug if you can still reproduce it.

Comment 3

[Sebastian Zartner [:sebo]]

Yep, it's fixed in the current Nightlies by blocking the scrolling. Thanks for checking!

Unfortunate side effect: If the browser window is smaller than the device editing dialog, there is no scrollbar within the dialog, so parts are hidden. But I saw that's covered in bug 1498492.

Sebastian