1314914 - Builds on windows broken: "AttributeError: 'ReadOnlyNamespace' object has no attribute 'exists'"

Status: RESOLVED DUPLICATE of bug 1314894

(Firefox Build System :: General, defect)

Description

[Tomislav Jovanovic :zombie]

+++ This bug was initially created as a clone of Bug #1313306 +++

Bug 1313306 broke artifact builds on Windows.

> 0:20.38 checking for NSIS version... 3.0b3
> 0:20.38 checking for 32-bit NSIS... yes
> 0:20.38 checking for autoconf... d:/mozilla-build/msys/local/bin/autoconf-2.13
> 0:22.65 configure: error: can not find sources in . or ..
> 0:22.67 DEBUG: This file contains any messages produced by compilers while
> 0:22.67 DEBUG: running configure, to aid debugging if configure makes a mistake.
> 0:22.67 DEBUG:
> 0:22.67 DEBUG: configure: error: can not find sources in . or ..
> 0:22.67 ERROR: old-configure failed
> 0:22.72 *** Fix above errors and then restart with\
> 0:22.72                "d:/mozilla-build/mozmake/mozmake.EXE -f client.mk build"
> 0:22.73 client.mk:375: recipe for target 'configure' failed
> 0:22.73 mozmake.EXE: *** [configure] Error 1
>2


Can we have Try jobs that test artifact builds?  Loosing an hour tracking down these things every few days kinda sucks, especially when m-c merges take a couple of days.

Comment 1

[Mike Hommey [:glandium]]

You'll have to be more specific about your environment, because I can't reproduce (which suggests it wouldn't have failed on automation either ; plus, I don't see a reason this would be artifacts build specific)

Comment 2

[Tomislav Jovanovic :zombie]

I'm not sure what else I need to specify about my environment?  I'm on Windows 7, with Visual Studio 2015, on the latest m-c.  I've successfully built Firefox (almost exclusively artifact builds) daily in the last few months.

I presumed it was limited to artifact builds (like last time), but it is not.  Also, while tracking this down, I had to regularly delete my obj dir to reliably reproduce it, as otherwise some cached file probably skipped the buggy code.

I tracked the original error above to double `@imports('os')` in old.configure from this commit:
https://reviewboard.mozilla.org/r/88850/diff/7#3

Once I remove that though, I get the fallowing error:

> 0:19.54 checking for NSIS version... 3.0b3
> 0:19.54 checking for 32-bit NSIS... yes
> 0:19.59 checking for autoconf... Traceback (most recent call last):
> 0:19.59   File "d:/moz-src/firefox/configure.py", line 107, in <module>
> 0:19.59     sys.exit(main(sys.argv))
> 0:19.60   File "d:/moz-src/firefox/configure.py", line 26, in main
> 0:19.60     sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
> 0:19.60   File "d:\moz-src\firefox\python\mozbuild\mozbuild\configure\__init__.py", line 359, in run
> 0:19.61     func(*args)
> 0:19.61   File "d:\moz-src\firefox\python\mozbuild\mozbuild\configure\__init__.py", line 402, in _value_for
> 0:19.61     return self._value_for_depends(obj, need_help_dependency)
> 0:19.62   File "d:\moz-src\firefox\python\mozbuild\mozbuild\util.py", line 925, in method_call
> 0:19.62     cache[args] = self.func(instance, *args)
> 0:19.62   File "d:\moz-src\firefox\python\mozbuild\mozbuild\configure\__init__.py", line 412, in _value_for_depends
> 0:19.62     return obj.result
> 0:19.63   File "d:\moz-src\firefox\python\mozbuild\mozbuild\util.py", line 943, in __get__
> 0:19.63     setattr(instance, name, self.func(instance))
> 0:19.63   File "d:\moz-src\firefox\python\mozbuild\mozbuild\configure\__init__.py", line 90, in result
> 0:19.64     return self.func(*resolved_args)
> 0:19.64   File "d:\moz-src\firefox\python\mozbuild\mozbuild\configure\__init__.py", line 924, in wrapped
> 0:19.65     return new_func(*args, **kwargs)
> 0:19.65   File "d:\moz-src\firefox\python\mozbuild\mozbuild\configure\__init__.py", line 660, in wrapper
> 0:19.65     ret = template(*args, **kwargs)
> 0:19.66   File "d:/moz-src/firefox/build/moz.configure/checks.configure", line 53, in wrapped
> 0:19.66     ret = func(*args, **kwargs)
> 0:19.66   File "d:\moz-src\firefox\python\mozbuild\mozbuild\configure\__init__.py", line 924, in wrapped
> 0:19.66     return new_func(*args, **kwargs)
> 0:19.67   File "d:/moz-src/firefox/build/moz.configure/old.configure", line 54, in autoconf
> 0:19.67     if not os.path.exists(autoconf):
> 0:19.67 AttributeError: 'ReadOnlyNamespace' object has no attribute 'exists'
> 0:19.67 *** Fix above errors and then restart with\
> 0:19.68                "d:/mozilla-build/mozmake/mozmake.EXE -f client.mk build"
> 0:19.69 client.mk:375: recipe for target 'configure' failed
> 0:19.69 mozmake.EXE: *** [configure] Error 1
>2

which I haven't been able to figure out further.