1315615 - Fix no-unused-vars issues in the Pocket extension

Status: RESOLVED FIXED

(Firefox :: Pocket, defect)

Description

[Mark Banner (:standard8)]

There's a few bits of dead code in the Pocket extension that I'd like to clean up as part of the ongoing no-unused-vars code.

To test this, I added the following to browser/.eslintrc.js and did `./mach eslint browser/extensions/pocket`:

  "rules": {
    "no-unused-vars": ["error", {
      "vars": "local",
      "varsIgnorePattern": "^Cc|Ci|Cu|Cr|EXPORTED_SYMBOLS",
      "args": "none",
    }]
  }

We'll be enabling the rule for all of browser/ in bug 1312407.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1315615 - Fix no-unused-vars issues in the Pocket extension.

Review commit: https://reviewboard.mozilla.org/r/91006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91006/

Comment 2

[Mark Banner (:standard8)]

Shane/Mike, how do we ensure these changes get back into the Pocket repo (not sure if there's other changes that have landed as well).

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8808083 [details]
Bug 1315615 - Fix no-unused-vars issues in the Pocket extension.

https://reviewboard.mozilla.org/r/91006/#review90808

Comment 4

[Mike Kaply [:mkaply]]

I'll get a pull request together for them.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd11584b7ab0
Fix no-unused-vars issues in the Pocket extension. r=jaws

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fd11584b7ab0

Comment 7

[:Gijs (he/him)]

(In reply to Mike Kaply [:mkaply] from comment #4)
> I'll get a pull request together for them.

Looks like this is https://github.com/mozilla-partners/pocket/pull/11 , but there was no traction? Can we just merge this?

Comment 8

[Shane Caraveo (:mixedpuppy)]

Yes, merge it