Closed Bug 1315615 Opened 4 years ago Closed 4 years ago

Fix no-unused-vars issues in the Pocket extension

Categories

(Firefox :: Pocket, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

There's a few bits of dead code in the Pocket extension that I'd like to clean up as part of the ongoing no-unused-vars code.

To test this, I added the following to browser/.eslintrc.js and did `./mach eslint browser/extensions/pocket`:

  "rules": {
    "no-unused-vars": ["error", {
      "vars": "local",
      "varsIgnorePattern": "^Cc|Ci|Cu|Cr|EXPORTED_SYMBOLS",
      "args": "none",
    }]
  }

We'll be enabling the rule for all of browser/ in bug 1312407.
Shane/Mike, how do we ensure these changes get back into the Pocket repo (not sure if there's other changes that have landed as well).
Flags: needinfo?(mozilla)
Flags: needinfo?(mixedpuppy)
Blocks: 1315617
Comment on attachment 8808083 [details]
Bug 1315615 - Fix no-unused-vars issues in the Pocket extension.

https://reviewboard.mozilla.org/r/91006/#review90808
Attachment #8808083 - Flags: review?(jaws) → review+
I'll get a pull request together for them.
Flags: needinfo?(mozilla)
Flags: needinfo?(mixedpuppy)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd11584b7ab0
Fix no-unused-vars issues in the Pocket extension. r=jaws
https://hg.mozilla.org/mozilla-central/rev/fd11584b7ab0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
(In reply to Mike Kaply [:mkaply] from comment #4)
> I'll get a pull request together for them.

Looks like this is https://github.com/mozilla-partners/pocket/pull/11 , but there was no traction? Can we just merge this?
Flags: needinfo?(mozilla)
Yes, merge it
Flags: needinfo?(mozilla)
You need to log in before you can comment on or make changes to this bug.