Closed Bug 1316211 Opened 3 years ago Closed 2 years ago

Remove unused code in MediaDecoderReader

Categories

(Core :: Audio/Video: Playback, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jya, Assigned: jwwang)

References

Details

Attachments

(16 files)

59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
59 bytes, text/x-review-board-request
gerald
: review+
Details
Now that there are no more legacy MediaDecoderReader, we can remove unused code related to the use of now removed synchronous decoders.
Actually there are still some.

DirectXReader which can be removed in 53
And the AndroidMediaReader (bug 1316462)
Depends on: 1316462
Depends on: 1370192
Depends on: 1379190
Attachment #8888131 - Flags: review?(gsquelart)
Attachment #8888132 - Flags: review?(gsquelart)
Attachment #8888133 - Flags: review?(gsquelart)
Attachment #8888134 - Flags: review?(gsquelart)
Attachment #8888135 - Flags: review?(gsquelart)
Attachment #8888136 - Flags: review?(gsquelart)
Attachment #8888137 - Flags: review?(gsquelart)
Attachment #8888138 - Flags: review?(gsquelart)
Attachment #8888139 - Flags: review?(gsquelart)
Attachment #8888140 - Flags: review?(gsquelart)
Attachment #8888141 - Flags: review?(gsquelart)
Attachment #8888142 - Flags: review?(gsquelart)
Attachment #8888143 - Flags: review?(gsquelart)
Attachment #8888144 - Flags: review?(gsquelart)
Attachment #8888145 - Flags: review?(gsquelart)
Attachment #8888146 - Flags: review?(gsquelart)
Assignee: jyavenard → jwwang
Comment on attachment 8888131 [details]
Bug 1316211. P1 - make some functions pure virtual for they will be overridden by MFR.

https://reviewboard.mozilla.org/r/159028/#review164814
Attachment #8888131 - Flags: review?(gsquelart) → review+
Comment on attachment 8888134 [details]
Bug 1316211. P4 - remove CheckSlowDecoding() and friends since IsAsync() now always returns true.

https://reviewboard.mozilla.org/r/159034/#review164820
Attachment #8888134 - Flags: review?(gsquelart) → review+
Comment on attachment 8888135 [details]
Bug 1316211. P5 - remove IsAsync() and its callers.

https://reviewboard.mozilla.org/r/159036/#review164822
Attachment #8888135 - Flags: review?(gsquelart) → review+
Comment on attachment 8888136 [details]
Bug 1316211. P6 - move some members from MDR into MFR.

https://reviewboard.mozilla.org/r/159038/#review164824

::: commit-message-14af0:1
(Diff revision 1)
> +Bug 1316211. P6 - move some members from MDR into MFR.

Only one member moved, so you can just say "move mInfo from MDR to MFR" ;-)
Attachment #8888136 - Flags: review?(gsquelart) → review+
Comment on attachment 8888137 [details]
Bug 1316211. P7 - remove mAudioQueue and mVideoQueue for we never push data into the queues.

https://reviewboard.mozilla.org/r/159040/#review164826
Attachment #8888137 - Flags: review?(gsquelart) → review+
Comment on attachment 8888138 [details]
Bug 1316211. P8 - fix MDSM::SizeOf{Audio,Video}Queue which should count its own queues.

https://reviewboard.mozilla.org/r/159042/#review164830
Attachment #8888138 - Flags: review?(gsquelart) → review+
Comment on attachment 8888139 [details]
Bug 1316211. P9 - remove SizeOf{Audio,Video}QueueInBytes() that has no callers.

https://reviewboard.mozilla.org/r/159044/#review164832
Attachment #8888139 - Flags: review?(gsquelart) → review+
Comment on attachment 8888140 [details]
Bug 1316211. P10 - make SizeOf{Audio,Video}QueueInFrames() pure virtual which will be overridden by MFR.

https://reviewboard.mozilla.org/r/159046/#review164834
Attachment #8888140 - Flags: review?(gsquelart) → review+
Comment on attachment 8888141 [details]
Bug 1316211. P11 - remove empty functions.

https://reviewboard.mozilla.org/r/159048/#review164836
Attachment #8888141 - Flags: review?(gsquelart) → review+
Comment on attachment 8888142 [details]
Bug 1316211. P12 - remove some more unused members.

https://reviewboard.mozilla.org/r/159050/#review164838
Attachment #8888142 - Flags: review?(gsquelart) → review+
Comment on attachment 8888143 [details]
Bug 1316211. P13 - replace use of MediaDecoderReader with MediaFormatReader.

https://reviewboard.mozilla.org/r/159052/#review164840
Attachment #8888143 - Flags: review?(gsquelart) → review+
Comment on attachment 8888144 [details]
Bug 1316211. P14 - move members from MDR to MFR.

https://reviewboard.mozilla.org/r/159054/#review164844
Attachment #8888144 - Flags: review?(gsquelart) → review+
Comment on attachment 8888145 [details]
Bug 1316211. P15 - remove MDR from the base class of MFR.

https://reviewboard.mozilla.org/r/159056/#review164846
Attachment #8888145 - Flags: review?(gsquelart) → review+
Comment on attachment 8888146 [details]
Bug 1316211. P16 - remove MediaDecoderReader completely and fix includes.

https://reviewboard.mozilla.org/r/159058/#review164848

Yeah!
Attachment #8888146 - Flags: review?(gsquelart) → review+
Comment on attachment 8888136 [details]
Bug 1316211. P6 - move some members from MDR into MFR.

https://reviewboard.mozilla.org/r/159038/#review164824

> Only one member moved, so you can just say "move mInfo from MDR to MFR" ;-)

On second thought, don't worry about it, you may just ship it as-is.
Thanks for the reviews!!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/973097924ef0
P1 - make some functions pure virtual for they will be overridden by MFR. r=gerald
https://hg.mozilla.org/integration/autoland/rev/1bc3e813c0e2
P2 - remove dead code. r=gerald
https://hg.mozilla.org/integration/autoland/rev/8ffd2e8a12ad
P3 - remove unused members. r=gerald
https://hg.mozilla.org/integration/autoland/rev/1e93396b093c
P4 - remove CheckSlowDecoding() and friends since IsAsync() now always returns true. r=gerald
https://hg.mozilla.org/integration/autoland/rev/91d790b237c0
P5 - remove IsAsync() and its callers. r=gerald
https://hg.mozilla.org/integration/autoland/rev/a29ccfcca3b0
P6 - move some members from MDR into MFR. r=gerald
https://hg.mozilla.org/integration/autoland/rev/569f0d24bfda
P7 - remove mAudioQueue and mVideoQueue for we never push data into the queues. r=gerald
https://hg.mozilla.org/integration/autoland/rev/0bac6fca55b5
P8 - fix MDSM::SizeOf{Audio,Video}Queue which should count its own queues. r=gerald
https://hg.mozilla.org/integration/autoland/rev/3e10f80060f9
P9 - remove SizeOf{Audio,Video}QueueInBytes() that has no callers. r=gerald
https://hg.mozilla.org/integration/autoland/rev/670f1c2a2130
P10 - make SizeOf{Audio,Video}QueueInFrames() pure virtual which will be overridden by MFR. r=gerald
https://hg.mozilla.org/integration/autoland/rev/60909f8e1e75
P11 - remove empty functions. r=gerald
https://hg.mozilla.org/integration/autoland/rev/a56cdce8ca54
P12 - remove some more unused members. r=gerald
https://hg.mozilla.org/integration/autoland/rev/1a089f2a645b
P13 - replace use of MediaDecoderReader with MediaFormatReader. r=gerald
https://hg.mozilla.org/integration/autoland/rev/44cec0ee85fa
P14 - move members from MDR to MFR. r=gerald
https://hg.mozilla.org/integration/autoland/rev/e7032affc21d
P15 - remove MDR from the base class of MFR. r=gerald
https://hg.mozilla.org/integration/autoland/rev/29999b34e728
P16 - remove MediaDecoderReader completely and fix includes. r=gerald
Blocks: 1378295
You need to log in before you can comment on or make changes to this bug.