1316696 - Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

Now that rust 1.13 is stable drop flags are dead \o/ - this means that we can now implement Drop on #[repr(C)] types, meaning that we can hide the nsStringRepr details and directly allow using nsString<'static> in #[repr(C)] structs in place of C++'s `nsString`.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings

This is possible due to Rust 1.13 eliminating the Drop Flags.

I am not confident whether or not Rust 1.13 (which is only recently stable) is avaliable in infra yet. If it is not, this patch will have to be blocked on that.

MozReview-Commit-ID: AMwAUq82vMo

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Michael Layzell [:mystor] [:mrl] from comment #1)
> I am not confident whether or not Rust 1.13 (which is only recently stable)
> is avaliable in infra yet. If it is not, this patch will have to be blocked
> on that.

We not only need it to be in infra, but we also need to update configure to require Rust 1.13.

Comment 3

[Mike Hommey [:glandium]]

We can't require 1.13 on all platforms, it has ARM codegen issues.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

(In reply to Mike Hommey [:glandium] from comment #3)
> We can't require 1.13 on all platforms, it has ARM codegen issues.

This is a good point - we won't be able to land this patch until after a 1.13.1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b368ec57dc57
Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings, r=froydnj

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b368ec57dc57

Comment 7

[Nika Layzell [:nika] (ni? for response)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/f50ae3e4924d028b4d7488833999fd7012782727 because of bug  1320425, and rustc 1.13 not being required yet.

We can reland this when we are comfortable with requiring a minimum rustc=1.13 in order to build firefox.

Comment 8

[Carsten Book [:Tomcat]]

backout also from central
https://hg.mozilla.org/mozilla-central/rev/f50ae3e4924d

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e259fa04f68
Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings, r=froydnj

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e259fa04f68

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/56b122662f91
Eliminate ns{Fixed,}{C,}StringRepr from the rust bindings, r=froydnj for being the wrong commit backed out a=backout

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/f2bccdc9fe7e
Backed out changeset 4e259fa04f68 for asserts in DocAccessibleParent.cpp a=backout