Intermittent grid-fragmentation-dyn1-002.html == grid-fragmentation-002-ref.html | image comparison, max difference: 255, number of differing pixels: 9533

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aryx, Assigned: mats)

Tracking

({intermittent-failure})

unspecified
mozilla55
intermittent-failure
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox52 unaffected, firefox-esr52 unaffected, firefox53 fixed, firefox54 fixed, firefox55 fixed)

Details

(Whiteboard: [stockwell disabled])

Attachments

(2 attachments, 1 obsolete attachment)

5 failures in 715 pushes (0.007 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* autoland: 2
* mozilla-inbound: 1
* mozilla-central: 1
* graphics: 1

Platform breakdown:
* windows7-32-vm: 3
* linux64: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317149&startday=2016-11-14&endday=2016-11-20&tree=all
5 failures in 694 pushes (0.007 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 2
* autoland: 2
* mozilla-central: 1

Platform breakdown:
* windows7-32-vm: 4
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317149&startday=2016-11-28&endday=2016-12-04&tree=all
6 failures in 722 pushes (0.008 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 3
* autoland: 3

Platform breakdown:
* linux64: 3
* linux32: 2
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317149&startday=2017-01-09&endday=2017-01-15&tree=all
9 failures in 690 pushes (0.013 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 5
* autoland: 4

Platform breakdown:
* windows7-32-vm: 4
* linux32: 4
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317149&startday=2017-01-16&endday=2017-01-22&tree=all
28 failures in 833 pushes (0.034 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* mozilla-inbound: 12
* autoland: 12
* graphics: 3
* try: 1

Platform breakdown:
* linux64: 10
* linux32: 7
* android-4-3-armv7-api15: 6
* windows7-32-vm: 4
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317149&startday=2017-02-13&endday=2017-02-19&tree=all

Updated

2 years ago
See Also: → bug 1316257
There are several languishing bugs for intermittent failures in layout/reftests/css-grid/grid-fragmentation... tests. 

:jet - Can you find someone to have a look, in hopes of making these tests more reliable?
Flags: needinfo?(bugs)
14 failures in 812 pushes (0.017 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* mozilla-inbound: 7
* mozilla-central: 3
* autoland: 3
* graphics: 1

Platform breakdown:
* linux64: 7
* linux32: 5
* windows7-32-vm: 1
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317149&startday=2017-02-20&endday=2017-02-26&tree=all
29 failures in 783 pushes (0.037 failures/push) were associated with this bug in the last 7 days. 

This is the #47 most frequent failure this week. 
Repository breakdown:
* mozilla-inbound: 10
* autoland: 10
* try: 7
* mozilla-central: 2

Platform breakdown:
* linux64: 11
* linux32: 9
* windows7-32-vm: 5
* windows8-64: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317149&startday=2017-02-27&endday=2017-03-05&tree=all
27 failures in 790 pushes (0.034 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 11
* autoland: 7
* mozilla-central: 5
* graphics: 2
* try: 1
* mozilla-aurora: 1

Platform breakdown:
* android-4-3-armv7-api15: 9
* linux64: 7
* windows8-64: 6
* linux32: 4
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317149&startday=2017-03-06&endday=2017-03-12&tree=all
and the culprit is bug 1343078:
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=android%20debug%20reftest-26&tochange=9e21c2dc1b0da1c450462a3f5458d6c6d547fd3a&fromchange=1ecb6fcbdb2ad7cff1d4c3749973947d4c113282&selectedJob=83857429

the failure rate posted here is deceptive as we run once every 5 pushes, so that leaves us with a much higher failure rate at least on autoland and inbound.

:bz, I see you are the patch author here, can you take a look at this bug?
Blocks: 1343078
Flags: needinfo?(bzbarsky)
Whiteboard: [stockwell needswork]
So...  The link in comment 10 shows this happening on aurora at least once.  Bug 1343078 is not on aurora.

Looking at the actual test failure, the third test from the end has the green bit in the second and third column in the test, whereas the reference has it all it to be in the first column.  See <https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/Y_QkuZ7ESSaIKab0c1C-oA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1> for example.

If I load layout/reftests/css-grid/grid-fragmentation-dyn1-002.html or layout/reftests/css-grid/grid-fragmentation-002.html or layout/reftests/css-grid/grid-fragmentation-002-ref.html directly in the browser, in a March 15 nightly, they all render with the green bit in the second and third column.  So the "weird" rendering here is the _reference_, not the test, iirc.

If I load those files with a March 1 build, way before bug 1343078 landed, I get the same behavior: they all match the test, as shown in the reftest analyzer logs, but not the reference...

Mats, what is the expected rendering of that third-from-the-end test?
Flags: needinfo?(mats)
OK, in both current tip and a March 1 nightly I can cause layout/reftests/css-grid/grid-fragmentation-002.html or layout/reftests/css-grid/grid-fragmentation-002-ref.html to have the "all the green in the first column" rendering on that third from last test by inserting

  <script>document.body.offsetWidth;</script>

somewhere after that test.  If I put that flush _before_ the third-from-last test, I get the "green in columns 2 and 3" rendering.  If I put it anywhere after that test. I get the "first column only" rendering.  This is rather bizarre.

On the other hand, evaluating document.body.offsetWidth _after_ the page is done loading does not seem to change the rendering....
Created attachment 8847751 [details]
Somewhat simplified testcase

This is based on layout/reftests/css-grid/grid-fragmentation-002-ref.html but with various stuff ripped out.  The layout depends on whether the layout flush happens...
Flags: needinfo?(bzbarsky)
(Assignee)

Comment 14

2 years ago
The expected rendering is the one shown for the -ref in this case.

Fwiw, I think our support for fragmentating abs.pos. is somewhat flaky
in general (not just in Grid), especially with dynamic DOM changes like
in this test, so I don't think this is a bug in the Grid layout code
per se.

Bug 1264056 is also tracking failures in the same underlying test
(grid-fragmentation-002.html).

grid-fragmentation-dyn1-002.html etc is just loading that test, doing
a few DOM mutations that results in the same DOM tree so it should
have the same rendering afterwards.
http://searchfox.org/mozilla-central/source/layout/reftests/css-grid/grid-fragmentation-dyn1-002.html

The failures in bug 1264056 looks exactly the same, so perhaps we should
just comment out that part of the test for now (the 3rd grid from the end)
and deal with it in a follow-up bug?
Flags: needinfo?(mats)
(Assignee)

Comment 15

2 years ago
Created attachment 8847756 [details] [diff] [review]
comment out the bit that fails
Assignee: nobody → mats
> The expected rendering is the one shown for the -ref in this case.

Well, we only get that rendering if we happen to flush at just the right time.  :(

> The failures in bug 1264056 looks exactly the same

Indeed.

I'm still a little confused by comment 10, given that the failures in this bug way predate bug 1343078.  ;)
No longer blocks: 1343078
Flags: needinfo?(bugs)
(Assignee)

Comment 18

2 years ago
I filed bug 1347692 about it.  It also occurs with display:block instead of grid, fwiw.
(Assignee)

Comment 19

2 years ago
Created attachment 8847770 [details] [diff] [review]
comment out the bit that fails
Attachment #8847756 - Attachment is obsolete: true
(Assignee)

Comment 20

2 years ago
Yeah, that fixed it, see Android R26 retriggers here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f4217b15994143c42a4c339c759268d372528e5
Keywords: checkin-needed

Comment 21

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d27b3d263111
Comment out a part of this test that causes to many intermittent failures. r=me
Keywords: checkin-needed

Comment 22

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d27b3d263111
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Updated

2 years ago
Blocks: 1264056
Whiteboard: [stockwell needswork] → [stockwell disabled]
status-firefox52: --- → unaffected
status-firefox53: --- → affected
status-firefox54: --- → affected
status-firefox-esr52: --- → unaffected

Comment 23

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/bc9241831e28
status-firefox54: affected → fixed
Flags: in-testsuite-

Comment 24

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/b29177eab579
status-firefox53: affected → fixed
9 failures in 777 pushes (0.012 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 6
* try: 2
* mozilla-central: 1

Platform breakdown:
* android-4-3-armv7-api15: 6
* windows7-32-vm: 1
* linux64: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1317149&startday=2017-03-13&endday=2017-03-19&tree=all
You need to log in before you can comment on or make changes to this bug.