131825 - downloadmanager.ent file name should be changed to downloadmanager.dtd (localization issue)

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Marek Wawoczny]

downloadmanager.ent file name should be changed to downloadmanager.dtd (localization issue). All l10n files are named as *.dtd or *.properties. *.ent extension won't be recognized by l10n utilities (like MozillaTranslator) so it should be changed to *.dtd

Mozilla/5.0 (Windows; U; Windows NT 5.0; pl-PL; rv:0.9.9+) Gecko/20020316

Comment 1

[Matthias Versen [:Matti]]

CC blake

Comment 2

[Marek Wawoczny]

Attachment: Patch to change downloadmanager.ent to downloadmanager.dtd

downloadmanager.ent file should be renamed to downloadmanager.dtd (after or
before) applying patch

Comment 3

[Stephen Walker]

*** Bug 138642 has been marked as a duplicate of this bug. ***

Comment 4

[Robert Kaiser]

*** Bug 139481 has been marked as a duplicate of this bug. ***

Comment 5

[Robert Kaiser]

moving severity=major from bug 139481, nominating for 1.0 - this is breaking
L10n for quite some people!

Comment 6

[Frank Tang]

reassign to [e-mail]. blaker- please do not introduce new file ext
.Thanks

Comment 7

[Samir Gehani]

Nav triage team: What is the impact if we ship without fixing this?  It appears
we shipped beta with this as well.

Comment 8

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 9

[Michele Carlson]

It would be nice to have this fixed so that it's one less thing to fix in our
localization process. Of course, this one like many others can be lived with. 

Comment 10

[rchen]

The impact is to the whole Mozilla localization community(like IBM, Sun...).

Netscape shipped beta with the bug because we were aware the problem and we
avoided it happen. At that time, it was also too late to get fixed for beta.

For now, I think we should fix it.  The fix is ready and the risk is low, but
the impact is big. 

Renominate nsbeta1.

Comment 11

[Samir Gehani]

Nav triage team: nsbeta1-  (Monday, June 24, 2002 is zarro boogs).  

Comment 12

[Mike Kaply [:mkaply]]

Can we at least fix this on the trunk since it has been rejected for 
everything else?

Comment 13

[Robert Kaiser]

man, can't someone r= and sr= this at least? blake, as the patch wasn't made by
you, could you do one of those?
We'd just need leaf to copy the file in the repository, and then additionally
cvs remove the .ent file after applying the patch.

Would be good to get this at least into 1.2alpha...

Comment 14

[Robert Kaiser]

just for the record, the review on the patch is r=[e-mail]

Comment 15

[Daniel Veditz [:dveditz]]

CC'ing leaf and granrose as this bug assumes someone will rename the file in the
repository (or more likely, copy revision history into the new file but don't
actually delete the old one from the attic).

Comment 16

[Daniel Veditz [:dveditz]]

Comment on attachment 75369 [details] [diff] [review]
Patch to change downloadmanager.ent to downloadmanager.dtd

sr=dveditz

Comment 17

[Daniel (Leaf) Nunes]

sorry for the delay. file copied. update references and cvs remove the old
location at your earliest convenience.

Comment 18

[Robert Kaiser]

timeless checked in the patch yesterday, so the builds all use the .dtd now, thanks!

Now for the last part, cvs removing the .ent file:

Removing downloadmanager.ent;
/cvsroot/mozilla/xpfe/components/download-manager/resources/locale/en-US/downloadmanager.ent,v
 <--  downloadmanager.ent
new revision: delete; previous revision: 1.6
done

Comment 19

[rchen]

Reopen it for the branch fix. Please check in to the branch. Thanks. 

Comment 20

[Robert Kaiser]

rchen:
additional a= needed for the branch checkin, or is your word enough? :)
If a= needed, please ask for it, I'll do the real checkin then if you want.

Comment 21

[rchen]

I think we can put in on hold because it can't go in 1.0.2 now. The branch may
also be frozen after 1.0.2. Thanks.  

Comment 22

[timeless]

resolutions deal with the trunk. if you need a bug fixed on a branch then please
use nomination keywords like everyone else.

this bug was fixed   2002-08-23 04:58:34.