1319513 - Disabled "Clear Downloads" text is not grayed on Linux

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Hussam Al-Tayeb]

Attachment: Notice the black 'clear downloads' text.

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20161122120752

Steps to reproduce:

When there are now downloads in history or after download history is cleared, the "Clear Downloads" button becomes non-clickable (correct behavior).
The "Clear Downloads" text however stays in black. It should be gray or something so signify 'disabled button'.
I am using 51 branch (beta).

Comment 1

[Loic]

Are you running the latest Beta build?
I'm not able to reproduce it with FF51 on Win 7: http://i.imgur.com/FfkRus9.jpg

Could you test Nightly too: https://nightly.mozilla.org/

Comment 2

[Hussam Al-Tayeb]

I tested https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/firefox-53.0a1.en-US.linux-x86_64.tar.bz2
This is the official nightly build. The issue exists there too.
But I suppose it is Linux specific. I am using gtk+ 3.22.4 for the record.

Comment 3

[Loic]

Karl, do you know if it's the known issue with Gtk?

Comment 4

[Karl Tomlinson (:karlt)]

Regressed between 2016-08-06/6b65dd49d4f045c0a9753ce60bdb4b7b4aaedcf8 and
2016-08-07/d42aacfe34af25e2f5110e2ca3d24a210eabeb33.

(In reply to Loic from comment #3)
> Karl, do you know if it's the known issue with Gtk?

No widget/gtk changes in that range, but it would be helpful to know which change triggered this.

Comment 5

[Loic]

Maybe this bug in the range:
Paolo Amadini — Bug 1001324 - The Downloads Panel footer should use the same style as the application menu. r=adw

Is it possible to continue the regression in the repo mozilla-inbound to confirm?
mozregression --good=6b65dd49d4f045c0a9753ce60bdb4b7b4aaedcf8 --bad=d42aacfe34af25e2f5110e2ca3d24a210eabeb33 --repo=mozilla-inbound

Comment 6

[Gerry Chang [:gchang]]

Hi :Paolo,
Can you help take a look at this bug?

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Loic from comment #5)
> Maybe this bug in the range:
> Paolo Amadini — Bug 1001324 - The Downloads Panel footer should use the same
> style as the application menu. r=adw
> 
> Is it possible to continue the regression in the repo mozilla-inbound to
> confirm?
> mozregression --good=6b65dd49d4f045c0a9753ce60bdb4b7b4aaedcf8
> --bad=d42aacfe34af25e2f5110e2ca3d24a210eabeb33 --repo=mozilla-inbound

Hussam, is it possible for you to do this?

Comment 8

[Hussam Al-Tayeb]

(In reply to Milan Sreckovic [:milan] from comment #7)
> (In reply to Loic from comment #5)
> > Maybe this bug in the range:
> > Paolo Amadini — Bug 1001324 - The Downloads Panel footer should use the same
> > style as the application menu. r=adw
> > 
> > Is it possible to continue the regression in the repo mozilla-inbound to
> > confirm?
> > mozregression --good=6b65dd49d4f045c0a9753ce60bdb4b7b4aaedcf8
> > --bad=d42aacfe34af25e2f5110e2ca3d24a210eabeb33 --repo=mozilla-inbound
> 
> Hussam, is it possible for you to do this?

I am looking up mozregression now. Is there a tarball I can package and install?
I a scared a bit of putting files in /usr outside my package manager.

Comment 9

[Hussam Al-Tayeb]

In the meantime, could the fix for bug 1282050 have caused this?

Comment 10

[Hani Yacoub, Desktop QA]

Using the mozregression tool I got to this regression window:

Last good revision: 115ec609a6bf1bbc3e06f7cd2caa99e53b51e5d1
First bad revision: a159faf4c29b835d89fa6bb002c4d54c12b4ab04
Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=115ec609a6bf1bbc3e06f7cd2caa99e53b51e5d1&tochange=a159faf4c29b835d89fa6bb002c4d54c12b4ab04

Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=940872

Comment 11

[Loic]

Ryan, can you check this regression after your bugfix in bug 940872.

Comment 12

[Gerry Chang [:gchang]]

Hi Florin,
Per comment #11, can you help find someone in your team to check if this is still existed?

Comment 13

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

(In reply to Gerry Chang [:gchang] from comment #12)
> Hi Florin,
> Per comment #11, can you help find someone in your team to check if this is
> still existed?

According to comment #10 from Hani, the issue itself was caused by the fix for bug 940872. This means that the problem still shows ever since the fix for bug 940872 landed back in August.

My guess is Loic is asking Ryan Koesters to check why his fix from bug 940872 caused this regression.

Comment 14

[Andrew Overholt [:overholt]]

May be Dao can provide the info that was requested of Ryan in comment 11?

Comment 15

[Dão Gottwald [:dao]]

Attachment: Bug 1319513 - Gray out the "Clear Downloads" item when disabled.

Review commit: https://reviewboard.mozilla.org/r/109522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109522/

Comment 16

[Marco Bonardo [:mak]]

Comment on attachment 8833271 [details]
Bug 1319513 - Gray out the "Clear Downloads" item when disabled.

https://reviewboard.mozilla.org/r/109522/#review110558

thank you

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/501dcb605fee
Gray out the "Clear Downloads" item when disabled. r=mak

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/501dcb605fee

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora/Beta approval on this when you get a chance.

Comment 20

[Dão Gottwald [:dao]]

Comment on attachment 8833271 [details]
Bug 1319513 - Gray out the "Clear Downloads" item when disabled.

Approval Request Comment
[Feature/Bug causing the regression]: bug 940872
[User impact if declined]: seem comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: adds trivial CSS rule
[String changes made/needed]: /

Comment 21

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8833271 [details]
Bug 1319513 - Gray out the "Clear Downloads" item when disabled.

Minor css fix, let's uplift it to aurora and beta. 
This should make it into the beta 5 build later this week.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7c487eb9d8be

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/045cc752a289

Comment 24

[Fahima Zulfath]

[bugverificationday-20170208]
OPERATING SYSTEM : Windows 10.0
BROWSER : Firefox Nightly 54.0
  The bug is verified working fine. Hence the bug is fixed.

Comment 25

[Andrei Vaida [:avaida]]

Flagging this for verification.

fahimazulfath.a, thank you for getting involved in Bug Verification Day, I'm glad to see that people care about our events and sacrifice their spare time to help us out! But I think you might've misunderstood this particular issue. The bug here, per Comment 0, is only affecting Linux. While it is helpful to test the fix on other platforms as well (to make sure it didn't introduce regressions somewhere else), the testing you conducted is not enough to justify the change of flag from fixed to verified. 

I'll go ahead and change it back to fixed until we've managed to corroborate additional regression testing on Linux (especially) and Mac. 

Meanwhile, I'd be more than happy to give you a few tips if you happen to be online on #qa and naturally, if you have the time and wish to learn more -- feel free to ping me on irc.

Comment 26

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox  53.0a1 (20161122030216) on Ubuntu 16.04 x64.
I can confirm this issue is fixed, I verified using Firefox 52.0b5, 53.0a2, 54.0a1 on Ubuntu 16.04 x64 and Mac OS X 10.11.

Comment 27

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/045cc752a289