1319900 - Crash in mozilla::MediaDecoder::UpdateReadyState

Status: RESOLVED DUPLICATE of bug 1333576

(Core :: Audio/Video: Playback, defect, P1)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-9cb76467-f3e0-4853-8f4e-603722161123.
=============================================================

Low volume crash that first appeared in the 11-22 Nightly, with 6 crashes for that Nightly on Windows. JW, could this be related to one of your recent changes?

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Crashes are UAFs in some cases, marking as sec bug

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

https://crash-stats.mozilla.com/signature/?product=Firefox&signature=mozilla%3A%3AMediaDecoder%3A%3AUpdateReadyState&date=%3E%3D2016-11-17T02%3A46%3A00.000Z&date=%3C2016-11-24T02%3A46%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_sort=-date&page=1#reports

There are reports from 50.x. I think the problem has been there for a long time but some recent changes make it more likely to happen.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Wonder if bug 1319001 is the same cause.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Bug 1319790 might be also related.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

jw - can you update your thoughts on this?  it's still occurring, and the assertion for bug 1319790 landed a couple of months back.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Somehow bug 1319790 didn't change MOZ_ASSERT to MOZ_DIAGNOSTIC_ASSERT for UpdateReadyState(). I will add a patch to do that and see if there will be new findings.

Comment 7

[Frederik Braun [:freddy] (OOO until August 18th)]

JW, you said you were going to do this a few days ago in comment 6. Will you still drive this?

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

(In reply to Frederik Braun [:freddyb] from comment #7)
> JW, you said you were going to do this a few days ago in comment 6. Will you
> still drive this?

It is done in bug 1332544.

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

This should be a dup of bug 1333576.