Closed Bug 1322371 Opened 3 years ago Closed 3 years ago

Add Edge bug tracker support to See Also field

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: dylan)

Details

Attachments

(1 file, 1 obsolete file)

(Similar to bug 1252782, for Chromium bug tracker.)


I can't add
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/9713176/
to the "See Also" field in bug 1315892.

This would be useful for linking to issues in other browser engines.



I get the error:

https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/9713176/ is not a valid URL to a bug. See Also URLs should point to one of:

    show_bug.cgi in a Bugzilla installation.
    A bug on launchpad.net.
    An issue on code.google.com.
    An issue on bugs.chromium.org.
    A bug on bugs.debian.org.
    An issue in a JIRA installation.
    A ticket in a Trac installation.
    A bug in a MantisBT installation.
    A bug on sourceforge.net.
    An issue/pull request on github.com.
    A question on support.mozilla.org.
    An Aha feature on aha.io.
    An issue on webcompat.com.
    A request on ServiceNow.
    A ticket on hellosplat.com.
Assignee: nobody → dylan
Component: General → Extensions: BMO
Attached patch 1322371_1.patch (obsolete) — Splinter Review
Attachment #8817243 - Flags: review?(dkl)
Comment on attachment 8817243 [details] [diff] [review]
1322371_1.patch

Review of attachment 8817243 [details] [diff] [review]:
-----------------------------------------------------------------

Need description added to the list of accepted See Also urls.

template/en/default/global/user-error.html.tmpl: 'bug_url_invalid'

dkl
Attachment #8817243 - Flags: review?(dkl) → review-
While we're at it, we might want to also add support for linking to Microsoft Edge "uservoice" pages, like this one:
  https://wpdev.uservoice.com/forums/257854/suggestions/17420707

(According to the first response on https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10152756/ , the developer.microsoft.com URLs like in comment 0 are only for bugs/defects, whereas https://wpdev.uservoice.com/forums/257854/ is for feature-requests. We'd probably like to be able to link out to both sorts of things from bugzilla.)
Attached patch 1322371_5.patchSplinter Review
Attachment #8817243 - Attachment is obsolete: true
Attachment #8844185 - Flags: review?(dkl)
Comment on attachment 8844185 [details] [diff] [review]
1322371_5.patch

Review of attachment 8844185 [details] [diff] [review]:
-----------------------------------------------------------------

Fix issue on commit. r=dkl

::: Bugzilla/BugUrl/Edge.pm
@@ +35,5 @@
> +
> +    $uri = $class->SUPER::_check_value($uri);
> +
> +    return $uri if  $uri->path =~ m{^/en-us/microsoft-edge/platform/issues/\d+/$};
> +    return $uri if $uri->path =~ m{^/forums/257854(?:-[^/]+)?/suggestions/\d+(?:-[^/]+)?};

Remove hard coded issue id and replace with \d+ or similar.
Attachment #8844185 - Flags: review?(dkl) → review+
(In reply to David Lawrence [:dkl] from comment #5)

> Remove hard coded issue id and replace with \d+ or similar.
Added that as an after thought. Woops.
To git@github.com:mozilla-bteam/bmo.git
   b72174d..91248ef  master -> master
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Summary: can't add a developer.microsoft.com Edge issue to "See Also" → Add Edge bug tracker support to See Also field
Component: Extensions: BMO → Extensions
You need to log in before you can comment on or make changes to this bug.