Closed
Bug 1322799
Opened 6 years ago
Closed 6 years ago
Remove AccurateSeekTask
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: kaku, Assigned: kaku)
References
Details
Attachments
(12 files)
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
jwwang
:
review+
|
Details |
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 23•6 years ago
|
||
Try looks bad... https://treeherder.mozilla.org/#/jobs?repo=try&revision=15a854612c2611f34499883276853d10753cdf6d https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a9b20c589d20ae3d6f261b20fe1db53fbd97d59
Comment 24•6 years ago
|
||
mozreview-review |
Comment on attachment 8817763 [details] Bug 1322799 part 1 - un-encapsulating SeekTask; https://reviewboard.mozilla.org/r/98018/#review98498
Attachment #8817763 -
Flags: review?(jwwang) → review+
Comment 25•6 years ago
|
||
mozreview-review |
Comment on attachment 8817764 [details] Bug 1322799 part 2 - let AccurateSeekingState request demuxer seeking; https://reviewboard.mozilla.org/r/98020/#review98500
Attachment #8817764 -
Flags: review?(jwwang) → review+
Comment 26•6 years ago
|
||
mozreview-review |
Comment on attachment 8817765 [details] Bug 1322799 part 3 - move AccurateSeekTask::OnSeek{Resoved,Rejected}(); https://reviewboard.mozilla.org/r/98022/#review98502
Attachment #8817765 -
Flags: review?(jwwang) → review+
Comment 27•6 years ago
|
||
mozreview-review |
Comment on attachment 8817766 [details] Bug 1322799 part 4 - move AccurateSeekTask::Request{Audio,Video}Data(); https://reviewboard.mozilla.org/r/98024/#review98504
Attachment #8817766 -
Flags: review?(jwwang) → review+
Comment 28•6 years ago
|
||
mozreview-review |
Comment on attachment 8817768 [details] Bug 1322799 part 6 - move AccurateSeekTask::AdjustFastSeekIfNeeded(); https://reviewboard.mozilla.org/r/98028/#review98506
Attachment #8817768 -
Flags: review?(jwwang) → review+
Comment 29•6 years ago
|
||
mozreview-review |
Comment on attachment 8817769 [details] Bug 1322799 part 7 - move AccurateSeekTask::Drop{Audio,Video}UpToSeekTarget(); https://reviewboard.mozilla.org/r/98030/#review98508
Attachment #8817769 -
Flags: review?(jwwang) → review+
Comment 30•6 years ago
|
||
mozreview-review |
Comment on attachment 8817770 [details] Bug 1322799 part 8 - move AccurateSeekTask::MaybeFinishSeek(); https://reviewboard.mozilla.org/r/98032/#review98510
Attachment #8817770 -
Flags: review?(jwwang) → review+
Comment 31•6 years ago
|
||
mozreview-review |
Comment on attachment 8817771 [details] Bug 1322799 part 9 - move AccurateSeekTask::CalculateNewCurrentTime(); https://reviewboard.mozilla.org/r/98034/#review98512
Attachment #8817771 -
Flags: review?(jwwang) → review+
Comment 32•6 years ago
|
||
mozreview-review |
Comment on attachment 8817767 [details] Bug 1322799 part 5 - move AccurateSeekTask::Handle{Audio,Video,Not}{Decoded,Waited}(); } https://reviewboard.mozilla.org/r/98026/#review98514
Attachment #8817767 -
Flags: review?(jwwang) → review+
Comment 33•6 years ago
|
||
mozreview-review |
Comment on attachment 8817772 [details] Bug 1322799 part 10 - move all AccurateSeekTask data members; https://reviewboard.mozilla.org/r/98036/#review98516
Attachment #8817772 -
Flags: review?(jwwang) → review+
Comment 34•6 years ago
|
||
mozreview-review |
Comment on attachment 8817773 [details] Bug 1322799 part 11 - disconnect AccurateSeekingState and SeekTask; https://reviewboard.mozilla.org/r/98038/#review98518 ::: dom/media/MediaDecoderStateMachine.cpp (Diff revision 2) > mSeekRequest.DisconnectIfExists(); > } > > void HandleAudioDecoded(MediaData* aAudio) override > { > - MOZ_ASSERT(mSeekTaskRequest.Exists(), "Seek shouldn't be finished"); Why most of the assertions are removed?
Comment 35•6 years ago
|
||
mozreview-review |
Comment on attachment 8817774 [details] Bug 1322799 part 12 - remove AccurateSeekTask; https://reviewboard.mozilla.org/r/98040/#review98520
Attachment #8817774 -
Flags: review?(jwwang) → review+
Assignee | ||
Comment 36•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8817773 [details] Bug 1322799 part 11 - disconnect AccurateSeekingState and SeekTask; https://reviewboard.mozilla.org/r/98038/#review98518 > Why most of the assertions are removed? Oh! I forgot to add it back. The mSeekTaskRequest no longer holds any request. We should be able to modify the assertion to be: `MOZ_ASSERT(!mDoneAudioSeeking || !mDoneVideoSeeking)`. WDYT?
Comment 37•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8817773 [details] Bug 1322799 part 11 - disconnect AccurateSeekingState and SeekTask; https://reviewboard.mozilla.org/r/98038/#review98518 > Oh! I forgot to add it back. > The mSeekTaskRequest no longer holds any request. We should be able to modify the assertion to be: `MOZ_ASSERT(!mDoneAudioSeeking || !mDoneVideoSeeking)`. WDYT? SGTM.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 50•6 years ago
|
||
Try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b11abed3f4cf10ebe8ffc007164e56c011aafa22 https://treeherder.mozilla.org/#/jobs?repo=try&revision=402503d381a924ade9fc658a3e6945bc2b6af2ed
Comment 51•6 years ago
|
||
mozreview-review |
Comment on attachment 8817773 [details] Bug 1322799 part 11 - disconnect AccurateSeekingState and SeekTask; https://reviewboard.mozilla.org/r/98038/#review98810
Attachment #8817773 -
Flags: review?(jwwang) → review+
Comment 53•6 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f5530626b38 part 1 - un-encapsulating SeekTask; r=jwwang https://hg.mozilla.org/integration/autoland/rev/435ed350aded part 2 - let AccurateSeekingState request demuxer seeking; r=jwwang https://hg.mozilla.org/integration/autoland/rev/d3404f430dbe part 3 - move AccurateSeekTask::OnSeek{Resoved,Rejected}(); r=jwwang https://hg.mozilla.org/integration/autoland/rev/6aaada546c9e part 4 - move AccurateSeekTask::Request{Audio,Video}Data(); r=jwwang https://hg.mozilla.org/integration/autoland/rev/843ce5ebed5f part 5 - move AccurateSeekTask::Handle{Audio,Video,Not}{Decoded,Waited}(); r=jwwang} https://hg.mozilla.org/integration/autoland/rev/e9c176eb020f part 6 - move AccurateSeekTask::AdjustFastSeekIfNeeded(); r=jwwang https://hg.mozilla.org/integration/autoland/rev/aa32781d642e part 7 - move AccurateSeekTask::Drop{Audio,Video}UpToSeekTarget(); r=jwwang https://hg.mozilla.org/integration/autoland/rev/e1c21d0cf1e6 part 8 - move AccurateSeekTask::MaybeFinishSeek(); r=jwwang https://hg.mozilla.org/integration/autoland/rev/7c0755de4751 part 9 - move AccurateSeekTask::CalculateNewCurrentTime(); r=jwwang https://hg.mozilla.org/integration/autoland/rev/292f3801d9df part 10 - move all AccurateSeekTask data members; r=jwwang https://hg.mozilla.org/integration/autoland/rev/3df49621bf13 part 11 - disconnect AccurateSeekingState and SeekTask; r=jwwang https://hg.mozilla.org/integration/autoland/rev/e40251a6b98f part 12 - remove AccurateSeekTask; r=jwwang
Keywords: checkin-needed
Comment 54•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1f5530626b38 https://hg.mozilla.org/mozilla-central/rev/435ed350aded https://hg.mozilla.org/mozilla-central/rev/d3404f430dbe https://hg.mozilla.org/mozilla-central/rev/6aaada546c9e https://hg.mozilla.org/mozilla-central/rev/843ce5ebed5f https://hg.mozilla.org/mozilla-central/rev/e9c176eb020f https://hg.mozilla.org/mozilla-central/rev/aa32781d642e https://hg.mozilla.org/mozilla-central/rev/e1c21d0cf1e6 https://hg.mozilla.org/mozilla-central/rev/7c0755de4751 https://hg.mozilla.org/mozilla-central/rev/292f3801d9df https://hg.mozilla.org/mozilla-central/rev/3df49621bf13 https://hg.mozilla.org/mozilla-central/rev/e40251a6b98f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•