1331894 - Crash in InvalidArrayIndex_CRASH | mozilla::layers::BuildPathFromPolygon

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Julian Seward [:jseward]]

This bug was filed from the Socorro interface and is 
report bp-8a59c80a-242f-451b-9322-f78812170118.
=============================================================

This is ranked #22 in the windows build from 17 Jan.  It may be
fallout from bug 1323797.  See for example

https://crash-stats.mozilla.com/report/index/8a59c80a-242f-451b-9322-f78812170118

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

The signature looks similar to the one in bug 1331566

Comment 2

[Miko Mynttinen]

I think this crash might be caused by layer geometry overlapping with visible area so that the resulting polygon from clipping will be degenerate (point count < 3). This might happen if the visible area is only a couple of pixels. Such polygons should never get into BasicCompositor in the first place.

I already have a fix for this ready, just need a couple of hours to verify that the my hypothesis is correct, and that the fix works.

Comment 3

[Miko Mynttinen]

Attachment: Bug 1331894 - Crash in InvalidArrayIndex_CRASH | mozilla::layers::BuildPathFromPolygon - Cull polygons with no area

Review commit: https://reviewboard.mozilla.org/r/105526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105526/

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8827957 [details]
Bug 1331894 - Crash in InvalidArrayIndex_CRASH | mozilla::layers::BuildPathFromPolygon - Cull polygons with no area

https://reviewboard.mozilla.org/r/105526/#review106354

This looks good but please add a crash test that would reproduce the problem that triggered this.

Comment 6

[Miko Mynttinen]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b58d42e5764372693063215d5d36cb2ae8228f1

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b25f62eff46
Crash in InvalidArrayIndex_CRASH | mozilla::layers::BuildPathFromPolygon - Cull polygons with no area r=jrmuizel

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b25f62eff46