1324648 - Use GLContext to get GL functions pointers for webrender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

By using GLContext for getting GL functions pointers, GLContext and webrender become consistent and bindings.js becomes simpler.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use GLContext to get GL functions pointers for webrender

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use GLContext to get GL functions pointers for webrender

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use GLContext to get GL functions pointers for webrender

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3072b0ccb5da79a973883cdcb55943691636f76d

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8820165 [details] [diff] [review]
patch - Use GLContext to get GL functions pointers for webrender

Review of attachment 8820165 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLLibraryLoader.cpp
@@ +42,5 @@
>  
>  PRFuncPtr
> +GLLibraryLoader::LookupSymbol(const char* sym)
> +{
> +    return LookupSymbol(mLibrary,sym, mLookupFunc);

nit: put a space before |sym|.

::: gfx/layers/wr/WebRenderBridgeParent.cpp
@@ +22,5 @@
>  {
>    return mozilla::layers::CompositorThreadHolder::IsInCompositorThread();
>  }
>  
> +void* get_proc_address_from_glcontext(void* webrender_bridge_ptr, const char* procname)

Instead of passing a pointer to the WebRenderBridgeParent, can we pass a pointer to the GLContext instead? That seems a little safer and more direct. The WebRenderBridgeParent constructor already has the mGLContext so you don't need to break out the separate Init() function, and then in this callback you can cast the pointer back to a GLContext.

@@ +88,5 @@
>    MOZ_ASSERT(mGLContext);
>    MOZ_ASSERT(mCompositor);
> +}
> +void
> +WebRenderBridgeParent::Init()

If you leave Init() as a separate function, put a blank line before it

Comment 6

[Kartikaya Gupta (email:[e-mail])]

(In reply to Sotaro Ikeda [:sotaro] from comment #4)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=3072b0ccb5da79a973883cdcb55943691636f76d

Note that you can restrict the try push to the QR builds by doing something like this:

try: -b do -p macosx64-qr,linux64-qr,win64-qr -u all[linux64-qr] -t none

Comment 7

[Sotaro Ikeda [:sotaro]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #6)
> (In reply to Sotaro Ikeda [:sotaro] from comment #4)
> > https://treeherder.mozilla.org/#/
> > jobs?repo=try&revision=3072b0ccb5da79a973883cdcb55943691636f76d
> 
> Note that you can restrict the try push to the QR builds by doing something
> like this:
> 
> try: -b do -p macosx64-qr,linux64-qr,win64-qr -u all[linux64-qr] -t none

Thanks for the advice!

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> 
> ::: gfx/layers/wr/WebRenderBridgeParent.cpp
> @@ +22,5 @@
> >  {
> >    return mozilla::layers::CompositorThreadHolder::IsInCompositorThread();
> >  }
> >  
> > +void* get_proc_address_from_glcontext(void* webrender_bridge_ptr, const char* procname)
> 
> Instead of passing a pointer to the WebRenderBridgeParent, can we pass a
> pointer to the GLContext instead?

I am going to update the patch as to use GLContext.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use GLContext to get GL functions pointers for webrender

Apply the comments.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use GLContext to get GL functions pointers for webrender

Comment 11

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa5ae22e511c0c603e21741d10904c0659da9619

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/19a951289cad
Use GLContext to get GL functions pointers for webrender r=nical

Comment 13

[Sotaro Ikeda [:sotaro]]

(In reply to Pulsebot from comment #12)
> Pushed by [e-mail]:
> https://hg.mozilla.org/projects/graphics/rev/19a951289cad
> Use GLContext to get GL functions pointers for webrender r=nical

Sorry, reviewer was :kats.