Closed
Bug 1325646
Opened 7 years ago
Closed 7 years ago
Remove rust warnings from webrender_bindings
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox53 | --- | affected |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
There's a handful of warnings when building webrender_bindings, a lot of which can be fixed easily: 0:01.90 warning: unused import, #[warn(unused_imports)] on by default 0:01.90 --> /home/kats/zspace/mozilla-wr/gfx/webrender_bindings/src/bindings.rs:8:14 0:01.90 | 0:01.91 8 | use euclid::{Size2D, Point2D, Rect, Matrix4D}; 0:01.91 | ^^^^^^ 0:01.91 0:01.91 warning: unused import, #[warn(unused_imports)] on by default 0:01.91 --> /home/kats/zspace/mozilla-wr/gfx/webrender_bindings/src/bindings.rs:8:22 0:01.91 | 0:01.91 8 | use euclid::{Size2D, Point2D, Rect, Matrix4D}; 0:01.91 | ^^^^^^^ 0:01.91 0:01.91 warning: unused import, #[warn(unused_imports)] on by default 0:01.91 --> /home/kats/zspace/mozilla-wr/gfx/webrender_bindings/src/bindings.rs:8:31 0:01.91 | 0:01.91 8 | use euclid::{Size2D, Point2D, Rect, Matrix4D}; 0:01.91 | ^^^^ 0:01.91 0:01.91 warning: unused import, #[warn(unused_imports)] on by default 0:01.91 --> /home/kats/zspace/mozilla-wr/gfx/webrender_bindings/src/bindings.rs:8:37 0:01.91 | 0:01.91 8 | use euclid::{Size2D, Point2D, Rect, Matrix4D}; 0:01.91 | ^^^^^^^^ 0:01.91 0:01.91 warning: variable does not need to be mutable, #[warn(unused_mut)] on by default 0:01.91 --> /home/kats/zspace/mozilla-wr/gfx/webrender_bindings/src/bindings.rs:27:9 0:01.91 | 0:01.91 27 | let mut symbol = unsafe { 0:01.91 | ^^^^^^^^^^ 0:01.91 0:01.91 warning: variant is never used: `TEXTURE_HANDLE`, #[warn(dead_code)] on by default 0:01.91 --> /home/kats/zspace/mozilla-wr/gfx/webrender_bindings/src/bindings.rs:98:5 0:01.91 | 0:01.91 98 | TEXTURE_HANDLE, 0:01.91 | ^^^^^^^^^^^^^^ 0:01.91 0:01.91 warning: function is never used: `wait_for_render_notification`, #[warn(dead_code)] on by default 0:01.91 --> /home/kats/zspace/mozilla-wr/gfx/webrender_bindings/src/bindings.rs:483:1 0:01.91 | 0:01.91 483 | fn wait_for_render_notification(notifier: &Arc<(Mutex<bool>, Condvar)>) { 0:01.91 | ^ 0:01.91
Assignee | ||
Comment 1•7 years ago
|
||
Adding as dependencies the bugs that introduced the warnings. At least the ones that I'm going to fix (all except the TEXTURE_HANDLE one).
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/ef15cb6b6cce Fix some warnings when building webrender_bindings. r=gfx?
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•