1325279 - Put the reaction queue in CustomElementData structure instead of using a map

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[John Dai[:jdai]]

+++ This bug was initially created as a follow-up of Bug #1309184 comment #22 +++

> +  typedef nsTArray<nsAutoPtr<CustomElementReaction>> ReactionQueue;
> +  typedef nsClassHashtable<nsISupportsHashKey, ReactionQueue>
> +    ElementReactionQueueMap;
> +
> +  ElementReactionQueueMap mElementReactionQueueMap;

Elements have a structured called CustomElementData in the slots, you may be able put the reaction queue in that structure instead of using a map, but it will require a bit of refactoring to create the CustomElementData a bit earlier when we add elements to the reactions stack.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Per project discussion, this is a nice-to-have refactoring, not necessarily being in the project MVT, so removing dom-ce-m2 whiteboard.

Comment 2

[Edgar Chen [:edgar]]

Bug 1347446 makes accessing ElementReactionQueue in CustomElementRegistry becomes a bit non-trival (have to get it via DocGroup) and bug 1299363 part 2 patch has already refactored the creation time of CustomElementData, so I am going to handle this change in bug 1299363 (part 6 patch). Then we can just get reaction queue from Element.

Comment 3

[Edgar Chen [:edgar]]

I planed to handle this bug in bug 1299363. But other bugs are blocked by this change, so I move the patch back to this bug in order to let other bugs can move forward.

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ac25dd383614a47ecec807676456cc2abf46a76

Comment 5

[Edgar Chen [:edgar]]

Attachment: Patch, v2

Comment 6

[Edgar Chen [:edgar]]

Attachment: Patch, v3

Rebase.

Comment 7

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=947ae332681ac40b36879a177f29279c1b1d9300&filter-tier=1&group_state=expanded&selectedJob=97885634

Comment 8

[Edgar Chen [:edgar]]

Comment on attachment 8866161 [details] [diff] [review]
Patch, v3

Review of attachment 8866161 [details] [diff] [review]:
-----------------------------------------------------------------

Bug 1347446 makes accessing ElementReactionQueue becomes a bit non-trival (have to get it via DocGroup).
Since bug 1359346 already refactors the creation time of CustomElementData, ReactionQueue can also be put into
CustomElementData, then we can just get ReactionQueue from Element.

May I have your review, William? Thank you.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/36f9b151741b
Put the reaction queue in CustomElementData structure instead of using a map; r=wchen

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/36f9b151741b