Closed Bug 1359346 Opened 3 years ago Closed 3 years ago

Implement custom element state

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

()

Details

(Whiteboard: dom-ce-m2 )

Attachments

(2 files)

interdiff with the review granted patch (attachment 8838497 [details] [diff] [review]).
Comment on attachment 8861727 [details] [diff] [review]
Patch, v3, r=wchen

This patch is originally from the part 2 patch of bug 1299363 which has been r+ed in bug 1299363 comment# 67. Because other bugs is blocked by this change, I split it from bug 1299363 to this bug in order to let other bugs can move forward.

Changes in this version:
- Addressed review comment #67, use enum class.
- Rebase since some code depends on the part 1 patch of bug 1299363.

I also attach the interdiff, see attachment 8861728 [details] [diff] [review].

Hi William, is this patch okay to land or maybe you want to take a look again.
Thank you.
Flags: needinfo?(wchen)
Blocks: 1325279
Whiteboard: dom-ce-m2
(In reply to Edgar Chen [:edgar] from comment #4)
> Comment on attachment 8861727 [details] [diff] [review]
> Patch, v3, r=wchen
> 
> This patch is originally from the part 2 patch of bug 1299363 which has been
> r+ed in bug 1299363 comment# 67. Because other bugs is blocked by this
> change, I split it from bug 1299363 to this bug in order to let other bugs
> can move forward.
> 
> Changes in this version:
> - Addressed review comment #67, use enum class.
> - Rebase since some code depends on the part 1 patch of bug 1299363.
> 
> I also attach the interdiff, see attachment 8861728 [details] [diff] [review]
> [review].
> 
> Hi William, is this patch okay to land or maybe you want to take a look
> again.
> Thank you.

Yes, it's okay to land.
Flags: needinfo?(wchen)
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/553d3684230c
Implement custom element state; r=wchen
https://hg.mozilla.org/mozilla-central/rev/553d3684230c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.