|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Bug 1325374 - Specify more globals in browser.js/nsBrowserGlue.js, and start fixing up some of places.
59 bytes, text/x-review-board-request
|Details | Review|
Looking into bug 1323167, I discovered that there were a lot of undefined vars in browser.js. These are due to the fact that we don't handle the specific form of some getter imports (see bug 1325373). This form is used in nsBrowserGlue.js as well. The places changes are for starting to fix up the places tests. Overall, this kills about a 1000 of the 5000 no-undef failures we have in browser/
Comment on attachment 8821154 [details] Bug 1325374 - Specify more globals in browser.js/nsBrowserGlue.js, and start fixing up some of places. https://reviewboard.mozilla.org/r/100522/#review101074
Attachment #8821154 - Flags: review?(dtownsend) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/74797a69118d Specify more globals in browser.js/nsBrowserGlue.js, and start fixing up some of places. r=mossop
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.