[Eslint] Get browser.js and nsBrowserGlue.js passing for no-undef and fix up some places issues

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
Firefox 53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Looking into bug 1323167, I discovered that there were a lot of undefined vars in browser.js. These are due to the fact that we don't handle the specific form of some getter imports (see bug 1325373).

This form is used in nsBrowserGlue.js as well.

The places changes are for starting to fix up the places tests.

Overall, this kills about a 1000 of the 5000 no-undef failures we have in browser/
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8821154 [details]
Bug 1325374 - Specify more globals in browser.js/nsBrowserGlue.js, and start fixing up some of places.

https://reviewboard.mozilla.org/r/100522/#review101074
Attachment #8821154 - Flags: review?(dtownsend) → review+

Comment 3

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74797a69118d
Specify more globals in browser.js/nsBrowserGlue.js, and start fixing up some of places. r=mossop

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/74797a69118d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.