1325374 - [Eslint] Get browser.js and nsBrowserGlue.js passing for no-undef and fix up some places issues

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mark Banner (:standard8)]

Looking into bug 1323167, I discovered that there were a lot of undefined vars in browser.js. These are due to the fact that we don't handle the specific form of some getter imports (see bug 1325373).

This form is used in nsBrowserGlue.js as well.

The places changes are for starting to fix up the places tests.

Overall, this kills about a 1000 of the 5000 no-undef failures we have in browser/

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1325374 - Specify more globals in browser.js/nsBrowserGlue.js, and start fixing up some of places.

Review commit: https://reviewboard.mozilla.org/r/100522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100522/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8821154 [details]
Bug 1325374 - Specify more globals in browser.js/nsBrowserGlue.js, and start fixing up some of places.

https://reviewboard.mozilla.org/r/100522/#review101074

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74797a69118d
Specify more globals in browser.js/nsBrowserGlue.js, and start fixing up some of places. r=mossop

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74797a69118d