Make the check for duplicate Treeherder symbols, happen during `full` graph not `target` graph stage.

RESOLVED FIXED in mozilla53

Status

task
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

unspecified
mozilla53
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug #1323633 has bitten me a few times on date, I always run `./mach taskgraph full ...` since the verification steps have been added.

And in this case, a treeherder duplicate symbol, I don't see why only validating with a target set is ideal/wanted, when the same push can have multiple target sets run on it. -- We should just validate with the whole graph.
Comment on attachment 8821207 [details]
Bug 1325398 - Make the check for duplicate Treeherder symbols, happen during `full` graph not `target` graph stage.

https://reviewboard.mozilla.org/r/100546/#review101086
Attachment #8821207 - Flags: review?(dustin) → review+
Hammad, FYI -- let's do these checks earlier in the task-graph generation process so we catch errors sooner.
When transitive closure for full task graph is computed some more dependent tasks are added so I thought maybe I should do the check after obtaining a target task graph.
(In reply to HAMMAD AKHTAR from comment #4)
> When transitive closure for full task graph is computed some more dependent
> tasks are added so I thought maybe I should do the check after obtaining a
> target task graph.

My understanding:

* FULL
  - set of all tasks that can possibly run (scheduled by taskcluster) on this push
  - computed first
* TARGET
   - Tasks that should run on this push
   - First by selecting all tasks that would match the 'target' conditions
   - Then by adding in tasks that are dependancies of those selected ones
* OPTIMIZED
   - Tasks that *will* run on this push
   - ...
So basically all possible tasks are loaded resulting in full task graph,
then we identify target tasks and determine there dependencies resulting in target task graph.
Right -- so if there are duplicates in target or optimized, then those duplicates will also exist in the full graph.
ahh right, checking after generating full task graph will catch errors early :)
Pushed by Callek@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/614959839ad7
Make the check for duplicate Treeherder symbols, happen during `full` graph not `target` graph stage. r=dustin
https://hg.mozilla.org/mozilla-central/rev/614959839ad7
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Blocks: 1326462
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.