Closed
Bug 1325398
Opened 7 years ago
Closed 7 years ago
Make the check for duplicate Treeherder symbols, happen during `full` graph not `target` graph stage.
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla53
People
(Reporter: Callek, Assigned: Callek)
References
Details
Attachments
(1 file)
Bug #1323633 has bitten me a few times on date, I always run `./mach taskgraph full ...` since the verification steps have been added. And in this case, a treeherder duplicate symbol, I don't see why only validating with a target set is ideal/wanted, when the same push can have multiple target sets run on it. -- We should just validate with the whole graph.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8821207 [details] Bug 1325398 - Make the check for duplicate Treeherder symbols, happen during `full` graph not `target` graph stage. https://reviewboard.mozilla.org/r/100546/#review101086
Attachment #8821207 -
Flags: review?(dustin) → review+
Comment 3•7 years ago
|
||
Hammad, FYI -- let's do these checks earlier in the task-graph generation process so we catch errors sooner.
Comment 4•7 years ago
|
||
When transitive closure for full task graph is computed some more dependent tasks are added so I thought maybe I should do the check after obtaining a target task graph.
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to HAMMAD AKHTAR from comment #4) > When transitive closure for full task graph is computed some more dependent > tasks are added so I thought maybe I should do the check after obtaining a > target task graph. My understanding: * FULL - set of all tasks that can possibly run (scheduled by taskcluster) on this push - computed first * TARGET - Tasks that should run on this push - First by selecting all tasks that would match the 'target' conditions - Then by adding in tasks that are dependancies of those selected ones * OPTIMIZED - Tasks that *will* run on this push - ...
Comment 6•7 years ago
|
||
So basically all possible tasks are loaded resulting in full task graph, then we identify target tasks and determine there dependencies resulting in target task graph.
Comment 7•7 years ago
|
||
Right -- so if there are duplicates in target or optimized, then those duplicates will also exist in the full graph.
Comment 8•7 years ago
|
||
ahh right, checking after generating full task graph will catch errors early :)
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
Pushed by Callek@gmail.com: https://hg.mozilla.org/integration/autoland/rev/614959839ad7 Make the check for duplicate Treeherder symbols, happen during `full` graph not `target` graph stage. r=dustin
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/614959839ad7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•