1326462 - Make the check for duplicate gecko v2 routes, happen during `full` graph.

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Justin Wood (:Callek)]

As per (re: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1325398#c3 )

we should run these checks sooner.

(Seemingly just using ./mach taskgraph target` didn't break on a gecko v2 route, but optimized did. Either way we should position it on `full`)

Assigning to Hammad, with thanks.

Comment 1

[HAMMAD AKHTAR]

Attachment: Bug 1326462 - Make the check for duplicate gecko v2 routes, happen during full graph;

Review commit: https://reviewboard.mozilla.org/r/101704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101704/

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 8823098 [details]
Bug 1326462 - Make the check for duplicate gecko v2 routes, happen during full graph;

https://reviewboard.mozilla.org/r/101704/#review102198

Looks good. I'd love the hg commit summary amended to include the full bug text (sorry, I used backticks, which probably tried to run some command called `full` on your terminal). I don't really *need* the backticks in the commit message though.

I'll land this tomorrow with or without the fixed commit message.

Comment 3

[HAMMAD AKHTAR]

Comment on attachment 8823098 [details]
Bug 1326462 - Make the check for duplicate gecko v2 routes, happen during full graph;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/101704/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bd789dee7a6
Make the check for duplicate gecko v2 routes, happen during full graph; r=Callek

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6bd789dee7a6

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/68d35cdae645

Comment 7

[Justin Wood (:Callek)]

(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #6)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/68d35cdae645

This was actually meant to be in https://bugzilla.mozilla.org/show_bug.cgi?id=1326452#c12