Closed Bug 1326462 Opened 4 years ago Closed 4 years ago

Make the check for duplicate gecko v2 routes, happen during `full` graph.

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla53

People

(Reporter: Callek, Assigned: hammad13060)

References

Details

Attachments

(1 file)

As per (re: Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1325398#c3 )

we should run these checks sooner.

(Seemingly just using ./mach taskgraph target` didn't break on a gecko v2 route, but optimized did. Either way we should position it on `full`)

Assigning to Hammad, with thanks.
Comment on attachment 8823098 [details]
Bug 1326462 - Make the check for duplicate gecko v2 routes, happen during full graph;

https://reviewboard.mozilla.org/r/101704/#review102198

Looks good. I'd love the hg commit summary amended to include the full bug text (sorry, I used backticks, which probably tried to run some command called `full` on your terminal). I don't really *need* the backticks in the commit message though.

I'll land this tomorrow with or without the fixed commit message.
Attachment #8823098 - Flags: review?(bugspam.Callek) → review+
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6bd789dee7a6
Make the check for duplicate gecko v2 routes, happen during full graph; r=Callek
https://hg.mozilla.org/mozilla-central/rev/6bd789dee7a6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #6)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/68d35cdae645

This was actually meant to be in https://bugzilla.mozilla.org/show_bug.cgi?id=1326452#c12
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.