Remove browser.preferences.instantApply and its code

NEW
Unassigned

Status

()

Firefox
Preferences
--
major
2 years ago
13 days ago

People

(Reporter: Virtual, Unassigned)

Tracking

(Blocks: 2 bugs, {nightly-community})

Firefox Tracking Flags

(Not tracked)

Details

Remove "browser.preferences.instantApply" preference from about:config and its code,
especially when patches from bug #1140495 and bug #738797 landed very long time ago and made "browser.preferences.instantApply" preference irrelevant in Options.
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
The comm-central apps (IB, SM and TB) still use this pref.
Besides being vestigial, the pref causes openPrefsHelp in utilityOverlay.js to open help pages for the Fonts, Colors, Languages, Connections, and "Settings for Clearing History" subdialogs in a new window on Windows (because "prefwindows are usually modal"), even though those subdialogs are *not* modal, and the help pages could be opened in the same window.

This pref really should be removed, and openPrefsHelp should use a different mechanism to determine whether it is being called from a modal prefwindow (of which the only one remaining in Firefox is the Clear Recent History… dialog).
Do I need to remove these lines only?

https://searchfox.org/mozilla-central/search?q=browser.preferences.instantApply&case=false&regexp=false&path=
Flags: needinfo?(jaws)
You would need to remove/update the following places:
https://searchfox.org/mozilla-central/search?q=instantapply&path=
Flags: needinfo?(jaws)
You need to log in before you can comment on or make changes to this bug.