1325637 - Remove browser.preferences.instantApply and its code

Status: VERIFIED FIXED

(Toolkit :: Preferences, task, P3)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Remove "browser.preferences.instantApply" preference from about:config and its code,
especially when patches from bug #1140495 and bug #738797 landed very long time ago and made "browser.preferences.instantApply" preference irrelevant in Options.

Comment 1

[Richard Marti (:Paenglab)]

The comm-central apps (IB, SM and TB) still use this pref.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Besides being vestigial, the pref causes openPrefsHelp in utilityOverlay.js to open help pages for the Fonts, Colors, Languages, Connections, and "Settings for Clearing History" subdialogs in a new window on Windows (because "prefwindows are usually modal"), even though those subdialogs are *not* modal, and the help pages could be opened in the same window.

This pref really should be removed, and openPrefsHelp should use a different mechanism to determine whether it is being called from a modal prefwindow (of which the only one remaining in Firefox is the Clear Recent History… dialog).

Comment 3

[Manish [:manishkk]]

Do I need to remove these lines only?

https://searchfox.org/mozilla-central/search?q=browser.preferences.instantApply&case=false&regexp=false&path=

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

You would need to remove/update the following places:
https://searchfox.org/mozilla-central/search?q=instantapply&path=

Comment 5

[Sriharsha]

I want to work on this. Can you please assign it to me.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Please feel free to work on this. I will mark the bug assigned when a patch is uploaded for review. Please ask any questions you may have while working on the bug.

Comment 7

[Shivam Singhal [ :championshuttler ]]

Hi @Jaws Can i take this up?

Thanks

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Shivam Singhal [ :championshuttler ] from comment #7)

Hi @Jaws Can i take this up?

Thanks

Please feel free to work on this. I will mark the bug assigned when a patch is uploaded for review. Please ask any questions you may have while working on the bug.

Comment 9

[Jayati Shrivastava]

Hello, May I submit a patch for this bug?

Comment 10

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Please see Jared Wein [:jaws] comment #8 and comment #6. Also hint/tip is in comment #4.

Comment 11

[Jayati Shrivastava]

We are not determining if the function is being called from a model perfwindow anywhere https://searchfox.org/mozilla-central/search?q=openhelplink&case=false&regexp=false&path= . So should I just remove all cases of instantapply?

Comment 12

[Jayati Shrivastava]

Attachment: Bug 1325637 - Remove browser.preferences.instantApply and its code. r=jaws

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Clearing assignee, because we haven't heard from them since April 19 2020 in Phabricator.

Comment 14

[Patrick (he/him)]

Attachment: Bug 1325637 removed browser.preferences.instantApply and its code r?jaws

Comment 15

[Patrick (he/him)]

This one has turned out to be beyond my abilities

Comment 16

[Mathew Hodson]

Attachment: Bug 1325637 - Remove browser.preferences.instantApply pref. r?Gijs

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/309fa7dcf0ee
Remove browser.preferences.instantApply pref. r=Gijs,preferences-reviewers

Comment 18

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/309fa7dcf0ee