Update in-tree libpng to version 1.6.27

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glennrp+bmo, Assigned: glennrp+bmo)

Tracking

Trunk
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

2 years ago
libpng-1.6.27 has been released.  It is mostly a code-cleanup release.  It fixes an old potential NULL pointer dereference that does not affect mozilla when using either the system libpng or the embedded libpng.
(Assignee)

Updated

2 years ago
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
(Assignee)

Comment 1

2 years ago
Be careful not to regress bug #1300661
Depends on: 1300661
(Assignee)

Comment 2

2 years ago
Created attachment 8822682 [details] [diff] [review]
v00-1326234-update-libpng-to-version-1.6.27

Please submit this v00 patch to try.
Flags: needinfo?(ryanvm)
(Assignee)

Comment 4

2 years ago
Comment on attachment 8822682 [details] [diff] [review]
v00-1326234-update-libpng-to-version-1.6.27

Try looks good (ignoring XP failures which probably are not libpng related).
Attachment #8822682 - Flags: review?(jmuizelaar)
Yeah, those were my bad (we don't support XP on 53+, so I should have removed them from the Try syntax when copy/pasting from prior runs)
Attachment #8822682 - Flags: review?(jmuizelaar) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e12fd5a54d1
Update in-tree libpng to version 1.6.27. r=jrmuizel
Keywords: checkin-needed
(Assignee)

Comment 7

2 years ago
Please leave open; should also update old-configure.in to require libpng-1.6.27.  I'll upload a separate patch for that.
Keywords: leave-open
(Assignee)

Comment 8

2 years ago
Created attachment 8822886 [details] [diff] [review]
v00-1326234-part-02-update-old-configure-in.diff
Attachment #8822886 - Flags: review?(jmuizelaar)
Attachment #8822886 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 9

2 years ago
Please check in part 02.
Flags: needinfo?(ryanvm)
Keywords: leave-open → checkin-needed

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7e12fd5a54d1
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: affected → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Assignee)

Comment 11

2 years ago
Reopened pending checkin of part02.
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---
(Assignee)

Comment 12

2 years ago
Created attachment 8822918 [details] [diff] [review]
v00-1326234-part-03-fix-sse2-license-in-png-h

The first patch inadvertently stripped out the license paragraph about SSE2 support from png.h.  This patch restores it.

Please check this in, too.
Attachment #8822918 - Flags: review?(jmuizelaar)
(Assignee)

Updated

2 years ago
See Also: → bug 1328099

Comment 13

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/949122733877
Update in-tree libpng to version 1.6.27 (old-configure.in). r=jrmuizel
Keywords: checkin-needed

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/949122733877
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
(Assignee)

Comment 15

2 years ago
Reopened again, until patch part 03 lands.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 16

2 years ago
Libpng 1.6.28 will be out shortly (expected January 5) to
fix a bug exposed by attempting to build with zlib-1.2.9.
I'll open a new bug for 1.6.28.
(Assignee)

Updated

2 years ago
Blocks: 1328354
Let's just call this bug done then and include part 3 in the 1.6.28 update.
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Flags: needinfo?(ryanvm)
Resolution: --- → FIXED
Attachment #8822918 - Attachment is obsolete: true
Attachment #8822918 - Flags: review?(jmuizelaar)
(Assignee)

Comment 18

2 years ago
Yes, thanks
You need to log in before you can comment on or make changes to this bug.