Closed Bug 1326234 Opened 3 years ago Closed 3 years ago

Update in-tree libpng to version 1.6.27

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: glennrp+bmo, Assigned: glennrp+bmo)

References

()

Details

Attachments

(2 files, 1 obsolete file)

libpng-1.6.27 has been released.  It is mostly a code-cleanup release.  It fixes an old potential NULL pointer dereference that does not affect mozilla when using either the system libpng or the embedded libpng.
Assignee: nobody → glennrp+bmo
Status: NEW → ASSIGNED
Be careful not to regress bug #1300661
Depends on: 1300661
Please submit this v00 patch to try.
Flags: needinfo?(ryanvm)
Comment on attachment 8822682 [details] [diff] [review]
v00-1326234-update-libpng-to-version-1.6.27

Try looks good (ignoring XP failures which probably are not libpng related).
Attachment #8822682 - Flags: review?(jmuizelaar)
Yeah, those were my bad (we don't support XP on 53+, so I should have removed them from the Try syntax when copy/pasting from prior runs)
Attachment #8822682 - Flags: review?(jmuizelaar) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e12fd5a54d1
Update in-tree libpng to version 1.6.27. r=jrmuizel
Keywords: checkin-needed
Please leave open; should also update old-configure.in to require libpng-1.6.27.  I'll upload a separate patch for that.
Keywords: leave-open
Attachment #8822886 - Flags: review?(jmuizelaar)
Attachment #8822886 - Flags: review?(jmuizelaar) → review+
Please check in part 02.
Flags: needinfo?(ryanvm)
https://hg.mozilla.org/mozilla-central/rev/7e12fd5a54d1
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Reopened pending checkin of part02.
Status: RESOLVED → REOPENED
Keywords: checkin-needed
Resolution: FIXED → ---
The first patch inadvertently stripped out the license paragraph about SSE2 support from png.h.  This patch restores it.

Please check this in, too.
Attachment #8822918 - Flags: review?(jmuizelaar)
See Also: → 1328099
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/949122733877
Update in-tree libpng to version 1.6.27 (old-configure.in). r=jrmuizel
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/949122733877
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Reopened again, until patch part 03 lands.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Libpng 1.6.28 will be out shortly (expected January 5) to
fix a bug exposed by attempting to build with zlib-1.2.9.
I'll open a new bug for 1.6.28.
Blocks: 1328354
Let's just call this bug done then and include part 3 in the 1.6.28 update.
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Flags: needinfo?(ryanvm)
Resolution: --- → FIXED
Attachment #8822918 - Attachment is obsolete: true
Attachment #8822918 - Flags: review?(jmuizelaar)
Yes, thanks
You need to log in before you can comment on or make changes to this bug.