1328040 - Flash plugin context menu (even if closed) prevents the 1st click on UI and fires 'click' on html document

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect, P3)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:
1. Open attachment 8675621 [details]
2. Right-click on the Flash plugin
3. Click in urlbar (or on any item on toolbar)

AR:  Context menu hides. No other actions. 'click' event fires on HTML document
ER:  Urlbar should be focused (if you clicked on some other item, click should happen in a normal way)


STR_2:
1. Open attachment 8675621 [details]
2. Right-click on the Flash plugin. Click on menuitem "Increase zoom level"
3. Click in urlbar (or on any item on toolbar)

AR:  Step 2 - context menu hides. Step 3 - No visible action, 'click' event fires on HTML document
ER:  Urlbar should be focused (if you clicked on some other item, click should happen in a normal way)


This is a regression.

Comment 1

[Benjamin Smedberg]

arni, you say this is a regression? Do you know the release or date this regressed? Or at least which prior release did this work the way you expect?

Do you know if this has the same behavior for both windowed-mode Flash and windowless?

Comment 3

[arni2033]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #1)
> arni, you say this is a regression? Do you know the release or date this
> regressed? Or at least which prior release did this work the way you expect?
> 
> Do you know if this has the same behavior for both windowed-mode Flash and windowless?

Depends on the definition of "regression". The issue is specific to windowless Flash.
In the past, most of Flash objects everywhere were windowed, but there also were some cases of [wmode] when Flash still was windowless. Quite recently most of Flash objects became windowless.

I filed this with such keywords, because I wanted it to be tracked in the bug that turned most of Flash to windowless, i.e. greately increased the spread of this issue (I had no time to bisect). But
now I know the bug. If you have better idea on keywords and tracking, apply your changes in this bug.

Probably there was time when windowless Flash didn't have this issue - bug I haven't checked it.

Comment 4

[Justin [:JW_SoftvisionQA]]

INFO: Last good revision: b40ba117fa757861c9caa660ae989122718b494b (2015-12-10)
INFO: First bad revision: 754b4805a65cab4f3aca99899227acc44ba4fb20 (2015-12-11)
INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b40ba117fa757861c9caa660ae989122718b494b&tochange=754b4805a65cab4f3aca99899227acc44ba4fb20

I was able to confirm that this is a regression using mozregression.

Comment 5

[Benjamin Smedberg]

	a1bd47d76f71	David Anderson — Enable direct plugin drawing by default. (bug 1229961 part 2, r=aklotz)

Comment 6

[Andrew Overholt [:overholt]]

Jim, do you know if this depends on the whole async drawing thing we're keeping on Nightly? Are we still keeping that on Nightly?

Comment 7

[Jim Mathies [:jimm]]

(In reply to Andrew Overholt [:overholt] from comment #6)
> Jim, do you know if this depends on the whole async drawing thing we're
> keeping on Nightly? Are we still keeping that on Nightly?

not async drawing related. probably a long standing bug in plugins.

Comment 8

[Stefan [:StefanG_QA]]

The issue is still reproducible with the latest Nightly and Beta builds. 

STR in the initial comment are still showing the issue. 

Flipping the following pref does not make any difference: "dom.ipc.plugins.asyncdrawing.enabled"

Comment 9

[Benjamin Smedberg]

We're not going to treat this as a high priority.

Comment 10

[u597032]

Adobe Flash is no longer supported.