Closed Bug 1340934 (flash-async-drawing) Opened 6 years ago Closed 6 years ago

Re-enable Flash async drawing

Categories

(Core Graveyard :: Plug-ins, defect)

51 Branch
Unspecified
Windows
defect
Not set
normal

Tracking

(firefox51 wontfix, firefox52 wontfix, firefox53 wontfix, firefox54 wontfix, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox51 --- wontfix
firefox52 --- wontfix
firefox53 --- wontfix
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: cpeterson, Assigned: jimm)

References

Details

Attachments

(1 file)

No description provided.
Alias: flash-async-drawing
I think we may want some dedicated testing here, since this sort of change has broken Flash content before.

Chris, is this change targeting Firefox 54? 

Any thoughts on the risk of this breaking stuff? Any suggestions for testing are also welcome as always.
Flags: needinfo?(cpeterson)
Florin, we will definitely want some QA help! Jim will be working with Stefan to see if we can reuse the same test plan from when we previously enabled Flash async drawing.
Flags: needinfo?(cpeterson)
Depends on: 1311990
Depends on: 1342092
Depends on: 1334415
Depends on: 1344940
Depends on: 1344927
Depends on: 1344941
Depends on: 1271398
Depends on: 1317995
Depends on: 1345649
No longer depends on: 1290528
Attached patch patchSplinter Review
Depends on: 1347575
No longer depends on: 1323403
Depends on: 1347925
Depends on: 1348629
No longer depends on: 1328040
No longer blocks: 1229961
Comment on attachment 8847627 [details] [diff] [review]
patch

Per the async drawing email thread today, async drawing will be enabled on beta 54 after the next merge. this patch will land on mc and aurora.
Attachment #8847627 - Flags: review?(benjamin)
Comment on attachment 8847627 [details] [diff] [review]
patch

Approval Request Comment
[Feature/Bug causing the regression]:
none
[User impact if declined]:
This new flash feature needs to roll out to beta for additional testing.
[Is this code covered by automated tests?]:
no
[Has the fix been verified in Nightly?]:
no bug
[Needs manual test from QE? If yes, steps to reproduce]: 
No, we're coordinating sv testing.
[List of other uplifts needed for the feature/fix]:
none
[Is the change risky?]:
no
[Why is the change risky/not risky?]:
prefs change that turns a feature on in beta that's been in use in dev channels for six months.
[String changes made/needed]:
none.
Attachment #8847627 - Flags: approval-mozilla-aurora?
Attachment #8847627 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/427229c2bff1
Enable flash async drawing on release channels. r=bsmedberg
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/427229c2bff1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment on attachment 8847627 [details] [diff] [review]
patch

Enable 64-bit Funnelcake experiment in 54. Aurora54+.
Attachment #8847627 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1359886
Depends on: 1363611
backed out from beta on request from jimm
Flags: needinfo?(jmathies)
Flags: needinfo?(jmathies)
Depends on: 1363290
Depends on: 1360666
(In reply to Carsten Book [:Tomcat] from comment #11)
> backed out from beta on request from jimm

https://hg.mozilla.org/releases/mozilla-beta/rev/6b0cf48f6481
Depends on: 1363876
No longer depends on: 1363290
Depends on: 1366756
Blocks: 1296400
No longer depends on: 1312648
Depends on: 1394105
Depends on: 1393352
Depends on: 1391624
Depends on: 1388326
Depends on: 1392022
Depends on: 1345988
Depends on: 1354154
Depends on: 1394408
Depends on: 1422021
Depends on: 1423481
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.