1328464 - The checkbox of "Add me to CC list (follow this bug)" doesn't work

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Xidorn Quan [:xidorn] UTC+11]

I found that when I leave the checkbox "Add me to CC list (follow this bug)" untouched (checked) and click "Save Changes", either with or without other changes, it doesn't make me follow the bug.

The "Follow" button continue working, though.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Not sure whether it is a bmo bug or a bugzilla bug, and not sure what is the proper component for it.

Comment 2

[Wayne Mery (:wsmwk)]

This hit me twice this morning with  Bug 1325743  and bug 1285563
And I'm pretty sure also some time yesterday.

pretty insideous

Comment 3

[Wayne Mery (:wsmwk)]

Dang, I also didn't get CC on this bug when I commented

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Regression caused by bug 1262465

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1328464_2.patch

Comment 6

[David Lawrence [:dkl]]

Comment on attachment 8823658 [details] [diff] [review]
1328464_2.patch

Review of attachment 8823658 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh, sorry. I did this as I was adding them to cc if they marked the bug as sec sensitive and they had no role on the bug automatically. So we also need to change

https://github.com/mozilla-bteam/bmo/blob/master/extensions/BugModal/web/bug_modal.js#L1123

and make it set to true only if not true already. Right now it would set it to false if someone unchecks make this sec sensitive after checking it. Can you fix that on commit please?

r=dkl

Comment 7

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #6)
> Comment on attachment 8823658 [details] [diff] [review]
> 1328464_2.patch
> 
> Review of attachment 8823658 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Ugh, sorry. I did this as I was adding them to cc if they marked the bug as
> sec sensitive and they had no role on the bug automatically. So we also need
> to change
> 
> https://github.com/mozilla-bteam/bmo/blob/master/extensions/BugModal/web/
> bug_modal.js#L1123
> 
> and make it set to true only if not true already. Right now it would set it
> to false if someone unchecks make this sec sensitive after checking it. Can
> you fix that on commit please?
> 
> r=dkl

I propose:

      // Add user to cc list if they mark the bug as security sensitive
      $('.restrict_sensitive')
          .change(function(event) {
              if ($('#addselfcc').val() == 0)
                 $('#addselfcc').val(1);
          });

Comment 8

[Dylan Hardison [:dylan] (he/him)]

Going with:    


$('.restrict_sensitive')
    .change(function(event) {
        $('#add-self-cc:not(:checked)').attr('checked', true);
    });

Comment 9

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   550a798..ad7cbed  master -> master

To [e-mail]:mozilla-bteam/bmo.git
   ad7cbed..e3f7a84  master -> master