1328503 - stylo: tests timeout because of using unimplemented Animation API on new window

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Xidorn Quan [:xidorn] UTC+11]

There are several style system mochitests timeout because they use Element.getAnimations() which returns invalid value with stylo.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

layout/style/test/test_animations_with_disabled_properties.html
layout/style/test/test_transitions_replacement_on_busy_frame.html

Comment 2

[Boris Chiou [:boris]]

test_animations_with_disabled_properties.html is also blocked by Bug 1288269, and test_transitions_replacement_on_busy_frame.html is also blocked by 1302946.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Now test_animations_with_disabled_properties.html passes.

Comment 4

[Boris Chiou [:boris]]

Looks like only test_transitions_replacement_on_busy_frame.html is not enabled yet.

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1328503 - Enable test_transitions_replacement_on_busy_frame.html on stylo.

Review commit: https://reviewboard.mozilla.org/r/142648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142648/

Comment 6

[Boris Chiou [:boris]]

It seems we can run test_transitions_replacement_on_busy_frame.html now.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8871137 [details]
Bug 1328503 - Enable test_transitions_replacement_on_busy_frame.html on stylo.

https://reviewboard.mozilla.org/r/142648/#review146280

Nice!

::: commit-message-f81bc:1
(Diff revision 1)
> +Bug 1328503 - Enable test_transitions_replacement_on_busy_frame.html.

Nit: on stylo.

Comment 8

[Boris Chiou [:boris]]

Comment on attachment 8871137 [details]
Bug 1328503 - Enable test_transitions_replacement_on_busy_frame.html on stylo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142648/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f03e92bff58
Enable test_transitions_replacement_on_busy_frame.html on stylo. r=hiro

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f03e92bff58