Closed Bug 1330594 Opened 8 years ago Closed 7 years ago

Remove Zoomed View

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: JanH, Unassigned)

References

Details

We carry around the code and have got a setting for it on Nightly builds, but that doesn't do anything. From a very quick perusal, the immediate cause is that currently, the detection of clustered links is tied to mouse retargetting, which has been disabled in bug 1247095. If you manually reenable ui.mouse.radius.enabled just for testing (a proper solution is probably more involved so as not to regress bug 1247095), the zoomed view appears, but - long clicking in it to bring up the context menu doesn't work (not sure whether it ever worked in the short period the Zoomed View was working on Nightly out of the box) - short clicking works, but opens the wrong link, so the click position apparently gets messed up somewhere And if you look at bug 1328991 comment 1, ZoomedView.java (https://dxr.mozilla.org/mozilla-central/rev/13603af3862d9583ed2feefb06e0988c2d7fed8c/mobile/android/base/java/org/mozilla/gecko/ZoomedView.java) listens to a few zoom related events that are no longer sent from anywhere, presumably because they were handled by the pre-APZ code.
Afaik a product decision was made to remove this feature - do you remember, Barbara?
Flags: needinfo?(bbermes)
In which case we should probably go the other way and remove the code.
I believe you are correct, Sebastian, let's remove the code.
Flags: needinfo?(bbermes)
Okay. Meta bug: 663803 -> Let's close all bugs after removing the code.
See Also: → zoomedview
Summary: Make Zoomed View work again → Remove Zoomed View
Blocks: fatfennec
The zoomedview code was removed in bug 1335895.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.