1329379 - [Tracking Bug] Drop OSX universal builds.

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

It looks like m-c has dropped Universal builds and has moved to 64 only.

:stefan  should we follow suite?

Comment 1

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #0)
> It looks like m-c has dropped Universal builds and has moved to 64 only.
> 
> :stefan  should we follow suite?

On second thoughts... I could be wrong as I was looking at the tooltool
part when I should've looked at the mozconfig part.  my bad

Comment 2

[Stefan [:stefanh]]

Have a look at bug 1322402 and its dependencies (yes, m-c dropped support for universal builds in december). Not following would probably mean future breakage (for instance, iirc we have some code specific to 32-bit which probably will be removed in the future)

Comment 3

[Edmund Wong (:ewong)]

(In reply to Stefan [:stefanh] from comment #2)
> Have a look at bug 1322402 and its dependencies (yes, m-c dropped support
> for universal builds in december). Not following would probably mean future
> breakage (for instance, iirc we have some code specific to 32-bit which
> probably will be removed in the future)

Ah. I thought I was going nuts coz I remembered somewhere that they were
dropping -universal but I noticed the universal mozconfigs still there..
I guess I didn't follow the mozconfig line of usage.

Thanks for reopening this stefan.  Will check those bugs out.

Comment 4

[Edmund Wong (:ewong)]

Attachment: [mozconfigs] Remove macosx-universal and move the required stuff to macosx64

Comment 5

[Edmund Wong (:ewong)]

Attachment: [configs] drop universal builds.

buildbot config changes.  we don't need the additional objdir/i386 now.

Comment 6

[Stefan [:stefanh]]

Just a note (I know it's probably a different bug, but I'm unsure where that should be filed): We need to ensure that updates to users running universal builds are handled correct (there should be a m-c bug about that that will give more info).

Comment 7

[Philip Chee]

Comment on attachment 8825635 [details] [diff] [review]
[mozconfigs] Remove macosx-universal and move the required stuff to macosx64

r=me a=me

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8825636 [details] [diff] [review]
[configs] drop universal builds.

r=me.
I assume the SeaMonkey buildbot is only using the seamonkey dir? Calendar dir still contains the i386.

Comment 9

[Edmund Wong (:ewong)]

(In reply to Frank-Rainer Grahl from comment #8)
> Comment on attachment 8825636 [details] [diff] [review]
> [configs] drop universal builds.
> 
> r=me.
> I assume the SeaMonkey buildbot is only using the seamonkey dir? Calendar
> dir still contains the i386.

Yes..  SeaMonkey buildbot infra uses only the seamonkey directory.

Comment 10

[Edmund Wong (:ewong)]

(In reply to Stefan [:stefanh] from comment #6)
> Just a note (I know it's probably a different bug, but I'm unsure where that
> should be filed): We need to ensure that updates to users running universal
> builds are handled correct (there should be a m-c bug about that that will
> give more info).

I'm still gathering the necessary information, and aside for not allowing
updates for users on universal release builds on c-b and c-r, I'm not
entirely sure (atm) how we'll accomplish this with c-c and c-a.

Callek, any ideas?

Comment 11

[Edmund Wong (:ewong)]

https://hg.mozilla.org/comm-central/rev/becf847f864ca2765095ea5f22a4cd6f99d35729
Bug 1329379 - Drop universal OSX64 builds from the mozconfigs. r+a=RattyAway

Comment 12

[Edmund Wong (:ewong)]

https://hg.mozilla.org/build/buildbot-configs/rev/4c177cdfde2dcc2562b5e89bc16d81c2572281e0
Bug 1329379 - Change objdir for osx64 builds. r=frg

Comment 13

[Edmund Wong (:ewong)]

Attachment: [configs] forgot the regular build

Comment 14

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8825635 [details] [diff] [review]
[mozconfigs] Remove macosx-universal and move the required stuff to macosx64

[Approval Request Comment]
Regression caused by (bug #): 1322402
User impact if declined: No OSX builds
Testing completed (on m-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): none already broken
String changes made by this patch:

Comment 15

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8825635 [details] [diff] [review]
[mozconfigs] Remove macosx-universal and move the required stuff to macosx64

ewong the old release-l10n in macosx64 which doesn't get changed by the bug does not look right compared to the deleted one and the current one in mail. Broken anyway because of l10n but could you check this.

Comment 16

[Ian Neal]

Comment on attachment 8825635 [details] [diff] [review]
[mozconfigs] Remove macosx-universal and move the required stuff to macosx64

a=me

Comment 17

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-aurora/rev/a2e29c659fc4eccf60f461da7ffe825a4ff6e975

Comment 18

[Edmund Wong (:ewong)]

Attachment: [configs] forgot regular build and switch back to universal build for seamonkey versions <= 2.50

This builds upon the previous patch which includes the correct non-universal
mozconfig for the regular build as well as setting the proper objdir
depending on the Gecko version.

Comment 19

[Edmund Wong (:ewong)]

(In reply to Frank-Rainer Grahl from comment #15)
> Comment on attachment 8825635 [details] [diff] [review]
> [mozconfigs] Remove macosx-universal and move the required stuff to macosx64
> 
> ewong the old release-l10n in macosx64 which doesn't get changed by the bug
> does not look right compared to the deleted one and the current one in mail.
> Broken anyway because of l10n but could you check this.

Sure.  I'll take a look

Comment 20

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8841386 [details] [diff] [review]
[configs] forgot regular build and switch back to universal build for seamonkey versions <= 2.50

r+ to get the beta going but as stated might need a change next week after merge day when 2.48 beta branch and 2.49 beta are both in comm-beta and need to be build.

Comment 21

[Edmund Wong (:ewong)]

https://hg.mozilla.org/build/buildbot-configs/rev/ccc49f7b5a34bfad22f30a088542a9e6a58ed693
Bug 1329379 - Drop universal builds for SeaMonkey version >= 2.51 r=frg

Comment 22

[Frank-Rainer Grahl (:frg)]

We are done here. 2.49.5 dropped the universal builds.