Bug 1512882 (SM2.49.5)

Tracking bug for build and release of SeaMonkey 2.49.5

NEW
Assigned to

Status

enhancement
P1
blocker
5 months ago
a month ago

People

(Reporter: frg, Assigned: ewong)

Tracking

(Depends on 2 bugs)

SeaMonkey 2.49 Branch
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.49esr affected)

Details

()

Attachments

(7 attachments, 3 obsolete attachments)

Reporter

Description

5 months ago
+++ This bug was initially created as a clone of Bug #1459133 +++

This is a tracking bug for Build and Release of SeaMonkey 2.49.5

We expect an actual release on tba.
Reporter

Updated

5 months ago
Alias: SM2.49.5
Reporter

Updated

5 months ago
Depends on: SM2495-RELNOTE
Reporter

Comment 1

5 months ago
patches-2_49_5.zip contains the patch queue which can be used to build 2.49.5. It needs to be checked into mozilla-esr52 as a branch.

Basically all esr52 patches are from the old TB 52 verbranch.
esr60 patches are security backports up to Gecko 60.2. I plan to port additonal fixes while the 2.49.5 builds are being prepared.
Rest is mostly VS2017 support and a few pickings from upstreak.

The 3 1512882* patches are my own and have not been reviewed by anyone. See individual attachments.

Bills 2.49.x build contains all of them. I removed private local and WIP patches from the official queue.

The SeaMonkey comm-esr52 branch need just to be merged with the default branch. Currently everything needed is already checked in.
Attachment #9030495 - Flags: feedback?(iann_bugzilla)
Attachment #9030495 - Flags: feedback?(ewong)
Reporter

Comment 2

5 months ago
Individual patch needed for newer rust versions and clang 6 for macOS support in case we want to use cross compile.
Reporter

Comment 3

5 months ago
Use the older Windows search icon on Windows 8.x. The default skinny 10 one looks terrible here.
Assignee: nobody → frgrahl
Reporter

Comment 4

5 months ago
The wow_helper was removed after 52 because it is only needed on Vista and XP x64 when using an x86 build. It will not compile or link with VS2017 without this fix because the compiler and linker are in a different location.
Reporter

Comment 5

5 months ago
Locally all including l10n is peachy but config changes might be required. 

I would recommend:

VS2017 15.6.7 or 15.8.3+ (not sure if a tooltool package exists). 
Windows toolkit 10.0.17763.x
Latest rust for whcih a tooltool package is available.
gcc as is or 5.x 
clang and macOS sdk as is unless we drop the universal build.
Reporter

Updated

5 months ago
Assignee: frgrahl → nobody
Assignee

Comment 6

5 months ago
Kinda lost here.  Do you mean all those patches need to be applied to our relbranch?

We don't have a vs2017 tooltool package.  Will need to get it off tb's tc or something.

This is shaping up to be a harsh release.
Reporter

Comment 7

5 months ago
Comment on attachment 9030497 [details] [diff] [review]
1512882-clang-osx.patch

esr52 only.
Various compiler fixes
- Support clang 6 for cross compiling macOS builds
- Potential MSVC fix
- Remove [root] from Cargo.lock to enable compiling with later rust versions.
Attachment #9030497 - Flags: review?(iann_bugzilla)
Attachment #9030497 - Flags: approval-comm-esr52?
Reporter

Comment 8

5 months ago
Comment on attachment 9030501 [details] [diff] [review]
1512882-search.patch

mozilla esr52 SeaMonkey relbranch only

Use the close icon from previous Windows version in 8.x too.
Attachment #9030501 - Flags: review?(iann_bugzilla)
Attachment #9030501 - Flags: approval-comm-esr52?
Reporter

Comment 9

5 months ago
In lower toolbar over the tabs. Fits right in. The later older Windows 10 style one from Firefox looks awful here.
Reporter

Comment 10

5 months ago
Comment on attachment 9030504 [details] [diff] [review]
1512882-vs2017-x86.patch

mozilla esr52 SeaMonkey relbranch only

Support VS2017 compiling x64 wow helper in x86 builds.
Attachment #9030504 - Flags: review?(iann_bugzilla)
Attachment #9030504 - Flags: approval-comm-esr52?
Reporter

Comment 11

5 months ago
Comment on attachment 9030497 [details] [diff] [review]
1512882-clang-osx.patch

Actually mozilla esr52 SeaMonkey relbranch only too

Comment 12

5 months ago
Comment on attachment 9030495 [details] [diff] [review]
mozilla esr52 new SeaMonkey 2.49 ESR branch patches.

f=me
Attachment #9030495 - Flags: feedback?(iann_bugzilla)
Attachment #9030495 - Flags: feedback+
Attachment #9030495 - Flags: approval-comm-esr52+

Comment 13

5 months ago
Comment on attachment 9030497 [details] [diff] [review]
1512882-clang-osx.patch

r/a=me
Attachment #9030497 - Flags: review?(iann_bugzilla)
Attachment #9030497 - Flags: review+
Attachment #9030497 - Flags: approval-comm-esr52?
Attachment #9030497 - Flags: approval-comm-esr52+

Comment 14

5 months ago
Comment on attachment 9030501 [details] [diff] [review]
1512882-search.patch

r/a=me
Attachment #9030501 - Flags: review?(iann_bugzilla)
Attachment #9030501 - Flags: review+
Attachment #9030501 - Flags: approval-comm-esr52?
Attachment #9030501 - Flags: approval-comm-esr52+

Comment 15

5 months ago
Comment on attachment 9030504 [details] [diff] [review]
1512882-vs2017-x86.patch

r/a=me
Attachment #9030504 - Flags: review?(iann_bugzilla)
Attachment #9030504 - Flags: review+
Attachment #9030504 - Flags: approval-comm-esr52?
Attachment #9030504 - Flags: approval-comm-esr52+
Assignee

Updated

4 months ago
Attachment #9030495 - Flags: feedback?(ewong)
Assignee

Comment 16

4 months ago
Posted patch bug_1512882.diff (obsolete) — Splinter Review

Notes regarding this patch:

  1. It's based on the new_infra_clean branch and not the seamonkey-production
    one that we used to use. The new BB infra uses BB 1.20 which requires
    some upheaval (and personal touches).
  2. This patch is to give our new bb something to chew on as it's failing
    with c-c.
  3. I expect the build # to rack up. (Place your bets here.... :P )
Assignee: nobody → ewong
Attachment #9035223 - Flags: review?(frgrahl)
Reporter

Comment 17

4 months ago
Posted patch bug_1512882.diff (obsolete) — Splinter Review

Updated the branches and now you have the review honor :)

Changes:

  • milestone is 52.9.1.
  • new csets for comm-esr52 and mozilla-esr52
  • branch SEAMONKEY_2_49_ESR_RELBRANCH from comm-esr52. I suspect relbranchPrefix": "SEA_COMM" needs to be adjusted or a new tag is needed.

l10n tags are unchanged from 2.49.4. I didn't verify the file.

Attachment #9035223 - Attachment is obsolete: true
Attachment #9035223 - Flags: review?(frgrahl)
Attachment #9036196 - Flags: review?(ewong)
Assignee

Comment 18

4 months ago
Comment on attachment 9036196 [details] [diff] [review]
bug_1512882.diff

Review of attachment 9036196 [details] [diff] [review]:
-----------------------------------------------------------------

Will need to change the cset for comm-esr52 as I'll be pushing a patch (if needed, pending your clarification) to have ESR build with VS2017.
Attachment #9036196 - Flags: review?(ewong) → review+
Assignee

Comment 19

4 months ago
Attachment #9036249 - Flags: review?(frgrahl)
Reporter

Comment 20

4 months ago
Comment on attachment 9036249 [details] [diff] [review]
use vs2017 for building.

Review of attachment 9036249 [details] [diff] [review]:
-----------------------------------------------------------------

This might need a ac_add_options --with-visual-studio-version=2017 in the mozconfigs. Not sure if it picks VS2017 if 2015 is not available.
Attachment #9036249 - Flags: review?(frgrahl) → review+
Assignee

Comment 21

4 months ago

Comment on attachment 9036249 [details] [diff] [review]
use vs2017 for building.

need to push this to comm-esr52

Attachment #9036249 - Flags: approval-comm-esr52?

Comment 22

4 months ago

Comment on attachment 9036249 [details] [diff] [review]
use vs2017 for building.

a=me

Attachment #9036249 - Flags: approval-comm-esr52? → approval-comm-esr52+
Reporter

Comment 23

4 months ago
Posted patch build config for 2.49.5 (obsolete) — Splinter Review

cset from comm-esr52 corrected after latest config push. r+ retained.

Attachment #9036196 - Attachment is obsolete: true
Attachment #9036277 - Flags: review+
Reporter

Comment 24

4 months ago

opps wrong file. r+ retained.

Attachment #9036277 - Attachment is obsolete: true
Attachment #9036278 - Flags: review+
Reporter

Comment 25

4 months ago

Comment on attachment 9036278 [details] [diff] [review]
2.49.5 build config pushed in comment 28

ewong for the push I can't find the new branch you mentioned in buildbot config. Do I/we need to create one?

Flags: needinfo?(ewong)
Assignee

Comment 26

4 months ago

(In reply to Frank-Rainer Grahl (:frg) from comment #25)

Comment on attachment 9036278 [details] [diff] [review]
2.49.5 build config

ewong for the push I can't find the new branch you mentioned in buildbot
config. Do I/we need to create one?

It should be there.

https://hg.mozilla.org/SeaMonkey/buildbot-configs/

Flags: needinfo?(ewong)
Reporter

Comment 27

4 months ago

Thanks. Didn't know about this one. Only knew the seamonkey-production branch in the normal repo.
https://hg.mozilla.org/build/buildbot-configs/

Reporter

Updated

4 months ago
Attachment #9036278 - Attachment description: 2.49.5 build config → 2.49.5 build config pushed in comment 28
Reporter

Updated

4 months ago
Duplicate of this bug: 1520728
Assignee

Updated

4 months ago
Depends on: 1521254
You need to log in before you can comment on or make changes to this bug.