1512882 - (SM2.49.5) Tracking bug for build and release of SeaMonkey 2.49.5

Status: RESOLVED FIXED

(SeaMonkey :: Release Engineering, enhancement, P1)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #1459133 +++

This is a tracking bug for Build and Release of SeaMonkey 2.49.5

We expect an actual release on tba.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: mozilla esr52 new SeaMonkey 2.49 ESR branch patches pushed 01/13/2019

patches-2_49_5.zip contains the patch queue which can be used to build 2.49.5. It needs to be checked into mozilla-esr52 as a branch.

Basically all esr52 patches are from the old TB 52 verbranch.
esr60 patches are security backports up to Gecko 60.2. I plan to port additonal fixes while the 2.49.5 builds are being prepared.
Rest is mostly VS2017 support and a few pickings from upstreak.

The 3 1512882* patches are my own and have not been reviewed by anyone. See individual attachments.

Bills 2.49.x build contains all of them. I removed private local and WIP patches from the official queue.

The SeaMonkey comm-esr52 branch need just to be merged with the default branch. Currently everything needed is already checked in.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1512882-clang-osx.patch pushed see comment 31

Individual patch needed for newer rust versions and clang 6 for macOS support in case we want to use cross compile.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1512882-search.patch pushed see comment 30

Use the older Windows search icon on Windows 8.x. The default skinny 10 one looks terrible here.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1512882-vs2017-x86.patch pushed see comment 32

The wow_helper was removed after 52 because it is only needed on Vista and XP x64 when using an x86 build. It will not compile or link with VS2017 without this fix because the compiler and linker are in a different location.

Comment 5

[Frank-Rainer Grahl (:frg)]

Locally all including l10n is peachy but config changes might be required. 

I would recommend:

VS2017 15.6.7 or 15.8.3+ (not sure if a tooltool package exists). 
Windows toolkit 10.0.17763.x
Latest rust for whcih a tooltool package is available.
gcc as is or 5.x 
clang and macOS sdk as is unless we drop the universal build.

Comment 6

[Edmund Wong (:ewong)]

Kinda lost here.  Do you mean all those patches need to be applied to our relbranch?

We don't have a vs2017 tooltool package.  Will need to get it off tb's tc or something.

This is shaping up to be a harsh release.

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9030497 [details] [diff] [review]
1512882-clang-osx.patch pushed see comment 31

esr52 only.
Various compiler fixes
- Support clang 6 for cross compiling macOS builds
- Potential MSVC fix
- Remove [root] from Cargo.lock to enable compiling with later rust versions.

Comment 8

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9030501 [details] [diff] [review]
1512882-search.patch
pushed see comment 30

mozilla esr52 SeaMonkey relbranch only

Use the close icon from previous Windows version in 8.x too.

Comment 9

[Frank-Rainer Grahl (:frg)]

Attachment: Older Close icon in Windows 8.1

In lower toolbar over the tabs. Fits right in. The later older Windows 10 style one from Firefox looks awful here.

Comment 10

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9030504 [details] [diff] [review]
1512882-vs2017-x86.patch pushed see comment 32

mozilla esr52 SeaMonkey relbranch only

Support VS2017 compiling x64 wow helper in x86 builds.

Comment 11

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9030497 [details] [diff] [review]
1512882-clang-osx.patch pushed see comment 31

Actually mozilla esr52 SeaMonkey relbranch only too

Comment 12

[Ian Neal]

Comment on attachment 9030495 [details] [diff] [review]
mozilla esr52 new SeaMonkey 2.49 ESR branch patches pushed 01/13/2019

f=me

Comment 13

[Ian Neal]

Comment on attachment 9030497 [details] [diff] [review]
1512882-clang-osx.patch pushed see comment 31

r/a=me

Comment 14

[Ian Neal]

Comment on attachment 9030501 [details] [diff] [review]
1512882-search.patch
pushed see comment 30

r/a=me

Comment 15

[Ian Neal]

Comment on attachment 9030504 [details] [diff] [review]
1512882-vs2017-x86.patch pushed see comment 32

r/a=me

Comment 16

[Edmund Wong (:ewong)]

Attachment: bug_1512882.diff

Notes regarding this patch:

1. It's based on the new_infra_clean branch and not the seamonkey-production
   one that we used to use. The new BB infra uses BB 1.20 which requires
   some upheaval (and personal touches).
2. This patch is to give our new bb something to chew on as it's failing
   with c-c.
3. I expect the build # to rack up. (Place your bets here.... :P )

Comment 17

[Frank-Rainer Grahl (:frg)]

Attachment: bug_1512882.diff

Updated the branches and now you have the review honor :)

Changes:

• milestone is 52.9.1.
• new csets for comm-esr52 and mozilla-esr52
• branch SEAMONKEY_2_49_ESR_RELBRANCH from comm-esr52. I suspect relbranchPrefix": "SEA_COMM" needs to be adjusted or a new tag is needed.

l10n tags are unchanged from 2.49.4. I didn't verify the file.

Comment 18

[Edmund Wong (:ewong)]

Comment on attachment 9036196 [details] [diff] [review]
bug_1512882.diff

Review of attachment 9036196 [details] [diff] [review]:
-----------------------------------------------------------------

Will need to change the cset for comm-esr52 as I'll be pushing a patch (if needed, pending your clarification) to have ESR build with VS2017.

Comment 19

[Edmund Wong (:ewong)]

Attachment: Use vs2017 for building. Pushed see comment 33

Comment 20

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9036249 [details] [diff] [review]
Use vs2017 for building. Pushed see comment 33

Review of attachment 9036249 [details] [diff] [review]:
-----------------------------------------------------------------

This might need a ac_add_options --with-visual-studio-version=2017 in the mozconfigs. Not sure if it picks VS2017 if 2015 is not available.

Comment 21

[Edmund Wong (:ewong)]

Comment on attachment 9036249 [details] [diff] [review]
Use vs2017 for building. Pushed see comment 33

need to push this to comm-esr52

Comment 22

[Ian Neal]

Comment on attachment 9036249 [details] [diff] [review]
Use vs2017 for building. Pushed see comment 33

a=me

Comment 23

[Frank-Rainer Grahl (:frg)]

Attachment: build config for 2.49.5

cset from comm-esr52 corrected after latest config push. r+ retained.

Comment 24

[Frank-Rainer Grahl (:frg)]

Attachment: 2.49.5 build config pushed in comment 28

opps wrong file. r+ retained.

Comment 25

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9036278 [details] [diff] [review]
2.49.5 build config pushed in comment 28

ewong for the push I can't find the new branch you mentioned in buildbot config. Do I/we need to create one?

Comment 26

[Edmund Wong (:ewong)]

(In reply to Frank-Rainer Grahl (:frg) from comment #25)

Comment on attachment 9036278 [details] [diff] [review]
2.49.5 build config

ewong for the push I can't find the new branch you mentioned in buildbot
config. Do I/we need to create one?

It should be there.

https://hg.mozilla.org/SeaMonkey/buildbot-configs/

Comment 27

[Frank-Rainer Grahl (:frg)]

Thanks. Didn't know about this one. Only knew the seamonkey-production branch in the normal repo.
https://hg.mozilla.org/build/buildbot-configs/

Comment 28

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9036278 [details] [diff] [review]
2.49.5 build config pushed in comment 28

https://hg.mozilla.org/SeaMonkey/buildbot-configs/rev/682f632b4c1d4b9faf011745cf2aebcbcba44ec7

Comment 30

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9030501 [details] [diff] [review]
1512882-search.patch
pushed see comment 30

https://hg.mozilla.org/releases/mozilla-esr52/rev/0f943991c228
Bug 1512882 - Use Windows 7 search icon on Windows 8.x. r=IanN a=IanN CLOSED TREE DONTBUILD

Comment 31

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9030497 [details] [diff] [review]
1512882-clang-osx.patch pushed see comment 31

https://hg.mozilla.org/releases/mozilla-esr52/rev/905d6e43e2ec
Bug 1512882 - Allow macOS cross compile with clang 6 plus VS2017 and later rust fix. r=IanN a=IanN CLOSED TREE DONTBUILD

Comment 32

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9030504 [details] [diff] [review]
1512882-vs2017-x86.patch pushed see comment 32

https://hg.mozilla.org/releases/mozilla-esr52/rev/d47e78bd1354
Bug 1512882 - Support building comm-esr52 x86 with VS2017. r=IanN a=IanN CLOSED TREE DONTBUILD

Comment 33

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9036249 [details] [diff] [review]
Use vs2017 for building. Pushed see comment 33

https://hg.mozilla.org/releases/comm-esr52/rev/2cb6da32d02e
Bug 1512882 - Update VS tooltool packages for VS2017 15.9.5. r=frg a=IanN

Comment 34

[Frank-Rainer Grahl (:frg)]

Attachment: 1512882-client_repo.patch pushed in comment 37

Allows to use a branch for checkout. I didn't try a clone but should work too.

Uses the default changesets for cZ and DOMi which are compatible with 2.49.5

If rev is specified this will be used for the update. Incompatible with branch but if the rev is in the branch the source will be updated to it.

Comment 35

[Frank-Rainer Grahl (:frg)]

Attachment: 1512882-restore-extensions.patch pushed in comment 37

Patch for our SEAMONKEY_2_49_RELBRANCH to undo the changes done to disable extension building because of l10n bug 1231349

r+ a+ some time ago from IanN over irc. If not let me know.

There is no easy way to set a branch to the default branch and we did sone changes in between to the branch so backing out the original changes would be cumbersome.

Comment 36

[Ian Neal]

Comment on attachment 9073438 [details] [diff] [review]
1512882-client_repo.patch  pushed in comment 37

LGTM r/a=me

Comment 37

[Frank-Rainer Grahl (:frg)]

The final fixes have been pushed and we are hopefully done with the source:
https://hg.mozilla.org/releases/comm-esr52/pushloghtml?changeset=6b30146aa4117616f2570fe192eaad1938fa5416
https://hg.mozilla.org/releases/mozilla-esr52/pushloghtml?changeset=3a4afe7ecac570decfb1d388eee2682d5d15dbc8

Comment 38

[Frank-Rainer Grahl (:frg)]

Attachment: 1512882-osx_cross.patch pushed in comment 37

Comment 39

[Frank-Rainer Grahl (:frg)]

Attachment: 1512882-centos_bootstrap.patch pushed in comment 37

Comment 40

[Frank-Rainer Grahl (:frg)]

Attachment: 1512882-xpi_langpack.patch pushed in comment 37

Comment 41

[Dmitry Butskoy (:buc)]

Considering Attachment #9073439 [details] [diff] (restore extensions patch):

I try to disable irc and inspector at build time (yes, questionable idea, but it is buid od a package for a distribution with its own rules etc.)
For this, I specify "--enable-extensions=default,-inspector,-irc" (or just "--enable-extensions=gio" to avoid defaults).

It leads to a situation when dist/bin/distribution/extensions directory just does not exist (since nothing need it). And then suite/app/Makefile complains:
make[5]: *** No rule to make target ../../dist/bin/distribution/extensions', needed bypack-ext'. Stop.

Manually adding of this dir removes the message only, the things still are failed anyway.

Comment 42

[Frank-Rainer Grahl (:frg)]

This is fixed in bug 1559419. So far I was under the assumption that it does not apply to comm-esr52. If we need another 2.49 I will add it there too but just putting the line in app/Makefile.in should fix it for local builds.

Comment 43

[Dmitry Butskoy (:buc)]

Yep, still missing in build3

Comment 44

[Dmitry Butskoy (:buc)]

Well, the patch from bug #1559419 fixes the build itself, but there are still issues when I make langpacks (a bit separately from the usual build process).

After the normal build is complete, I perform:

pushd obj-*/suite/locales

for lang in $languages
do
make merge-$lang LOCALE_MERGEDIR=../../l10n-merges
make langpack-$lang LOCALE_MERGEDIR=../../l10n-merges
done

popd

and for the first lang(=cs) in the list "make langpack-cs" faled with:

make: *** ../../extensions/irc/locales: No such file or directory. Stop.
make: *** [libs-cs] Error 2

Since ready-made xpi langpacks (as in 2.49.4) no more provided, it is an issue.

(BTW, whether it is possible to have version, or date, or git etc. in the name of l10n tarball? And it would be fine to have one common initial subdir in tarball as well...)

Comment 45

[Dmitry Butskoy (:buc)]

whether it is possible to have version
Sure it has. No more work at the night... :)

Having common initial subdir for l10n tarball would be fine for rpm-based distros.

Comment 46

[Dmitry Butskoy (:buc)]

Attachment: seamonkey-2.49.5-crmf.patch

One more patch needed to build SM-2.49.5 with system nss/nspr.
Something changed since 2.49.4, and now we should remove "crmf" stuff there.

Probably related somehow to bug #1371991 , but it removes in another place...

Comment 47

[Frank-Rainer Grahl (:frg)]

The l10n tarball is available in
https://archive.mozilla.org/pub/seamonkey/candidates/2.49.5-candidates/build3/source/

Comment 48

[Dmitry Butskoy (:buc)]

For bug #1512881 comment #44:

make: *** ../../extensions/irc/locales: No such file or directory. Stop.
make: *** [libs-cs] Error 2

can be fixed by a kludge:

diff -Nrbu seamonkey-2.49.5/seamonkey-2.49.5/suite/locales/Makefile.in seamonkey-2.49.5-OK/seamonkey-2.49.5/suite/locales/Makefile.in
--- seamonkey-2.49.5/seamonkey-2.49.5/suite/locales/Makefile.in 2019-07-14 00:01:29.000000000 +0300
+++ seamonkey-2.49.5-OK/seamonkey-2.49.5/suite/locales/Makefile.in 2019-08-19 22:45:21.358643583 +0300
@@ -123,7 +123,7 @@
@$(MAKE) -C $(DEPTH)/toolkit/locales libs-$*
@$(MAKE) -C $(DEPTH)/services/sync/locales AB_CD=$* XPI_NAME=locale-$*
@$(MAKE) -C ../../editor/ui/locales AB_CD=$* XPI_NAME=locale-$*
- @$(MAKE) -C $(DEPTH)/extensions/irc/locales libs-$*
+ @$(MAKE) -C $(DEPTH)/extensions/irc/locales libs-$* || :
@$(MAKE) -C $(DEPTH)/extensions/spellcheck/locales AB_CD=$* XPI_NAME=locale-$*
@$(MAKE) -C $(DEPTH)/intl/locales AB_CD=$* XPI_NAME=locale-$*
@$(MAKE) -C $(DEPTH)/devtools/client/locales AB_CD=$* XPI_NAME=locale-$*

But then, at "make install" stage,

Error: /home/buc/rpmbuild/BUILD/seamonkey-2.49.5/seamonkey-2.49.5/obj-x86_64-pc-linux-gnu/suite/installer/package-manifest:639: Missing file(s): bin/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi
Error: /home/buc/rpmbuild/BUILD/seamonkey-2.49.5/seamonkey-2.49.5/obj-x86_64-pc-linux-gnu/suite/installer/package-manifest:642: Missing file(s): bin/distribution/extensions/[e-mail]

It seems that [chatzilla] and [inspector] sections should be ifdef'ed (like for MOZ_CALENDAR) in suite/installer/package-manifest.in ...

Is it applicable just to remove unneeded distribution/extensions/* files after the package is built, instead of non-working "--enable-extensions"? Or maybe its presence is mentioned something else in the generated code?

Comment 49

[Frank-Rainer Grahl (:frg)]

Well we were actually happy to build them again so tests disabling them were not really done. This is all fixed in 2.53 and up where you can turn them on and off in the mozconfig with enable directives.

You can try backing out https://hg.mozilla.org/releases/comm-esr52/rev/3fe8be0e3a645eb17b5e4ac6902677014102706d which will restore the 2.49.4 state for extensions.

Comment 50

[Dmitry Butskoy (:buc)]

This is all fixed in 2.53 and up where you can turn them on and off in the mozconfig with enable directives.

Fine.

Then bug #1512882 comment #46 still remains for me (ie. build with system nss).

Comment 51

[Frank-Rainer Grahl (:frg)]

Then bug #1512882 comment #46 still remains for me (ie. build with system nss).

Some time ago backported and so fixed in 2.53 too. When 2.49.5 is released we hope to do a 2.53 beta soon. We do not plan to fix anything else in 2.49.x.

Comment 52

[Frank-Rainer Grahl (:frg)]

The journey of esr52 has come to an end unless a major bug is discovered soon. Thanks to all involved and see you in 2.53.