Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Learn More links should only be 10px after the text

VERIFIED FIXED in Firefox 54

Status

()

Firefox
Preferences
VERIFIED FIXED
6 months ago
17 days ago

People

(Reporter: jaws, Assigned: Ian Ferguson, Mentored)

Tracking

(Blocks: 1 bug)

52 Branch
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox54 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

From page 7 of https://bugzilla.mozilla.org/attachment.cgi?id=8819509 (and specified more explicitly on slide 5 of https://bugzilla.mozilla.org/attachment.cgi?id=8819509

This was missed in bug 1324170.
Assignee: nobody → xfergusi
Mentor: mconley@mozilla.com, jaws@mozilla.com
Comment hidden (mozreview-request)
(Reporter)

Comment 2

6 months ago
mozreview-review
Comment on attachment 8829678 [details]
Bug 1330314 - Reduce the inline-start margin for Learn More links to keep the link contextually closer.

https://reviewboard.mozilla.org/r/106678/#review107990

Please run 'hg histedit' and choose the 'mess' option to edit the commit message for your patch, then re-push it for review. Your commit message should describe what and why your patch is changing. It should also include the bug number at the beginning and the reviewer at the end. Once you do this we can get your patch landed in mozilla-central.

Your commit message is currently: "Bug 1330314 Adding adding 10px after the text for Learn More links. r?jaws"

Your commit message should be: "Bug 1330314 - Reduce the inline-start margin for Learn More links to keep the link contextually closer. r?jaws"
Attachment #8829678 - Flags: review?(jaws) → review+
Comment hidden (mozreview-request)

Comment 4

6 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f43d635de8d
Reduce the inline-start margin for Learn More links to keep the link contextually closer. r=jaws
https://hg.mozilla.org/mozilla-central/rev/8f43d635de8d
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Created attachment 8852483 [details]
issue1.png

I've tested on Windows 7 x64, Ubuntu 14.04 x64 and Mac OS X 10.11 using latest Aurora 54.0a2 (2017-03-29) and I have one mention here: there is more than 10px between the text and the "Learn More" links: 
- under DRM Content (Content tab) - 18px
- under Notifications (Content tab) - 11px
- under Tracking (Privacy tab) - 18px
- under Data Choices (Advanced tab) - 38px/12px/61px

This is expected? 

Shouldn't we keep the same distance between the text and the "Learn More" links?

Please see the attachments "issue1.png" and "issue2.png".
Created attachment 8852484 [details]
issue2.png
Flags: needinfo?(jaws)
Hi Camelia, can you please file a bug for the DRM Content, Tracking Protection, and Data Choices ones? Let's skip the 11px one since it's close enough.
Flags: needinfo?(jaws)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #8)
> Hi Camelia, can you please file a bug for the DRM Content, Tracking
> Protection, and Data Choices ones? Let's skip the 11px one since it's close
> enough.

I filled bug 1352420. 
Marking this bug as VERIFIED FIXED.
Status: RESOLVED → VERIFIED
status-firefox54: fixed → verified
(Reporter)

Updated

4 months ago
Depends on: 1352420
No longer depends on: 1352420
You need to log in before you can comment on or make changes to this bug.