1330314 - Learn More links should only be 10px after the text

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

From page 7 of https://bugzilla.mozilla.org/attachment.cgi?id=8819509 (and specified more explicitly on slide 5 of https://bugzilla.mozilla.org/attachment.cgi?id=8819509

This was missed in bug 1324170.

Comment 1

[Ian Ferguson]

Attachment: Bug 1330314 - Reduce the inline-start margin for Learn More links to keep the link contextually closer.

Review commit: https://reviewboard.mozilla.org/r/106678/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106678/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8829678 [details]
Bug 1330314 - Reduce the inline-start margin for Learn More links to keep the link contextually closer.

https://reviewboard.mozilla.org/r/106678/#review107990

Please run 'hg histedit' and choose the 'mess' option to edit the commit message for your patch, then re-push it for review. Your commit message should describe what and why your patch is changing. It should also include the bug number at the beginning and the reviewer at the end. Once you do this we can get your patch landed in mozilla-central.

Your commit message is currently: "Bug 1330314 Adding adding 10px after the text for Learn More links. r?jaws"

Your commit message should be: "Bug 1330314 - Reduce the inline-start margin for Learn More links to keep the link contextually closer. r?jaws"

Comment 3

[Ian Ferguson]

Comment on attachment 8829678 [details]
Bug 1330314 - Reduce the inline-start margin for Learn More links to keep the link contextually closer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106678/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f43d635de8d
Reduce the inline-start margin for Learn More links to keep the link contextually closer. r=jaws

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8f43d635de8d

Comment 6

[Camelia Badau [:cbadau], Desktop Test Engineering]

Attachment: issue1.png

I've tested on Windows 7 x64, Ubuntu 14.04 x64 and Mac OS X 10.11 using latest Aurora 54.0a2 (2017-03-29) and I have one mention here: there is more than 10px between the text and the "Learn More" links: 
- under DRM Content (Content tab) - 18px
- under Notifications (Content tab) - 11px
- under Tracking (Privacy tab) - 18px
- under Data Choices (Advanced tab) - 38px/12px/61px

This is expected? 

Shouldn't we keep the same distance between the text and the "Learn More" links?

Please see the attachments "issue1.png" and "issue2.png".

Comment 7

[Camelia Badau [:cbadau], Desktop Test Engineering]

Attachment: issue2.png

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Hi Camelia, can you please file a bug for the DRM Content, Tracking Protection, and Data Choices ones? Let's skip the 11px one since it's close enough.

Comment 9

[Camelia Badau [:cbadau], Desktop Test Engineering]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #8)
> Hi Camelia, can you please file a bug for the DRM Content, Tracking
> Protection, and Data Choices ones? Let's skip the 11px one since it's close
> enough.

I filled bug 1352420. 
Marking this bug as VERIFIED FIXED.