1330503 - stylo: URL values in CSSStyleSheet.insertRule and rule.style.setProperty are not recognized correctly

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Xidorn Quan [:xidorn] UTC+10]

This seems to be a common failure pattern revealled by the style system tests. I'll investigate why this happens.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

So they are explicitly dropped because of lack of ParserContextExtraData [1].

Looking at the code, I guess we can probably put ParserContextExtraData to Stylesheet, so that we don't need to pass in that every time when we want to parse something.

[1] https://github.com/servo/servo/blob/f37aa1292706ebcf6727aea4ef30707d8e0e0569/components/style/values/specified/url.rs#L100-L105

Comment 2

[Bobby Holley (:bholley)]

(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #1)
> So they are explicitly dropped because of lack of ParserContextExtraData [1].

Yeah I've seen a lot of logging around that.
 
> Looking at the code, I guess we can probably put ParserContextExtraData to
> Stylesheet, so that we don't need to pass in that every time when we want to
> parse something.

Or the PerDocumentStyleData. Unless it differs between stylesheets?

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #2)
> > Looking at the code, I guess we can probably put ParserContextExtraData to
> > Stylesheet, so that we don't need to pass in that every time when we want to
> > parse something.
> 
> Or the PerDocumentStyleData. Unless it differs between stylesheets?

They are definitely different between stylesheets. We would probably need one in PerDocumentStyleData as well, for style elements and attributes.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Oh, probably no need for style elements, because they have their own stylesheet.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Now I successfully make it parse, but it seems inserting rule doesn't affect the computed value... probably need to investigate what happens in the restyler.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Hmmm, it fixes much fewer issues than I thought... I have a WIP solution, but given it's not that helpful, I decide not to complete it at this moment.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Attachment: WIP patch

Comment 8

[Bobby Holley (:bholley)]

Over to xidorn with the other url stuff.

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

I believe this has been fixed in some dependency of bug 1343964.

The remaining failures which marked with this bug is actually bug 1356494.