1331317 - Only enable pref "media.block-autoplay-until-in-foreground" on Nightly

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Alastor Wu [:alwu]]

According to the bug1262053 comment105, I would like to close the feature on Beta and Aurora, and only enable it on Nightly.

Re-enable the feature after the state is more stable and no any significant issue was found.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1331317 - only enable the pref 'media.block-autoplay-until-in-foreground' on Nightly.

Review commit: https://reviewboard.mozilla.org/r/104882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/104882/

Comment 2

[Alastor Wu [:alwu]]

Comment on attachment 8827055 [details]
Bug 1331317 - only enable the pref 'media.block-autoplay-until-in-foreground' on Nightly.

Approval Request Comment
[Feature/Bug causing the regression]: Close the pref about blocking autoplay media to fix the Amazon Prime video issue
[User impact if declined]: User can't watch Amazon Prime video correctly
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: This issue only happens on beta
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Close the pref means we won't do any extra thing to affect media playback
[String changes made/needed]: No

Comment 3

[Blake Wu [:bwu][:blakewu]]

Gerry, 
Need your help to approve on comment 2.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8827055 [details]
Bug 1331317 - only enable the pref 'media.block-autoplay-until-in-foreground' on Nightly.

https://reviewboard.mozilla.org/r/104882/#review105592

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba7efd1b9af9
only enable the pref 'media.block-autoplay-until-in-foreground' on Nightly. r=jwwang

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8827055 [details]
Bug 1331317 - only enable the pref 'media.block-autoplay-until-in-foreground' on Nightly.

Disable the feature so that the playback won't be broken on Amazon Prime video. Beta51+ & Aurora52+. Should be in 51 RC.

Florin, please help verify if bug 1262053 is fixed. Thanks.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d506e0d4d610

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b08685fc8276

Comment 9

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Moving the needinfo to Simona who is the current QA Owner for this feature. Once we get the Firefox 51 RC build tomorrow, we should be able to verify that the feature is only enabled in Nightly.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba7efd1b9af9

Comment 11

[Simona Badau, Desktop QA]

Verified as fixed using Firefox 51 RC candidate build 1 (Build ID: 20170116133120) on Windows 10 x64 bit, Ubuntu 16.04, and Mac OS X 10.11. 

To see more details about the exploratory testing that was done to confirm the preference was properly toggled, please consult the etherpad:
https://public.etherpad-mozilla.org/p/Bug1331317

Tomorrow, I'll continue with the verification on Aurora and Nightly.

Comment 12

[Simona Badau, Desktop QA]

Verified as fixed using the latest Firefox Developer Edition 52.0a2 (Build ID: 20170116004021) and the latest Nightly 53.0a1 (Build ID: 20170117030218) on Windows 10 x64, Ubuntu 16.06 x64, Mac OS X 10.11.

For more details, please see the etherpad:
https://public.etherpad-mozilla.org/p/Bug1331317