Only enable pref "media.block-autoplay-until-in-foreground" on Nightly

VERIFIED FIXED in Firefox 51

Status

()

VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: alwu, Assigned: alwu)

Tracking

Other Branch
mozilla53
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox51 verified, firefox52 verified, firefox53 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
According to the bug1262053 comment105, I would like to close the feature on Beta and Aurora, and only enable it on Nightly.

Re-enable the feature after the state is more stable and no any significant issue was found.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 years ago
Comment on attachment 8827055 [details]
Bug 1331317 - only enable the pref 'media.block-autoplay-until-in-foreground' on Nightly.

Approval Request Comment
[Feature/Bug causing the regression]: Close the pref about blocking autoplay media to fix the Amazon Prime video issue
[User impact if declined]: User can't watch Amazon Prime video correctly
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: This issue only happens on beta
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Close the pref means we won't do any extra thing to affect media playback
[String changes made/needed]: No
Attachment #8827055 - Flags: approval-mozilla-beta?
Attachment #8827055 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

2 years ago
Blocks: 1330963
Gerry, 
Need your help to approve on comment 2.
No longer blocks: 1330963
Flags: needinfo?(gchang)
Blocks: 1330963

Comment 4

2 years ago
mozreview-review
Comment on attachment 8827055 [details]
Bug 1331317 - only enable the pref 'media.block-autoplay-until-in-foreground' on Nightly.

https://reviewboard.mozilla.org/r/104882/#review105592
Attachment #8827055 - Flags: review?(jwwang) → review+

Comment 5

2 years ago
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba7efd1b9af9
only enable the pref 'media.block-autoplay-until-in-foreground' on Nightly. r=jwwang
(Assignee)

Updated

2 years ago
Blocks: 1330929
Comment on attachment 8827055 [details]
Bug 1331317 - only enable the pref 'media.block-autoplay-until-in-foreground' on Nightly.

Disable the feature so that the playback won't be broken on Amazon Prime video. Beta51+ & Aurora52+. Should be in 51 RC.

Florin, please help verify if bug 1262053 is fixed. Thanks.
Flags: needinfo?(gchang) → needinfo?(florin.mezei)
Attachment #8827055 - Flags: approval-mozilla-beta?
Attachment #8827055 - Flags: approval-mozilla-beta+
Attachment #8827055 - Flags: approval-mozilla-aurora?
Attachment #8827055 - Flags: approval-mozilla-aurora+

Updated

2 years ago
status-firefox51: --- → affected
status-firefox52: --- → affected

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/d506e0d4d610
status-firefox52: affected → fixed

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/b08685fc8276
status-firefox51: affected → fixed
Flags: qe-verify+
Moving the needinfo to Simona who is the current QA Owner for this feature. Once we get the Firefox 51 RC build tomorrow, we should be able to verify that the feature is only enabled in Nightly.
Flags: needinfo?(florin.mezei) → needinfo?(simona.marcu)

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ba7efd1b9af9
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Verified as fixed using Firefox 51 RC candidate build 1 (Build ID: 20170116133120) on Windows 10 x64 bit, Ubuntu 16.04, and Mac OS X 10.11. 

To see more details about the exploratory testing that was done to confirm the preference was properly toggled, please consult the etherpad:
https://public.etherpad-mozilla.org/p/Bug1331317

Tomorrow, I'll continue with the verification on Aurora and Nightly.
status-firefox51: fixed → verified
Flags: needinfo?(simona.marcu)
Verified as fixed using the latest Firefox Developer Edition 52.0a2 (Build ID: 20170116004021) and the latest Nightly 53.0a1 (Build ID: 20170117030218) on Windows 10 x64, Ubuntu 16.06 x64, Mac OS X 10.11.

For more details, please see the etherpad:
https://public.etherpad-mozilla.org/p/Bug1331317
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified
status-firefox53: fixed → verified
You need to log in before you can comment on or make changes to this bug.