The default bug view has changed. See this FAQ.

Add support for browserAction.onClicked

NEW
Assigned to

Status

()

Toolkit
WebExtensions: Android
P2
normal
2 months ago
a day ago

People

(Reporter: mattw, Assigned: mattw, NeedInfo)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [browserAction]triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(5 attachments)

(Assignee)

Description

2 months ago
MDN documentation: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/BrowserAction/onClicked

This bug will involve adding icons to the UI.
(Assignee)

Updated

13 days ago
Assignee: nobody → mwein
(Assignee)

Updated

13 days ago
Blocks: 1330159
(Assignee)

Updated

13 days ago
No longer blocks: 1331126
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 5

13 days ago
Actually, I'm going to clear review until I have tests written, because I think there are some edge cases I'm missing to support multiple browser actions.
(Assignee)

Updated

13 days ago
Attachment #8848217 - Flags: review?(mixedpuppy)
(Assignee)

Updated

13 days ago
Attachment #8848218 - Flags: review?(gbrown)
(Assignee)

Updated

13 days ago
Attachment #8848219 - Flags: review?(mixedpuppy)
(Assignee)

Updated

13 days ago
Attachment #8848220 - Flags: review?(lgreco)

Comment 6

12 days ago
mozreview-review
Comment on attachment 8848217 [details]
Bug 1331742 - Part 1 - Create and register browser_action.json

https://reviewboard.mozilla.org/r/121154/#review123162

::: mobile/android/components/extensions/schemas/browser_action.json:4
(Diff revision 1)
> +// Copyright (c) 2012 The Chromium Authors. All rights reserved.
> +// Use of this source code is governed by a BSD-style license that can be
> +// found in the LICENSE file.
> +

this old dog learned a new trick today.

hg cp from browser/components/extensions/schemas/browser_action.json

then make any changes necessary
Attachment #8848217 - Flags: review?(mixedpuppy)
(Assignee)

Comment 7

12 days ago
mozreview-review-reply
Comment on attachment 8848217 [details]
Bug 1331742 - Part 1 - Create and register browser_action.json

https://reviewboard.mozilla.org/r/121154/#review123162

> this old dog learned a new trick today.
> 
> hg cp from browser/components/extensions/schemas/browser_action.json
> 
> then make any changes necessary

+1
Attachment #8848217 - Flags: review?(mixedpuppy)
(Assignee)

Comment 8

4 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ce15e8e6c75825093bca247ab1bd579aba05dc0
(Assignee)

Comment 9

3 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=197df833f743716e5f3ff3bfd6e94dcc8dc26f88
(Assignee)

Comment 10

3 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2279f174441c75c1e95493276e7919210190298
(Assignee)

Comment 11

3 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=12a03bac95a70f786ba000d1681a127d05398946
(Assignee)

Comment 12

3 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0063125250cb10e511559b8134f986bcb4a2ce6
(Assignee)

Comment 13

3 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f41572ff5d9f9937384bc9d8658e0d7f2afc8cf
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 19

2 days ago
mozreview-review
Comment on attachment 8848218 [details]
Bug 1331742 - Part 2 - Create a module for managing browser actions similar to PageActions.jsm

https://reviewboard.mozilla.org/r/121156/#review126356

Sorry, I'm not comfortable reviewing these patches. Perhaps try :sebastian?

(I usually work on test infrastructure and test code these days.)
Attachment #8848218 - Flags: review?(gbrown)

Comment 20

2 days ago
mozreview-review
Comment on attachment 8848220 [details]
Bug 1331742 - Part 4 - Add a position property to keep track of the menu item's position instead of using the ID

https://reviewboard.mozilla.org/r/121160/#review126360
Attachment #8848220 - Flags: review?(gbrown)
(Assignee)

Comment 21

a day ago
No worries, thanks for the quick response. Sebastian, would you be comfortable reviewing Part 2 and Part 4?
Flags: needinfo?(s.kaspari)
You need to log in before you can comment on or make changes to this bug.