Closed Bug 1332845 Opened 4 years ago Closed 4 years ago

Intermittent dom/media/test/test_mediarecorder_principals.html | application crashed [@ mozilla::VideoTrackEncoder::AppendVideoSegment(mozilla::VideoSegment const&)] after Assertion failure: false, at dom/media/encoder/TrackEncoder.cpp:289

Categories

(Core :: Audio/Video: Recording, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- wontfix
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: pehrsons)

References

Details

(Keywords: assertion, crash, intermittent-failure)

Attachments

(2 files)

Assignee: nobody → pehrson
Rank: 35
Component: Audio/Video → Audio/Video: Recording
Priority: -- → P3
See Also: → 1333271
Any updates on this, Andreas? :)
Flags: needinfo?(pehrson)
I'm able to reproduce.
Status: NEW → ASSIGNED
Flags: needinfo?(pehrson)
Comment on attachment 8855841 [details]
Bug 1332845 - Remove direct listeners before ending track in TrackUnionStream.

https://reviewboard.mozilla.org/r/127722/#review130462
Attachment #8855841 - Flags: review?(rjesup) → review+
Comment on attachment 8855840 [details]
Bug 1332845 - Remove listeners before other cleanup in MediaRecorder.

https://reviewboard.mozilla.org/r/127720/#review130464
Attachment #8855840 - Flags: review?(rjesup) → review+
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/76e7f2698291
Remove listeners before other cleanup in MediaRecorder. r=jesup
https://hg.mozilla.org/integration/autoland/rev/9e998b5f1d08
Remove direct listeners before ending track in TrackUnionStream. r=jesup
https://hg.mozilla.org/mozilla-central/rev/76e7f2698291
https://hg.mozilla.org/mozilla-central/rev/9e998b5f1d08
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Thanks for fixing this! Please nominate it for Beta approval when you get a chance :)
Flags: needinfo?(pehrson)
Comment on attachment 8855840 [details]
Bug 1332845 - Remove listeners before other cleanup in MediaRecorder.

(In reply to Ryan VanderMeulen [:RyanVM] from comment #22)
> Thanks for fixing this! Please nominate it for Beta approval when you get a
> chance :)

Ah, I had the request written already. Was just waiting for a bit of Nightly coverage to answer that question below :-)


Approval Request Comment
[Feature/Bug causing the regression]: Bug 1332584 added the failing assert which gave discoverability. Root cause has been around for a very long time.
[User impact if declined]: Intermittent assertion failures in debug builds. No real impact in prod builds.
[Is this code covered by automated tests?]: Yes, both patches affect common code covered by a multitude of tests.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Both patches are short, simple (only changing order of code) and easy to reason about.
[String changes made/needed]: None

This approval request applies to both patches on this bug.
Flags: needinfo?(pehrson)
Attachment #8855840 - Flags: approval-mozilla-beta?
See Also: 1333271
Duplicate of this bug: 1333271
Comment on attachment 8855840 [details]
Bug 1332845 - Remove listeners before other cleanup in MediaRecorder.

Fix an intermittent failure. Beta54+. Should be in 54 beta 3.
Attachment #8855840 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Duplicate of this bug: 1354841
Duplicate of this bug: 1355857
Duplicate of this bug: 1356113
You need to log in before you can comment on or make changes to this bug.