1332845 - Intermittent dom/media/test/test_mediarecorder_principals.html | application crashed [@ mozilla::VideoTrackEncoder::AppendVideoSegment(mozilla::VideoSegment const&)] after Assertion failure: false, at dom/media/encoder/TrackEncoder.cpp:289

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=70952111&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64-debug/1485006805/mozilla-inbound_yosemite_r7-debug_test-mochitest-media-bm134-tests1-macosx-build59.txt.gz

Comment 1

[Intermittent Failures Robot]

9 failures in 749 pushes (0.012 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 6
* try: 1
* mozilla-aurora: 1
* autoland: 1

Platform breakdown:
* osx-10-10: 5
* linux32: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-01-23&endday=2017-01-29&tree=all

Comment 2

[Intermittent Failures Robot]

10 failures in 733 pushes (0.014 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-inbound: 5
* autoland: 4
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 7
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-01-30&endday=2017-02-05&tree=all

Comment 3

[Intermittent Failures Robot]

25 failures in 836 pushes (0.03 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* autoland: 9
* mozilla-inbound: 7
* mozilla-central: 4
* mozilla-aurora: 3
* try: 2

Platform breakdown:
* osx-10-10: 19
* linux32: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-02-06&endday=2017-02-12&tree=all

Comment 4

[Intermittent Failures Robot]

10 failures in 833 pushes (0.012 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* try: 3
* mozilla-inbound: 3
* autoland: 3
* mozilla-aurora: 1

Platform breakdown:
* osx-10-10: 8
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-02-13&endday=2017-02-19&tree=all

Comment 5

[Intermittent Failures Robot]

11 failures in 812 pushes (0.014 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* autoland: 6
* mozilla-aurora: 2
* try: 1
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* linux32: 6
* osx-10-10: 5

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-02-20&endday=2017-02-26&tree=all

Comment 6

[Intermittent Failures Robot]

12 failures in 783 pushes (0.015 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* mozilla-inbound: 4
* autoland: 3
* mozilla-central: 2
* graphics: 2
* mozilla-aurora: 1

Platform breakdown:
* osx-10-10: 8
* linux32: 3
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-02-27&endday=2017-03-05&tree=all

Comment 7

[Intermittent Failures Robot]

20 failures in 790 pushes (0.025 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 8
* autoland: 6
* graphics: 3
* mozilla-central: 2
* try: 1

Platform breakdown:
* osx-10-10: 15
* linux32: 4
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-03-06&endday=2017-03-12&tree=all

Comment 8

[Intermittent Failures Robot]

11 failures in 777 pushes (0.014 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 5
* mozilla-inbound: 3
* mozilla-central: 2
* graphics: 1

Platform breakdown:
* osx-10-10: 11

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-03-13&endday=2017-03-19&tree=all

Comment 9

[Intermittent Failures Robot]

7 failures in 898 pushes (0.008 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 5
* mozilla-inbound: 2

Platform breakdown:
* osx-10-10: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-03-20&endday=2017-03-26&tree=all

Comment 10

[Intermittent Failures Robot]

18 failures in 845 pushes (0.021 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 11
* mozilla-inbound: 5
* mozilla-beta: 1
* graphics: 1

Platform breakdown:
* osx-10-10: 15
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-03-27&endday=2017-04-02&tree=all

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Any updates on this, Andreas? :)

Comment 12

[Andreas Pehrson [:pehrsons]]

I'm able to reproduce.

Comment 13

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1332845 - Remove listeners before other cleanup in MediaRecorder.

There was an indirect race from destroying this MediaInputPort before removing
the direct listener.

Review commit: https://reviewboard.mozilla.org/r/127720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/127720/

Comment 14

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1332845 - Remove direct listeners before ending track in TrackUnionStream.

There was a race where ending the track before removing the direct listener here,
allowed the source to append more data (notifying the direct listener)
after the consumer had been notified of the ending track.

Review commit: https://reviewboard.mozilla.org/r/127722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/127722/

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8855841 [details]
Bug 1332845 - Remove direct listeners before ending track in TrackUnionStream.

https://reviewboard.mozilla.org/r/127722/#review130462

Comment 16

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8855840 [details]
Bug 1332845 - Remove listeners before other cleanup in MediaRecorder.

https://reviewboard.mozilla.org/r/127720/#review130464

Comment 17

[Intermittent Failures Robot]

13 failures in 867 pushes (0.015 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 6
* mozilla-beta: 2
* mozilla-aurora: 2
* autoland: 2
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 12
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-04-03&endday=2017-04-09&tree=all

Comment 18

[Intermittent Failures Robot]

13 failures in 894 pushes (0.015 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 10
* mozilla-central: 2
* mozilla-inbound: 1

Platform breakdown:
* osx-10-10: 13

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-04-10&endday=2017-04-16&tree=all

Comment 19

[Intermittent Failures Robot]

9 failures in 817 pushes (0.011 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 5
* mozilla-inbound: 2
* mozilla-release: 1
* graphics: 1

Platform breakdown:
* osx-10-10: 6
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332845&startday=2017-04-17&endday=2017-04-23&tree=all

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76e7f2698291
Remove listeners before other cleanup in MediaRecorder. r=jesup
https://hg.mozilla.org/integration/autoland/rev/9e998b5f1d08
Remove direct listeners before ending track in TrackUnionStream. r=jesup

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76e7f2698291
https://hg.mozilla.org/mozilla-central/rev/9e998b5f1d08

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Thanks for fixing this! Please nominate it for Beta approval when you get a chance :)

Comment 23

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8855840 [details]
Bug 1332845 - Remove listeners before other cleanup in MediaRecorder.

(In reply to Ryan VanderMeulen [:RyanVM] from comment #22)
> Thanks for fixing this! Please nominate it for Beta approval when you get a
> chance :)

Ah, I had the request written already. Was just waiting for a bit of Nightly coverage to answer that question below :-)


Approval Request Comment
[Feature/Bug causing the regression]: Bug 1332584 added the failing assert which gave discoverability. Root cause has been around for a very long time.
[User impact if declined]: Intermittent assertion failures in debug builds. No real impact in prod builds.
[Is this code covered by automated tests?]: Yes, both patches affect common code covered by a multitude of tests.
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Both patches are short, simple (only changing order of code) and easy to reason about.
[String changes made/needed]: None

This approval request applies to both patches on this bug.

Comment 25

[Gerry Chang [:gchang]]

Comment on attachment 8855840 [details]
Bug 1332845 - Remove listeners before other cleanup in MediaRecorder.

Fix an intermittent failure. Beta54+. Should be in 54 beta 3.

Comment 26

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/43dc349fa417
https://hg.mozilla.org/releases/mozilla-beta/rev/74f3c44c94f2