Closed Bug 1333395 Opened 7 years ago Closed 5 months ago

Consider support for containers sort order

Categories

(Firefox :: Security, defect, P5)

52 Branch
defect

Tracking

()

RESOLVED FIXED
123 Branch
Tracking Status
firefox-esr115 --- wontfix
firefox57 --- wontfix
firefox121 --- wontfix
firefox122 --- wontfix
firefox123 --- fixed

People

(Reporter: jkt, Assigned: me)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-complete, Whiteboard: [domsecurity-backlog])

Attachments

(2 files)

Currently containers don't have the ability to be sorted in the menu and other UI features that we use.

This should also be used in the test pilot extension if the support is added before that launches (especially as this has a tab sorting feature which is sorted by the menu order). Adding in the ability for extensions to also be sorted would also be good.

This was requested here: https://www.reddit.com/r/firefox/comments/5ps7la/any_way_to_reorder_tab_containers/
Aren't the UI issues handled in the "Firefox::Security" component rather than "DOM: Security"?
Flags: needinfo?(jkt)
OS: Linux → All
Priority: -- → P5
Hardware: x86_64 → All
Whiteboard: [domsecurity-backlog]
Sorry Dan I missed the needinfo here. We have been dumping all containers things in "DOM: Security". I will move this there for now and see what happens.
Component: DOM: Security → Security
Flags: needinfo?(jkt)
Product: Core → Firefox
To maybe state the obvious, the current manual workaround is to open `$PROFILE/containers.json` and reorder array entries.
Assignee: nobody → jonathan
Status: NEW → ASSIGNED

The bug assignee didn't login in Bugzilla in the last 7 months.
:sgalich, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: jonathan → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(sgalich)
Flags: needinfo?(sgalich)

(In reply to Konrad Gądek from comment #4)

To maybe state the obvious, the current manual workaround is to open
$PROFILE/containers.json and reorder array entries.

Thank you. Although the general workaround of "open the profile and change something" might have been obvious, I was unsure what specific file I would have to change.
Now to see if that still works after 5 years of updates and with Mozilla's ever-increasing tech debt...

+1 I've also this issue.

Plus, the order isn't the same in firefox preferences and plugin preferences. Cf https://imgur.com/a/fUjbU19

Severity: normal → S3

The severity field for this bug is relatively low, S3. However, the bug has 10 votes.
:serg, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Flags: needinfo?(sgalich)

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Flags: needinfo?(sgalich)
Assignee: nobody → contact
Assignee: contact → nobody
  • Based off patch by jkt
  • Integrate suggestions from robwu (support bulk move, return type, json)
  • Add tests for reordering identities
  • position is index:
    a) in resulting array
    b) ignoring non-public identities
  • No observer notification as no identities were added/removed/modified
  • Rob Wu was reviewer on previous patch

(a) is important when moving past current position:
Moving 0 to position=2 in [0 1 2 3] means [1 2 0 3] if position is in
resulting array, but [1 0 2 3] if position is index in starting array.
This is coherent with the interpretation of the tabs.move() parameter

(b) skipping non-public identities means:
Moving 0 to position=2 in [0 * * 1 2 3] (with * private identities)
results in [* * 1 2 0 3] and not [* * 0 1 2 3]

Assignee: nobody → me
Status: NEW → ASSIGNED
Blocks: 1731313

I'm putting dev-doc-needed here so that the feature can be documented on MDN: a new article for contextualIdentities.move, BCD entry and developer release notes.

I'll reach out to our tech writer (Richard) to make sure that he can see this bug despite it not being in the WebExtensions product.

Keywords: dev-doc-needed
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/07730fb358b7
API to move contextual identities r=robwu
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
Duplicate of this bug: 1842086

Documentation provided in:

  • (MDN) Add contextualIdentities.move #31191
  • (BCD) Adding data for contextualIdentities.move #21702
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: