1333395 - Consider support for containers sort order

Status: RESOLVED FIXED

(Firefox :: Security, defect, P5)

Description

[Jonathan Kingston [:jkt] he/him]

Currently containers don't have the ability to be sorted in the menu and other UI features that we use.

This should also be used in the test pilot extension if the support is added before that launches (especially as this has a tab sorting feature which is sorted by the menu order). Adding in the ability for extensions to also be sorted would also be good.

This was requested here: https://www.reddit.com/r/firefox/comments/5ps7la/any_way_to_reorder_tab_containers/

Comment 1

[Daniel Veditz [:dveditz]]

Aren't the UI issues handled in the "Firefox::Security" component rather than "DOM: Security"?

Comment 2

[Jonathan Kingston [:jkt] he/him]

Sorry Dan I missed the needinfo here. We have been dumping all containers things in "DOM: Security". I will move this there for now and see what happens.

Comment 3

[Firefox Bug Husbandry Bot]

Bulk change per https://bugzilla.mozilla.org/show_bug.cgi?id=1401020

Comment 4

[Konrad Gądek]

To maybe state the obvious, the current manual workaround is to open `$PROFILE/containers.json` and reorder array entries.

Comment 5

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1333395 - WIP example API of moving the contextual identities. Tests needed etc. Perhaps arrays should be supported like tab.move.

Depends on D103531

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:sgalich, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Twisted Code]

(In reply to Konrad Gądek from comment #4)

To maybe state the obvious, the current manual workaround is to open
$PROFILE/containers.json and reorder array entries.

Thank you. Although the general workaround of "open the profile and change something" might have been obvious, I was unsure what specific file I would have to change.
Now to see if that still works after 5 years of updates and with Mozilla's ever-increasing tech debt...

Comment 8

[kud]

+1 I've also this issue.

Plus, the order isn't the same in firefox preferences and plugin preferences. Cf https://imgur.com/a/fUjbU19

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 10 votes.
:serg, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 10

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Comment 11

[Cimbali]

Attachment: Bug 1333395 - API to move contextual identities r=robwu

• Based off patch by jkt
• Integrate suggestions from robwu (support bulk move, return type, json)
• Add tests for reordering identities
• position is index:
  a) in resulting array
  b) ignoring non-public identities
• No observer notification as no identities were added/removed/modified
• Rob Wu was reviewer on previous patch

(a) is important when moving past current position:
Moving 0 to position=2 in [0 1 2 3] means [1 2 0 3] if position is in
resulting array, but [1 0 2 3] if position is index in starting array.
This is coherent with the interpretation of the tabs.move() parameter

(b) skipping non-public identities means:
Moving 0 to position=2 in [0 * * 1 2 3] (with * private identities)
results in [* * 1 2 0 3] and not [* * 0 1 2 3]

Comment 12

[Rob Wu [:robwu]]

I'm putting dev-doc-needed here so that the feature can be documented on MDN: a new article for contextualIdentities.move, BCD entry and developer release notes.

I'll reach out to our tech writer (Richard) to make sure that he can see this bug despite it not being in the WebExtensions product.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07730fb358b7
API to move contextual identities r=robwu

Comment 14

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/07730fb358b7

Comment 16

[rbloor]

Documentation provided in:

• (MDN) Add contextualIdentities.move #31191
• (BCD) Adding data for contextualIdentities.move #21702