add BUG_COMPONENT to intl/* files

RESOLVED FIXED in Firefox 54

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

unspecified
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

there are many files in the intl/* directory tree, most of these look to be imported from other tools, and from looking at it, all of the files (source/tests) belong to Core::Internationalization.

I see these files:
*
build/*
chardat/*
hyphenation/*
icu/*
icu-patches/*
locale/*
locales/*
lwbrk/*
strres/*
tzdata/*
uconv/*
unicharutil/*

possibly some of these directories or related files might live in other bugzilla components, from my best guess, I believe these all belong in Core::Internationalization.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8829900 - Flags: review?(m_kato)
Comment on attachment 8829900 [details] [diff] [review]
annotate moz.build with BUG_COMPONENT for intl/* files

Review of attachment 8829900 [details] [diff] [review]:
-----------------------------------------------------------------

icu, icu-patches, tzdata are Javascript::Internatinalization API (ex. bug 1323254 and bug 1321030).  Others are OK.
Attachment #8829900 - Flags: review?(m_kato)
thanks for the feedback, I have implemented what you asked for and here is what the output will look like:

$ ./mach file-info bugzilla-component intl/**
Core :: Internationalization
  intl/build
  intl/chardet
  intl/hyphenation
  intl/icu_sources_data.py
  intl/locale
  intl/locales
  intl/lwbrk
  intl/moz.build
  intl/strres
  intl/uconv
  intl/unicharutil
  intl/update-icu.sh
  intl/update-tzdata.sh
Core :: JavaScript: Internationalization API
  intl/icu
  intl/icu-patches
  intl/tzdata
Attachment #8829900 - Attachment is obsolete: true
Attachment #8830244 - Flags: review?(m_kato)
intl/update-{icu,tzdata}.sh should be Core :: JS: Internationalization, same as intl/icu{,-patches} and intl/tzdata.  They tend to get touched when icu/tzdata updates happen, and those generally are driven by JS people.

intl/icu_sources_data.py basically generates a moz.build system for ICU, and Ted (?) wrote it initially, and that's really much more Core :: Build Config than anything in either specifically-internationalization component.
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4daf122b00ce
add BUG_COMPONENT to intl/* files. r=m_kato
Joel, could you update fix per comment #4?
sorry for this, I had mixed my patches up and had landed this patch without proper review or without the final edits from comment 4.

I have attached the patch to address comment 4, you can see that what I landed had icu, icu-patches, tzdata set to js:internationalization api- so we are close.
Attachment #8830687 - Flags: review?(m_kato)
https://hg.mozilla.org/mozilla-central/rev/4daf122b00ce
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Attachment #8830244 - Flags: review?(m_kato) → review+
Attachment #8830687 - Flags: review?(m_kato) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a321a80847c9
add BUG_COMPONENT to intl/* files. r=m_kato
You need to log in before you can comment on or make changes to this bug.