1333451 - add BUG_COMPONENT to intl/* files

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

there are many files in the intl/* directory tree, most of these look to be imported from other tools, and from looking at it, all of the files (source/tests) belong to Core::Internationalization.

I see these files:
*
build/*
chardat/*
hyphenation/*
icu/*
icu-patches/*
locale/*
locales/*
lwbrk/*
strres/*
tzdata/*
uconv/*
unicharutil/*

possibly some of these directories or related files might live in other bugzilla components, from my best guess, I believe these all belong in Core::Internationalization.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: annotate moz.build with BUG_COMPONENT for intl/* files

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8829900 [details] [diff] [review]
annotate moz.build with BUG_COMPONENT for intl/* files

Review of attachment 8829900 [details] [diff] [review]:
-----------------------------------------------------------------

icu, icu-patches, tzdata are Javascript::Internatinalization API (ex. bug 1323254 and bug 1321030).  Others are OK.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: annotate moz.build with BUG_COMPONENT for intl/* files

thanks for the feedback, I have implemented what you asked for and here is what the output will look like:

$ ./mach file-info bugzilla-component intl/**
Core :: Internationalization
  intl/build
  intl/chardet
  intl/hyphenation
  intl/icu_sources_data.py
  intl/locale
  intl/locales
  intl/lwbrk
  intl/moz.build
  intl/strres
  intl/uconv
  intl/unicharutil
  intl/update-icu.sh
  intl/update-tzdata.sh
Core :: JavaScript: Internationalization API
  intl/icu
  intl/icu-patches
  intl/tzdata

Comment 4

[Jeff Walden [:Waldo]]

intl/update-{icu,tzdata}.sh should be Core :: JS: Internationalization, same as intl/icu{,-patches} and intl/tzdata.  They tend to get touched when icu/tzdata updates happen, and those generally are driven by JS people.

intl/icu_sources_data.py basically generates a moz.build system for ICU, and Ted (?) wrote it initially, and that's really much more Core :: Build Config than anything in either specifically-internationalization component.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4daf122b00ce
add BUG_COMPONENT to intl/* files. r=m_kato

Comment 6

[Makoto Kato [:m_kato]]

Joel, could you update fix per comment #4?

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: annotate moz.build with BUG_COMPONENT for intl/* files (from comment 4)

sorry for this, I had mixed my patches up and had landed this patch without proper review or without the final edits from comment 4.

I have attached the patch to address comment 4, you can see that what I landed had icu, icu-patches, tzdata set to js:internationalization api- so we are close.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4daf122b00ce

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a321a80847c9
add BUG_COMPONENT to intl/* files. r=m_kato

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a321a80847c9