1333934 - Transform layer geometry only once

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Miko Mynttinen]

The transformation of layer geometry is done multiple times when there are nested ContainerLayers. This leads to invalid geometry in some cases.

Comment 1

[Miko Mynttinen]

Attachment: Bug 1333934 - Transform layer geometry only once

Review commit: https://reviewboard.mozilla.org/r/107298/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107298/

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8830548 [details]
Bug 1333934 - Transform layer geometry only once

https://reviewboard.mozilla.org/r/107298/#review108422

Comment 3

[Miko Mynttinen]

Comment on attachment 8830548 [details]
Bug 1333934 - Transform layer geometry only once

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/107298/diff/1-2/

Comment 4

[Miko Mynttinen]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7687f24777afa49c6a1cf885759f07033ad7f674

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3fc19cd30d8
Transform layer geometry only once r=mattwoodrow

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a3fc19cd30d8

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Miko, can you request uplift in this bug also since you mention it should go with bug 1335159 to aurora?

Comment 8

[Miko Mynttinen]

Comment on attachment 8830548 [details]
Bug 1333934 - Transform layer geometry only once

Approval Request Comment
[Feature/Bug causing the regression]: Plane splitting implementation for OpenGL (bug 1286716, bug 689498)
[User impact if declined]: Webpages with elements that have nested CSS 3D transforms might show incorrectly.
[Is this code covered by automated tests?]: Yes, the patch adds a reftest for the specific problem encountered. Also the previous reftest suite testing 3D CSS transforms covers this code and passes.
[Has the fix been verified in Nightly?]: Yes, I have verified that the fix works in Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: Optional - there is an automated reftest. Manual testing can be done by visiting http://www.simulationcurriculum.com/ and comparing the carousel transition with other browsers. Previously the last two stripes of the transition animation were rotating incorrectly.
[List of other uplifts needed for the feature/fix]: Bug 1335159
[Is the change risky?]: Medium.
[Why is the change risky/not risky?]: Similarly to bug 1335159, this change affects all the CSS 3D transforms.
[String changes made/needed]: None.

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8830548 [details]
Bug 1333934 - Transform layer geometry only once

This is required to fix bug 1335159. Aurora53+.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e525df4d6a74