1334037 - [Form Autofill] Support name fields in profiles

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[Luke Chang [:lchang] (inactive)]

Let's figure out how to deal with the format of names in profiles.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Bug 1334037 - [Form Autofill] Support name fields in profiles.

Review commit: https://reviewboard.mozilla.org/r/125008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125008/

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8852836 [details]
Bug 1334037 - [Form Autofill] Support name fields in profiles.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125008/diff/1-2/

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8852836 [details]
Bug 1334037 - [Form Autofill] Support name fields in profiles.

https://reviewboard.mozilla.org/r/125008/#review136644

::: browser/extensions/formautofill/ProfileAutoCompleteResult.jsm:132
(Diff revision 2)
> +        matching = allFieldNames.some(
> +          fieldName => possibleNameFields.includes(fieldName));

Put this all on one line since I think it should be <100 characters and more readable

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8852836 [details]
Bug 1334037 - [Form Autofill] Support name fields in profiles.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125008/diff/2-3/

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8852836 [details]
Bug 1334037 - [Form Autofill] Support name fields in profiles.

https://reviewboard.mozilla.org/r/125008/#review136644

> Put this all on one line since I think it should be <100 characters and more readable

Got it. Thanks for the review.

Comment 6

[Luke Chang [:lchang] (inactive)]

This bug focuses on "given-name", "additional-name" and "family-name" attributes only. I'll implement the "name" attribute in bug 1359892.

Comment 7

[Mozilla Autoland]

hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 7 changes to 7 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Pushing to an APPROVAL REQUIRED tree requires your top changeset comment to include: a=... (or, more accurately, a\S*=...)
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.a_treeclosure hook failed
abort: push failed on remote

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/052a1bf45675
[Form Autofill] Support name fields in profiles. r=MattN

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/052a1bf45675