Closed Bug 1334037 Opened 4 years ago Closed 4 years ago

[Form Autofill] Support name fields in profiles

Categories

(Toolkit :: Form Manager, defect, P3)

Product:
Toolkit
Component:
Form Manager
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: lchang, Assigned: lchang)

References

(Blocks 1 open bug)

Details

(Whiteboard: [form autofill:M2])

Attachments

(1 file)

Bug 1334037 - [Form Autofill] Support name fields in profiles.
59 bytes, text/x-review-board-request
MattN
: review+
Details 
Let's figure out how to deal with the format of names in profiles.
Whiteboard: [form autofill:MVP] → [form autofill:M2]
Assignee: nobody → lchang
Depends on: 1348751
Comment on attachment 8852836 [details]
Bug 1334037 - [Form Autofill] Support name fields in profiles.

https://reviewboard.mozilla.org/r/125008/#review136644

::: browser/extensions/formautofill/ProfileAutoCompleteResult.jsm:132
(Diff revision 2)
> +        matching = allFieldNames.some(
> +          fieldName => possibleNameFields.includes(fieldName));

Put this all on one line since I think it should be <100 characters and more readable
Attachment #8852836 - Flags: review?(MattN+bmo) → review+
Comment on attachment 8852836 [details]
Bug 1334037 - [Form Autofill] Support name fields in profiles.

https://reviewboard.mozilla.org/r/125008/#review136644

> Put this all on one line since I think it should be <100 characters and more readable

Got it. Thanks for the review.
This bug focuses on "given-name", "additional-name" and "family-name" attributes only. I'll implement the "name" attribute in bug 1359892.
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 7 changes to 7 files
remote: 
remote: 
remote: ************************** ERROR ****************************
remote: Pushing to an APPROVAL REQUIRED tree requires your top changeset comment to include: a=... (or, more accurately, a\S*=...)
remote: *************************************************************
remote: 
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.a_treeclosure hook failed
abort: push failed on remote
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/052a1bf45675
[Form Autofill] Support name fields in profiles. r=MattN
https://hg.mozilla.org/mozilla-central/rev/052a1bf45675
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1362584
You need to log in before you can comment on or make changes to this bug.