Closed
Bug 1362584
Opened 8 years ago
Closed 8 years ago
Add autofill name fields to the management/preferences UI
Categories
(Toolkit :: Form Manager, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [form autofill:M2])
Attachments
(2 files)
|
59 bytes,
text/x-review-board-request
|
scottwu
:
review+
|
Details |
|
3.20 KB,
patch
|
Details | Diff | Splinter Review |
We support names in storage now (bug 1334037) so we should add the UI for it.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8865057 [details] Bug 1362584 - Show autofill name fields in the management/preferences UI https://reviewboard.mozilla.org/r/136726/#review139798 Looks good. However we've JUST landed the test cases for edit profile dialog (bug 1347186), so the name fields should be added to `browser_editProfileDialog.js`.
Attachment #8865057 -
Flags: review?(scwwu) → review+
|
|
||
Comment 4•8 years ago
|
||
Fixes test cases for edit profile dialog.
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/60716c07ebb9 Show autofill name fields in the management/preferences UI r=scottwu
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/263cb1626257 Follow-up eslint fix for fieldValue no-unused-vars.
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/60716c07ebb9 https://hg.mozilla.org/mozilla-central/rev/263cb1626257
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•