1334964 - mozapps/skin/aboutNetworking.css uses float: inline-start, will cause browser_parsable_css.js to permafail on Gecko 53 merge to beta on March 6th

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Phil Ringnalda (:philor)]

Same story as bug 1334956, no float: inline-* on Gecko 53 once it hits beta so both browser_parsable_css.js and the actual use of inline-start will begin to fail when 53 merges to beta on March 6th.

[Tracking Requested - why for this release]: permaorange, closed tree, wailing and gnashing of teeth.

Comment 1

[Tomer Cohen :tomer]

Attachment: Bug 1334964 - mozapps/skin/aboutNetworking.css uses float: inline-start

Review commit: https://reviewboard.mozilla.org/r/108222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108222/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8831675 [details]
Bug 1334964 - mozapps/skin/aboutNetworking.css uses float: inline-start

https://reviewboard.mozilla.org/r/108222/#review109338

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2b34e5ebd80
mozapps/skin/aboutNetworking.css uses float: inline-start r=jaws

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e2b34e5ebd80

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora approval on this at your earliest convenience :)

Comment 6

[Tomer Cohen :tomer]

Comment on attachment 8831675 [details]
Bug 1334964 - mozapps/skin/aboutNetworking.css uses float: inline-start

Approval Request Comment
[Feature/Bug causing the regression]: bug 902596
[User impact if declined]: test failures
[Is this code covered by automated tests?]: no, but it cause failures due to unimplemented keywords.  
[Has the fix been verified in Nightly?]: yes.
[Needs manual test from QE? If yes, steps to reproduce]: probably not
[List of other uplifts needed for the feature/fix]: no dependencies beside bug 902596 which this patch fix.
[Is the change risky?]: not too much.
[Why is the change risky/not risky?]: Just backporting CSS code to use :dir().
[String changes made/needed]:

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8831675 [details]
Bug 1334964 - mozapps/skin/aboutNetworking.css uses float: inline-start

Fix test failures. Aurora53+.

Comment 9

[Gerry Chang [:gchang]]

Track 53+ as this will happen when merging to mozilla-beta.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b6b1c659a339