Closed
Bug 1336043
Opened 7 years ago
Closed 7 years ago
close() should be in DedicatedWorkerGlobalScope and SharedWorkerGlobalScope only
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: baku, Assigned: baku, NeedInfo)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
7.91 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8832825 -
Flags: review?(bkelly)
Comment 2•7 years ago
|
||
Comment on attachment 8832825 [details] [diff] [review] close.patch Review of attachment 8832825 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8832825 -
Flags: review?(bkelly) → review+
Comment 3•7 years ago
|
||
This is a compat fix for service workers. We used to have a self.close() in the SW that always threw, but after this patch we will not.
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bf20544a7385 close() should be in DedicatedWorkerGlobalScope and SharedWorkerGlobalScope only, r=bkelly
Comment 5•7 years ago
|
||
Backed out for failing wpt interfaces.worker.html: https://hg.mozilla.org/integration/mozilla-inbound/rev/d28b08ef0a0ad6fe4447983d87af0106ca1cc90a Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=bf20544a7385ff761ba0da45fb4996153d88025f Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=73939413&repo=mozilla-inbound [task 2017-02-02T16:23:06.373627Z] 16:23:06 INFO - TEST-START | /workers/interfaces.worker.html [task 2017-02-02T16:23:06.997746Z] 16:23:06 INFO - [task 2017-02-02T16:23:06.997867Z] 16:23:06 INFO - TEST-PASS | /workers/interfaces.worker.html | EventTarget interface: operation removeEventListener(DOMString,EventListener,boolean) - {} [task 2017-02-02T16:23:06.997912Z] 16:23:06 INFO - {} [task 2017-02-02T16:23:06.997978Z] 16:23:06 INFO - TEST-PASS | /workers/interfaces.worker.html | EventTarget interface: operation dispatchEvent(Event) - {} [task 2017-02-02T16:23:06.998016Z] 16:23:06 INFO - {} [task 2017-02-02T16:23:06.998086Z] 16:23:06 INFO - TEST-PASS | /workers/interfaces.worker.html | EventListener interface: existence and properties of interface object - {} [task 2017-02-02T16:23:06.998123Z] 16:23:06 INFO - {} [task 2017-02-02T16:23:06.998194Z] 16:23:06 INFO - TEST-PASS | /workers/interfaces.worker.html | WorkerGlobalScope interface: existence and properties of interface object - {} [task 2017-02-02T16:23:06.998230Z] 16:23:06 INFO - {} [task 2017-02-02T16:23:06.998291Z] 16:23:06 INFO - TEST-PASS | /workers/interfaces.worker.html | WorkerGlobalScope interface object length - {} [task 2017-02-02T16:23:06.998656Z] 16:23:06 INFO - {} [task 2017-02-02T16:23:06.999011Z] 16:23:06 INFO - TEST-PASS | /workers/interfaces.worker.html | WorkerGlobalScope interface object name - {} [task 2017-02-02T16:23:06.999348Z] 16:23:06 INFO - {} [task 2017-02-02T16:23:06.999729Z] 16:23:06 INFO - TEST-PASS | /workers/interfaces.worker.html | WorkerGlobalScope interface: existence and properties of interface prototype object - {} [task 2017-02-02T16:23:07.000105Z] 16:23:06 INFO - {} [task 2017-02-02T16:23:07.000547Z] 16:23:07 INFO - TEST-PASS | /workers/interfaces.worker.html | WorkerGlobalScope interface: existence and properties of interface prototype object's "constructor" property - {} [task 2017-02-02T16:23:07.000889Z] 16:23:07 INFO - {} [task 2017-02-02T16:23:07.001254Z] 16:23:07 INFO - TEST-PASS | /workers/interfaces.worker.html | WorkerGlobalScope interface: attribute self - {} [task 2017-02-02T16:23:07.001585Z] 16:23:07 INFO - {} [task 2017-02-02T16:23:07.001985Z] 16:23:07 INFO - TEST-PASS | /workers/interfaces.worker.html | WorkerGlobalScope interface: attribute location - {} [task 2017-02-02T16:23:07.002401Z] 16:23:07 INFO - {} [task 2017-02-02T16:23:07.002798Z] 16:23:07 INFO - TEST-UNEXPECTED-FAIL | /workers/interfaces.worker.html | WorkerGlobalScope interface: operation close() - assert_own_property: interface prototype object missing non-static operation expected property "close" missing [task 2017-02-02T16:23:07.003171Z] 16:23:07 INFO - IdlInterface.prototype.test_member_operation/<@http://web-platform.test:8000/resources/idlharness.js:1261:13 [task 2017-02-02T16:23:07.003528Z] 16:23:07 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20 [task 2017-02-02T16:23:07.003892Z] 16:23:07 INFO - IdlInterface.prototype.test_member_operation@http://web-platform.test:8000/resources/idlharness.js:1213:5 [task 2017-02-02T16:23:07.004271Z] 16:23:07 INFO - IdlInterface.prototype.test_members@http://web-platform.test:8000/resources/idlharness.js:1440:21 [task 2017-02-02T16:23:07.004630Z] 16:23:07 INFO - IdlInterface.prototype.test@http://web-platform.test:8000/resources/idlharness.js:748:5 [task 2017-02-02T16:23:07.004982Z] 16:23:07 INFO - IdlArray.prototype.test@http://web-platform.test:8000/resources/idlharness.js:398:9 [task 2017-02-02T16:23:07.005344Z] 16:23:07 INFO - request.onload@http://web-platform.test:8000/workers/interfaces.worker.js:16:3 [task 2017-02-02T16:23:07.005701Z] 16:23:07 INFO - EventHandlerNonNull*@http://web-platform.test:8000/workers/interfaces.worker.js:7:1 [task 2017-02-02T16:23:07.008391Z] 16:23:07 INFO -
Flags: needinfo?(amarchesini)
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/eefc0b77e8cd close() should be in DedicatedWorkerGlobalScope and SharedWorkerGlobalScope only, r=bkelly
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4d159a0c8114 close() should be in DedicatedWorkerGlobalScope and SharedWorkerGlobalScope only, r=me
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eefc0b77e8cd https://hg.mozilla.org/mozilla-central/rev/4d159a0c8114
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment 10•7 years ago
|
||
To document this I have: Added new pages for Dedicated/SharedWorkerGlobalScope.close, updated support info, and added notes to explain: https://developer.mozilla.org/en-US/docs/Web/API/DedicatedWorkerGlobalScope https://developer.mozilla.org/en-US/docs/Web/API/DedicatedWorkerGlobalScope/close https://developer.mozilla.org/en-US/docs/Web/API/SharedWorkerGlobalScope https://developer.mozilla.org/en-US/docs/Web/API/SharedWorkerGlobalScope/close Marked WorkerGlobalScope.close() as deprecated, updated support info, and added notes to explain: https://developer.mozilla.org/en-US/docs/Web/API/WorkerGlobalScope https://developer.mozilla.org/en-US/docs/Web/API/WorkerGlobalScope/close Finally, I've added a note to the Fx54 release notes: https://developer.mozilla.org/en-US/Firefox/Releases/54#Web_workers_and_service_Workers Let me know if this all looks OK. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•