Closed Bug 1336257 Opened 3 years ago Closed 2 years ago

Use of http://mozqa.com/ in m-c/source/services/sync/tests/tps/test_tabs.js

Categories

(Testing Graveyard :: TPS, defect)

Version 3
defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: Atoll, Assigned: tcsc)

References

Details

Attachments

(1 file)

Hi, while reviewing mozqa usage in mozilla-central, we observed that there are two instances of http://mozqa.com/ in source/services/sync/tests/tps/test_tabs.js.

/*
 * Tab lists.
 */

var tabs1 = [
  { uri: "http://mozqa.com/data/firefox/layout/mozilla.html",
    title: "Mozilla",
    profile: "profile1"
...
var tabs2 = [
  { uri: "http://mozqa.com/data/firefox/layout/mozilla_community.html",
    title: "Mozilla Community",
    profile: "profile2"

I'd like to propose one of three replacement URL prefixes here:

1) http://no-ssl.mozqa.com/

If the URL *must* be a 200 OK url to valid content, and *must* be fetched over plain HTTP, then replace 'http://mozqa.com' with 'http://no-ssl.mozqa.com'. (This will require bug 1336254 to be completed first.)

2) https://nxdomain.mozqa.com/

If the URL *can* be invalid, and does not need to resolve nor retrieve any content, then replace 'http://mozqa.com' with 'https://nxdomain.mozqa.com'. This makes clear the intentions of this URL, as we explicitly would never offer service at 'nxdomain.mozqa.com', while permitting your tests to continue operating as expected.

3) https://mozqa.com/

If the URL *must* be a 200 OK url to valid content, but *may* be fetched over HTTPS, then replace 'http://mozqa.com' with 'https://mozqa.com'. This is available immediately and will remain working and supported.

(Setting needinfo? markh per my conversation with :whimboo.)
Flags: needinfo?(markh)
See Also: → 1336254
I suspect we never actually visit those URLs. Thom, can you please verify that we don't care what those URLs are?
Flags: needinfo?(markh) → needinfo?(tchiovoloni)
I think we'll load them and I'm not sure if we'll sync tabs for tabs that fail to load.

IMO we should just switch to HTTPS, no reason not to.
Flags: needinfo?(tchiovoloni)
(In reply to Thom Chiovoloni [:tcsc] from comment #2)
> I think we'll load them and I'm not sure if we'll sync tabs for tabs that
> fail to load.

Doh - thanks - for some reason I thought they were bookmarks!

> IMO we should just switch to HTTPS, no reason not to.

Agreed, thanks.
Excellent. I can help with a patch for option 3 if that's useful here, or otherwise it should be a simple change. Thank you!
(In reply to Richard Soderberg [:atoll] from comment #4)
> Excellent. I can help with a patch for option 3 if that's useful here, or
> otherwise it should be a simple change. Thank you!

A patch would be very useful (and help ensure it doesn't slip off our radar!), thanks!
Assignee: nobody → tchiovoloni
Comment on attachment 8933120 [details]
Bug 1336257 - Use HTTPS for mozqa url in TPS.

https://reviewboard.mozilla.org/r/204096/#review209574
Attachment #8933120 - Flags: review?(markh) → review+
Comment on attachment 8933120 [details]
Bug 1336257 - Use HTTPS for mozqa url in TPS.

This patch satisfies the needs of my original request differently than I expected, but is also completely fine.
Attachment #8933120 - Flags: feedback+
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d47bd8c2d39d
Use HTTPS for mozqa url in TPS. r=markh
https://hg.mozilla.org/mozilla-central/rev/d47bd8c2d39d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.