1336309 - Modify the access key for "play tab" option

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alastor Wu [:alwu]]

Fork from bug1330232 comment 13, we don't consider the access key conflict, we need to use other key for this option.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1336309 - modify the access key for 'play tab' option.

Because the key "P" was already used by "pin tab", we need to change the access key.

Review commit: https://reviewboard.mozilla.org/r/109380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109380/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8833156 [details]
Bug 1336309 - modify the access key for 'play tab' option.

https://reviewboard.mozilla.org/r/109380/#review110614

::: browser/locales/en-US/chrome/browser/browser.properties:818
(Diff revision 1)
>  muteTab.label = Mute Tab
>  muteTab.accesskey = M
>  unmuteTab.label = Unmute Tab
>  unmuteTab.accesskey = M
>  playTab.label = Play Tab
> -playTab.accesskey = P
> +playTab.accesskey = L

This should be 'l' (lower case L) because the character is lowercase in the label. We should also get this fixed for unmuteTab.accesskey but in a separate bug.

Comment 3

[Alastor Wu [:alwu]]

Comment on attachment 8833156 [details]
Bug 1336309 - modify the access key for 'play tab' option.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109380/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78d1347fb9f6
modify the access key for 'play tab' option. r=jaws

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/78d1347fb9f6

Comment 6

[Simona Badau, Desktop QA]

Verified as fixed using the latest Nightly 54.0a1 (Build ID:20170207030214) on Windows 10 x64, Ubuntu 16.04, Mac OS X 10.11.