Closed Bug 1336309 Opened 4 years ago Closed 4 years ago

Modify the access key for "play tab" option

Categories

(Firefox :: Tabbed Browser, defect)

47 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 54
Tracking Status
firefox54 --- verified

People

(Reporter: alwu, Assigned: alwu)

References

Details

Attachments

(1 file)

Fork from bug1330232 comment 13, we don't consider the access key conflict, we need to use other key for this option.
Comment on attachment 8833156 [details]
Bug 1336309 - modify the access key for 'play tab' option.

https://reviewboard.mozilla.org/r/109380/#review110614

::: browser/locales/en-US/chrome/browser/browser.properties:818
(Diff revision 1)
>  muteTab.label = Mute Tab
>  muteTab.accesskey = M
>  unmuteTab.label = Unmute Tab
>  unmuteTab.accesskey = M
>  playTab.label = Play Tab
> -playTab.accesskey = P
> +playTab.accesskey = L

This should be 'l' (lower case L) because the character is lowercase in the label. We should also get this fixed for unmuteTab.accesskey but in a separate bug.
Attachment #8833156 - Flags: review?(jaws) → review+
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78d1347fb9f6
modify the access key for 'play tab' option. r=jaws
https://hg.mozilla.org/mozilla-central/rev/78d1347fb9f6
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Verified as fixed using the latest Nightly 54.0a1 (Build ID:20170207030214) on Windows 10 x64, Ubuntu 16.04, Mac OS X 10.11.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.